From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::42f; helo=mail-wr1-x42f.google.com; envelope-from=nariman.poushin@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [IPv6:2a00:1450:4864:20::42f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B45A7211D2316 for ; Wed, 6 Mar 2019 07:59:10 -0800 (PST) Received: by mail-wr1-x42f.google.com with SMTP id i12so13993742wrw.0 for ; Wed, 06 Mar 2019 07:59:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=euFTqxkQO3W+nWYEQqoMuqSo9TLrOSxouSBWGlnDsVE=; b=FZalhOOu9bczzCSuEPNh1IoYV2wPkefE1Y3umBzGSylZxeh4GLI7O76R7OJEZiVGI7 7sKBhrOXXnBgPcxgTXN31SqHi/GRxL82ljhIhqMb6He/mtD4NCc/2HpwHOjjDsoCN6YV /HFT65S5P/GzpFke3+mKd5APcChn/QPs747HyTavpnniLeuMjuMDxsYWEXSvtTtNoZdl mlxBJz9v5UTHWmc2pmABsxZRav+Sk37GnNLR1VtTh2uE7l6H5dmqXv070ZRyNLb9xIZm alJfcQkFWB1GpVTDaVeJ0XVSirOQWPGhDPtBov5h3oc8Tzz4AqDzsBsYqMQoS912Kc/v ZlNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=euFTqxkQO3W+nWYEQqoMuqSo9TLrOSxouSBWGlnDsVE=; b=R1GwvLKXof3AoZmAv9BWsZbHGGrtAhUwxwoAAoireiWdlJdqAg1HgikFjend0H5s6w 8iwCfvrjmWFTInJa4JVeEozMVm4RXZd0HbMJZhGO9o9A2yjAN+w6//2qVI8lA2yJZbV1 y6XoOXVnH27kXUSZnqq2Y8ggGd5AUkqqsnTU3aC9kO4IqUEs8D34JPBWzatsaEMG2UA+ fVbSTiL8VkZjOlIXtYVfuXgUHbWZA40pLFnCDFKFro8cOEEWq7OyfGa6ITpFY+hViDTx 7oIdc/XfwB+jmiT96wPNjWX2zYDIEkHDOSXVV8m2inDcSsr382n/et3r8lG+bRE9CgJs ASSA== X-Gm-Message-State: APjAAAWD4XtoLHZ8/si14a7EAR+x8rem3jOSY1r6Y9bUce8YhpwD7YoI C3R3lFulZBFMCnTBcFojIZ0CinD4MjVwpS8ntAdX8A== X-Google-Smtp-Source: APXvYqz/Bfg3pXMnSqvutF7j+2UgvqD2SIw76rxVaijd1aKVpJHiIzxQ7c3n+AU8qdGUIP95hSMM8/7+yue/LhAmPh0= X-Received: by 2002:a5d:6a8e:: with SMTP id s14mr3440582wru.31.1551887948514; Wed, 06 Mar 2019 07:59:08 -0800 (PST) MIME-Version: 1.0 References: <20190306070514.19220-1-zhichao.gao@intel.com> In-Reply-To: From: Nariman Poushin Date: Wed, 6 Mar 2019 16:01:10 +0000 Message-ID: To: "Carsey, Jaben" Cc: "Gao, Zhichao" , "edk2-devel@lists.01.org" , "Gao, Liming" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [PATCH] ShellPkg/UefiShellAcpiViewCommandLib: Change the note in uni X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Mar 2019 15:59:11 -0000 Content-Type: text/plain; charset="UTF-8" On Wed, 6 Mar 2019 at 15:54, Carsey, Jaben wrote: > Reviewed-by: Jaben Carsey > > > -----Original Message----- > > From: Gao, Zhichao > > Sent: Tuesday, March 05, 2019 11:05 PM > > To: edk2-devel@lists.01.org > > Cc: Ni, Ray ; Carsey, Jaben ; > > Gao, Liming > > Subject: [PATCH] ShellPkg/UefiShellAcpiViewCommandLib: Change the note > > in uni > > Importance: High > > > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1146 > > > > Add DSDT and SSDT description in the help information. Depend > > on the implement of UefiShellAcpiViewCommandLib, the "acpiview" > > command support to show all present type in the system not only > > support the listed type in the help information. So change the > > help information of this command. > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Zhichao Gao > > Cc: Ruiyu Ni > > Cc: Jaben Carsey > > Cc: Liming Gao > > --- > > .../UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.uni | 8 > > +++++++- > > 1 file changed, 7 insertions(+), 1 deletion(-) > > > > diff --git > > a/ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewComm > > andLib.uni > > b/ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewComm > > andLib.uni > > index 0762eeba53..f2a2400b91 100644 > > --- > > a/ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewComm > > andLib.uni > > +++ > > b/ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewComm > > andLib.uni > > @@ -74,10 +74,15 @@ > > " 1. The AcpiTable parameter can match any installed table type.\r\n" > > " Tables without specific handling will be displayed as a raw hex > dump > > (or\r\n" > > " dumped to a file if -d is used).\r\n" > > -" 2. Formatted display and checking is provided for these signature > > types:\r\n" > > +" 2. -s option supports to display the specified AcpiTable type that is > > present\r\n" > > +" in the system. For normal type AcpiTable, it would display the > data of > > the\r\n" > > +" AcpiTable and AcpiTable header. The following type may contain > header > > type\r\n" > > +" other than AcpiTable header. The acual header can refer to the > ACPI > > spec 6.2\r\n" > > +" Extra A. Particual types:\r\n" > Should this be "Particular"? > > " APIC - Multiple APIC Description Table (MADT)\r\n" > > " BGRT - Boot Graphics Resource Table\r\n" > > " DBG2 - Debug Port Table 2\r\n" > > +" DSDT - Differentiated System Description Table\r\n" > > " FACP - Fixed ACPI Description Table (FADT)\r\n" > > " GTDT - Generic Timer Description Table\r\n" > > " IORT - IO Remapping Table\r\n" > > @@ -87,6 +92,7 @@ > > " SLIT - System Locality Information Table\r\n" > > " SPCR - Serial Port Console Redirection Table\r\n" > > " SRAT - System Resource Affinity Table\r\n" > > +" SSDT - Secondary SystemDescription Table\r\n" > > " XSDT - Extended System Description Table\r\n" > > " \r\n" > > ".SH STANDARDS\r\n" > > -- > > 2.16.2.windows.1 > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel >