From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f179.google.com (mail-yw1-f179.google.com [209.85.128.179]) by mx.groups.io with SMTP id smtpd.web10.1739.1659592899539849963 for ; Wed, 03 Aug 2022 23:01:40 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@starlabs-systems.20210112.gappssmtp.com header.s=20210112 header.b=YqwQCtii; spf=pass (domain: starlabs.systems, ip: 209.85.128.179, mailfrom: sean@starlabs.systems) Received: by mail-yw1-f179.google.com with SMTP id 00721157ae682-31f661b3f89so190702647b3.11 for ; Wed, 03 Aug 2022 23:01:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=starlabs-systems.20210112.gappssmtp.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=EO/Zn79thmvtJ/3gFvVMotzoknBj/TakG8rHjUkBBQQ=; b=YqwQCtiiTCgtpfUFKT5/W500fdLfDii9SF6buNJzSsc5KlSvsoK+RgIl0Z6Bu3W6/n qgNWGiCo0oPGjzStqWs4vJWrTu4/yka0uWvreshOKNZT37zkBnI7wMoBB8Wf6okDJlNh 8nXuLknKX3AeUkeWuYXLyt8jkpvmsF9QRpq5396cPPOe99hm+vMLY0Y54Lc4JMwixvw5 aYw3wmZM6kGYa9F2LhuG/g0RYHyiHBtYNCBqCvbRLzeQuNKFX2z2OKhojD6K21k0hsOO Mv4LtKjAiY+HRJCGjL0yOonf0Z4EaL+ZzKwUZ90dhIp1R/lRMcbf8AOwfw4FOjARTrph hlsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=EO/Zn79thmvtJ/3gFvVMotzoknBj/TakG8rHjUkBBQQ=; b=0JkN3MwWExrC6UkVs1kMb2AzBH+c3tLeVUI7sEKIaDoGntbvsIBv79xUSMY8TS1TaX R2PajmLNYHI51sKH54KlA9DGYLfhxPln/1zHbqjG5b9k3IdPyZlFCwoXdn3k8x7gdSwR Ej7WkH+upYHbDVztIBrnlFqmM0xlQ9AAORj9KPlF5Cd0fEqUqbrf9O54zVEvsNHsj9Ix BD6tXqf9KAAXo1gR0ePGo74A/t9UfyznddOB95TB1Lkrjjadbq2Qlbg56Oy3qfpz3KVd LikkMAuZEGQ/HY0jGXK17Yu+1dMcuqsZU1ZWWVkUz5dOs1OyJzUqFglDQKu9AQTDQFZr I4ug== X-Gm-Message-State: ACgBeo3X3PpGoSFk8FAi4jONh3JAhAJctSLzcpOXJn3DDIpHbYbQWHC1 lk2eDbFdClUA7eJsl8GsWfoizF4F0H2LZ5UZkLgP4hVcQg== X-Google-Smtp-Source: AA6agR6YD9/+kBLCa9VYndNB+LzA64rQ19efpIuFskRKs4lbpK/GJm8uvHUm8+IL3kybLJRl8i4ENRkUq9YL6DbKHVc= X-Received: by 2002:a81:168d:0:b0:31f:6595:4195 with SMTP id 135-20020a81168d000000b0031f65954195mr337364yww.355.1659592898252; Wed, 03 Aug 2022 23:01:38 -0700 (PDT) MIME-Version: 1.0 References: <657766b60de4e2ecb2ba835a015d2274699a9ba5.1659470421.git.sean@starlabs.systems> In-Reply-To: From: "Sean Rhodes" Date: Thu, 4 Aug 2022 07:01:27 +0100 Message-ID: Subject: Re: [edk2-devel] [PATCH 1/2] UefiPayloadPkg: Add a Macro to enable Boot Logo To: devel@edk2.groups.io, guo.dong@intel.com Cc: "Ni, Ray" Content-Type: multipart/alternative; boundary="0000000000002c2a8205e56415e5" --0000000000002c2a8205e56415e5 Content-Type: text/plain; charset="UTF-8" Reviewed-by: Sean Rhodes On Wed, 3 Aug 2022 at 22:14, Guo Dong wrote: > > Reviewed-by: Guo Dong > > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Sean Rhodes > Sent: Tuesday, August 2, 2022 1:00 PM > To: devel@edk2.groups.io > Cc: Rhodes, Sean ; Dong, Guo ; > Ni, Ray > Subject: [edk2-devel] [PATCH 1/2] UefiPayloadPkg: Add a Macro to enable > Boot Logo > > Add a macro called BOOTSPLASH_IMAGE, which when enabled, will display a > logo at boot time. > > Cc: Guo Dong > Cc: Ray Ni > Signed-off-by: Sean Rhodes > --- > .../Library/PlatformBootManagerLib/PlatformBootManager.c | 9 +++++++++ > .../PlatformBootManagerLib/PlatformBootManagerLib.inf | 1 + > UefiPayloadPkg/UefiPayloadPkg.dsc | 6 ++++++ > UefiPayloadPkg/UefiPayloadPkg.fdf | 4 ++++ > 4 files changed, 20 insertions(+) > > diff --git > a/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManager.c > b/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManager.c > index b360e29dfe..a3b98f713d 100644 > --- a/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManager.c > +++ b/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManager. > +++ c > @@ -243,6 +243,8 @@ PlatformBootManagerAfterConsole ( > { EFI_GRAPHICS_OUTPUT_BLT_PIXEL Black; > EFI_GRAPHICS_OUTPUT_BLT_PIXEL White;+ EDKII_PLATFORM_LOGO_PROTOCOL > *PlatformLogo;+ EFI_STATUS Status; if > (mUniversalPayloadPlatformBootManagerOverrideInstance != NULL) { > mUniversalPayloadPlatformBootManagerOverrideInstance->AfterConsole ();@@ > -252,6 +254,13 @@ PlatformBootManagerAfterConsole ( > Black.Blue = Black.Green = Black.Red = Black.Reserved = 0; White.Blue > = White.Green = White.Red = White.Reserved = 0xFF; + Status = > gBS->LocateProtocol (&gEdkiiPlatformLogoProtocolGuid, NULL, (VOID > **)&PlatformLogo);++ if (!EFI_ERROR (Status)) {+ > gST->ConOut->ClearScreen (gST->ConOut);+ BootLogoEnableLogo ();+ }+ > EfiBootManagerConnectAll (); EfiBootManagerRefreshAllBootOption (); diff > --git > a/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf > b/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf > index 9f58c460cd..7ec93420f2 100644 > --- > a/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf > +++ b/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManagerL > +++ ib.inf > @@ -39,6 +39,7 @@ > UefiRuntimeServicesTableLib UefiLib UefiBootManagerLib+ > BootLogoLib PcdLib DxeServicesLib MemoryAllocationLibdiff --git > a/UefiPayloadPkg/UefiPayloadPkg.dsc b/UefiPayloadPkg/UefiPayloadPkg.dsc > index e78e959ce4..abe1a42709 100644 > --- a/UefiPayloadPkg/UefiPayloadPkg.dsc > +++ b/UefiPayloadPkg/UefiPayloadPkg.dsc > @@ -42,6 +42,7 @@ > DEFINE CRYPTO_PROTOCOL_SUPPORT = FALSE DEFINE SD_MMC_TIMEOUT > = 1000000 DEFINE USE_CBMEM_FOR_CONSOLE = FALSE+ DEFINE > BOOTSPLASH_IMAGE = FALSE # # NULL: NullMemoryTestDxe@@ > -229,6 +230,7 @@ > > CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf > SecurityManagementLib|MdeModulePkg/Library/DxeSecurityManagementLib/DxeSecurityManagementLib.inf > UefiBootManagerLib|MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf+ > BootLogoLib|MdeModulePkg/Library/BootLogoLib/BootLogoLib.inf > CustomizedDisplayLib|MdeModulePkg/Library/CustomizedDisplayLib/CustomizedDisplayLib.inf > FrameBufferBltLib|MdeModulePkg/Library/FrameBufferBltLib/FrameBufferBltLib.inf > @@ -432,6 +434,7 @@ > > gUefiPayloadPkgTokenSpaceGuid.PcdDispatchModuleAbove4GMemory|$(ABOVE_4G_MEMORY) > gUefiPayloadPkgTokenSpaceGuid.PcdBootManagerEscape|$(BOOT_MANAGER_ESCAPE)+ > gEfiMdePkgTokenSpaceGuid.PcdMaximumUnicodeStringLength|1800000 !if > $(CRYPTO_PROTOCOL_SUPPORT) == TRUE@@ -616,6 +619,9 @@ > !endif UefiCpuPkg/CpuDxe/CpuDxe.inf > MdeModulePkg/Universal/BdsDxe/BdsDxe.inf+!if $(BOOTSPLASH_IMAGE)+ > MdeModulePkg/Logo/LogoDxe.inf+!endif > MdeModulePkg/Application/UiApp/UiApp.inf { > NULL|MdeModulePkg/Library/DeviceManagerUiLib/DeviceManagerUiLib.infdiff > --git a/UefiPayloadPkg/UefiPayloadPkg.fdf > b/UefiPayloadPkg/UefiPayloadPkg.fdf > index afdd6447a7..d7c9db191c 100644 > --- a/UefiPayloadPkg/UefiPayloadPkg.fdf > +++ b/UefiPayloadPkg/UefiPayloadPkg.fdf > @@ -165,6 +165,10 @@ INF MdeModulePkg/Universal/EbcDxe/EbcDxe.inf > INF UefiPayloadPkg/BlSupportDxe/BlSupportDxe.inf INF > MdeModulePkg/Universal/SmbiosDxe/SmbiosDxe.inf+!if $(BOOTSPLASH_IMAGE)+INF > MdeModulePkg/Logo/LogoDxe.inf+!endif+ # # PCI Support #-- > 2.34.1 > > > > -=-=-=-=-=-= > Groups.io Links: You receive all messages sent to this group. > View/Reply Online (#92059): https://edk2.groups.io/g/devel/message/92059 > Mute This Topic: https://groups.io/mt/92779006/1781375 > Group Owner: devel+owner@edk2.groups.io > Unsubscribe: https://edk2.groups.io/g/devel/unsub [guo.dong@intel.com] > -=-=-=-=-=-= > > > > > > > > --0000000000002c2a8205e56415e5 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Reviewed-by: Sean Rhodes <sean@starlabs.systems>

On Wed, 3 Aug 2022 at 22:14, Guo Dong <guo.dong@intel.com> wrote:

Reviewed-by: Guo Dong <guo.dong@intel.com>

-----Original Message-----
From: devel@edk2.= groups.io <devel@edk2.groups.io> On Behalf Of Sean Rhodes
Sent: Tuesday, August 2, 2022 1:00 PM
To: devel@edk2.gr= oups.io
Cc: Rhodes, Sean <sean@starlabs.systems>; Dong, Guo <guo.dong@intel.com>; Ni, = Ray <ray.ni@intel.= com>
Subject: [edk2-devel] [PATCH 1/2] UefiPayloadPkg: Add a Macro to enable Boo= t Logo

Add a macro called BOOTSPLASH_IMAGE, which when enabled, will display a log= o at boot time.

Cc: Guo Dong <gu= o.dong@intel.com>
Cc: Ray Ni <ray.ni= @intel.com>
Signed-off-by: Sean Rhodes <sean@starlabs.systems>
---
=C2=A0.../Library/PlatformBootManagerLib/PlatformBootManager.c | 9 ++++++++= +
=C2=A0.../PlatformBootManagerLib/PlatformBootManagerLib.inf=C2=A0 =C2=A0 | = 1 +
=C2=A0UefiPayloadPkg/UefiPayloadPkg.dsc=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 | 6 ++++++
=C2=A0UefiPayloadPkg/UefiPayloadPkg.fdf=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 | 4 ++++
=C2=A04 files changed, 20 insertions(+)

diff --git a/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootMana= ger.c b/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManager.c=
index b360e29dfe..a3b98f713d 100644
--- a/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManager.c +++ b/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManager. +++ c
@@ -243,6 +243,8 @@ PlatformBootManagerAfterConsole (
=C2=A0{=C2=A0 =C2=A0EFI_GRAPHICS_OUTPUT_BLT_PIXEL=C2=A0 Black;=C2=A0 =C2=A0= EFI_GRAPHICS_OUTPUT_BLT_PIXEL=C2=A0 White;+=C2=A0 EDKII_PLATFORM_LOGO_PROTO= COL=C2=A0 =C2=A0*PlatformLogo;+=C2=A0 EFI_STATUS=C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0Status;=C2=A0 =C2=A0 if (m= UniversalPayloadPlatformBootManagerOverrideInstance !=3D NULL) {=C2=A0 =C2= =A0 =C2=A0mUniversalPayloadPlatformBootManagerOverrideInstance->AfterCon= sole ();@@ -252,6 +254,13 @@ PlatformBootManagerAfterConsole (
=C2=A0 =C2=A0Black.Blue =3D Black.Green =3D Black.Red =3D Black.Reserved = =3D 0;=C2=A0 =C2=A0White.Blue =3D White.Green =3D White.Red =3D White.Reser= ved =3D 0xFF; +=C2=A0 Status =3D gBS->LocateProtocol (&gEdkiiPlatfor= mLogoProtocolGuid, NULL, (VOID **)&PlatformLogo);++=C2=A0 if (!EFI_ERRO= R (Status)) {+=C2=A0 =C2=A0 gST->ConOut->ClearScreen (gST->ConOut)= ;+=C2=A0 =C2=A0 BootLogoEnableLogo ();+=C2=A0 }+=C2=A0 =C2=A0EfiBootManager= ConnectAll ();=C2=A0 =C2=A0EfiBootManagerRefreshAllBootOption (); diff --gi= t a/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.in= f b/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.in= f
index 9f58c460cd..7ec93420f2 100644
--- a/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.= inf
+++ b/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManagerL +++ ib.inf
@@ -39,6 +39,7 @@
=C2=A0 =C2=A0UefiRuntimeServicesTableLib=C2=A0 =C2=A0UefiLib=C2=A0 =C2=A0Ue= fiBootManagerLib+=C2=A0 BootLogoLib=C2=A0 =C2=A0PcdLib=C2=A0 =C2=A0DxeServi= cesLib=C2=A0 =C2=A0MemoryAllocationLibdiff --git a/UefiPayloadPkg/UefiPaylo= adPkg.dsc b/UefiPayloadPkg/UefiPayloadPkg.dsc
index e78e959ce4..abe1a42709 100644
--- a/UefiPayloadPkg/UefiPayloadPkg.dsc
+++ b/UefiPayloadPkg/UefiPayloadPkg.dsc
@@ -42,6 +42,7 @@
=C2=A0 =C2=A0DEFINE CRYPTO_PROTOCOL_SUPPORT=C2=A0 =C2=A0 =C2=A0 =3D FALSE= =C2=A0 =C2=A0DEFINE SD_MMC_TIMEOUT=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0=3D 1000000=C2=A0 =C2=A0DEFINE USE_CBMEM_FOR_CONSOLE=C2=A0 = =C2=A0 =C2=A0 =C2=A0 =3D FALSE+=C2=A0 DEFINE BOOTSPLASH_IMAGE=C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0=3D FALSE=C2=A0 =C2=A0 #=C2=A0 =C2=A0# NU= LL:=C2=A0 =C2=A0 NullMemoryTestDxe@@ -229,6 +230,7 @@
=C2=A0 =C2=A0CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLi= bNull.inf=C2=A0 =C2=A0SecurityManagementLib|MdeModulePkg/Library/DxeSecurit= yManagementLib/DxeSecurityManagementLib.inf=C2=A0 =C2=A0UefiBootManagerLib|= MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf+=C2=A0 BootL= ogoLib|MdeModulePkg/Library/BootLogoLib/BootLogoLib.inf=C2=A0 =C2=A0Customi= zedDisplayLib|MdeModulePkg/Library/CustomizedDisplayLib/CustomizedDisplayLi= b.inf=C2=A0 =C2=A0FrameBufferBltLib|MdeModulePkg/Library/FrameBufferBltLib/= FrameBufferBltLib.inf @@ -432,6 +434,7 @@
=C2=A0 =C2=A0 gUefiPayloadPkgTokenSpaceGuid.PcdDispatchModuleAbove4GMemory|= $(ABOVE_4G_MEMORY)=C2=A0 =C2=A0gUefiPayloadPkgTokenSpaceGuid.PcdBootManager= Escape|$(BOOT_MANAGER_ESCAPE)+=C2=A0 =C2=A0gEfiMdePkgTokenSpaceGuid.PcdMaxi= mumUnicodeStringLength|1800000=C2=A0 !if $(CRYPTO_PROTOCOL_SUPPORT) =3D=3D = TRUE@@ -616,6 +619,9 @@
=C2=A0!endif=C2=A0 =C2=A0UefiCpuPkg/CpuDxe/CpuDxe.inf=C2=A0 =C2=A0MdeModule= Pkg/Universal/BdsDxe/BdsDxe.inf+!if $(BOOTSPLASH_IMAGE)+=C2=A0 MdeModulePkg= /Logo/LogoDxe.inf+!endif=C2=A0 =C2=A0MdeModulePkg/Application/UiApp/UiApp.i= nf {=C2=A0 =C2=A0 =C2=A0<LibraryClasses>=C2=A0 =C2=A0 =C2=A0 =C2=A0NU= LL|MdeModulePkg/Library/DeviceManagerUiLib/DeviceManagerUiLib.infdiff --git= a/UefiPayloadPkg/UefiPayloadPkg.fdf b/UefiPayloadPkg/UefiPayloadPkg.fdf index afdd6447a7..d7c9db191c 100644
--- a/UefiPayloadPkg/UefiPayloadPkg.fdf
+++ b/UefiPayloadPkg/UefiPayloadPkg.fdf
@@ -165,6 +165,10 @@ INF MdeModulePkg/Universal/EbcDxe/EbcDxe.inf
=C2=A0INF UefiPayloadPkg/BlSupportDxe/BlSupportDxe.inf=C2=A0 INF MdeModuleP= kg/Universal/SmbiosDxe/SmbiosDxe.inf+!if $(BOOTSPLASH_IMAGE)+INF MdeModuleP= kg/Logo/LogoDxe.inf+!endif+ # # PCI Support #--
2.34.1



-=3D-=3D-=3D-=3D-=3D-=3D
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#92059): https://edk2.groups.io/g/dev= el/message/92059
Mute This Topic: https://groups.io/mt/92779006/1781375
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [guo.dong@intel.com] -=3D-=3D-=3D-=3D-=3D-=3D







--0000000000002c2a8205e56415e5--