From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oo1-f52.google.com (mail-oo1-f52.google.com [209.85.161.52]) by mx.groups.io with SMTP id smtpd.web12.983.1666816231220227101 for ; Wed, 26 Oct 2022 13:30:31 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@starlabs-systems.20210112.gappssmtp.com header.s=20210112 header.b=B+ULB2sr; spf=pass (domain: starlabs.systems, ip: 209.85.161.52, mailfrom: sean@starlabs.systems) Received: by mail-oo1-f52.google.com with SMTP id g10-20020a4ab4ca000000b00481082808cbso2311024ooo.10 for ; Wed, 26 Oct 2022 13:30:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=starlabs-systems.20210112.gappssmtp.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=c9PCchFvylIUvb0nRHzndWZzmKU7T/isRkmH+AYOBU4=; b=B+ULB2srD7i2zVb65w0p2QFu+h2zdsVpTlw91FEY05HEncahlstKA6CX7vRzUUBD/z j4acrgQSgJ6lsDGhWJ5DohgauKcgg7auXwquOhjCRnHq3KQygnFJKA4sgOoHe2C0dA0M f3JLMC4j+Ka91EESo5uV+hqYM0YY9XHgFuyOTSb6hL2QUa4HAzo1Z3t8c8bLOyMe7stl Qgv+7FB9DmKgQjpsV15oxHM2AbrunfISjqaGGcih+H1e/2+ElPux/HhwE+etL/m0qsn7 Wh664ATCqLzAh59ro+y7rG44N0D9PsL7spNlK9d7CePy0LzRtyVukAYdPXWXgyk1mbuT DkDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=c9PCchFvylIUvb0nRHzndWZzmKU7T/isRkmH+AYOBU4=; b=TyiPpv+dsYQwA8k/Uq+BDoDh/CNHv+0SsD2jZxkWGDyEUVug315mqH8Wh2rH32iaLH 8WPIQM7T0uJxEdkmCJsbMar0c/JqmEhhmLR7jqoX/eCjuv7traf0pDPrmNTp1Ueg/7S7 jQI3mt2fnTQ9DPDC2XfdphLvK/B/Q2VrkKu5oXC2L4x08Fx9YvJCsEos5JSPJMBLiTKZ 7Yc39sN39+2BLXM/njDWpOfpyXi41wvtvLSZE1O+/bf4tYm8wQdh5CoIoYOvgyjc/Lg0 cDkSS29W76NdvzyEscjLGbGtgKLU04xwdtnKa8vsTNizOihFXsgUQR1dPdvBk5uk8n0o 2syQ== X-Gm-Message-State: ACrzQf2LFUDXnlGmnTgdKfXkctrKx1pHyWOHO0JrMvQ1ufkbKO0HVjgb s2GPV6xAOPtN/d+tuGShFvy9h+C52JhzgicUbhmb X-Google-Smtp-Source: AMsMyM5nDr7wGQaUHRpK4XTUaUbc5XWv1juKjfRbARTHr+vf/8DIPgr2rQyWjRLuR+eKd9Lg1YQyA8aIqTTzZrkTIsA= X-Received: by 2002:a4a:1101:0:b0:476:7b37:e379 with SMTP id 1-20020a4a1101000000b004767b37e379mr19614697ooc.57.1666816230221; Wed, 26 Oct 2022 13:30:30 -0700 (PDT) MIME-Version: 1.0 References: <9c3d2f03a7f021c5044301f7b4d869b70e8990e0.1664179796.git.sean@starlabs.systems> <18575f8eca30cec6eb2fab56b878196925f0dd90.1664179796.git.sean@starlabs.systems> In-Reply-To: From: "Sean Rhodes" Date: Wed, 26 Oct 2022 21:30:18 +0100 Message-ID: Subject: Re: [edk2-devel] [PATCH 2/3] MdeModulePkg/Logo: Add a PCD to control the position of the Logo To: "Kinney, Michael D" Cc: "Ni, Ray" , "devel@edk2.groups.io" , "Gao, Zhichao" , "Wang, Jian J" , "Gao, Liming" Content-Type: multipart/alternative; boundary="0000000000004eff3a05ebf5e50b" --0000000000004eff3a05ebf5e50b Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Mike This patch is being upstreamed from the coreboot fork; about 70% of the coreboot community wants the logo centred (as the target OS is not Windows), and the rest want to use the 38.2% rule! Thanks Sean On Wed, 26 Oct 2022 at 05:55, Kinney, Michael D wrote: > Sean provided a sample PR that adds a PCD. > > > > I think we agree that a PCD is not required. The existing logic that > centers the logo should be updated to use the 38.2% rule. > > > > Mike > > > > *From:* Ni, Ray > *Sent:* Tuesday, October 25, 2022 7:32 PM > *To:* Kinney, Michael D ; devel@edk2.groups.i= o; > Rhodes, Sean > *Cc:* Gao, Zhichao ; Wang, Jian J < > jian.j.wang@intel.com>; Gao, Liming > *Subject:* RE: [edk2-devel] [PATCH 2/3] MdeModulePkg/Logo: Add a PCD to > control the position of the Logo > > > > Are you suggesting that the exiting logic be updated for this use case > without adding a new enum? > > - yes. > > > > *From:* Kinney, Michael D > *Sent:* Wednesday, October 26, 2022 12:21 AM > *To:* devel@edk2.groups.io; Ni, Ray ; Rhodes, Sean < > sean@starlabs.systems>; Kinney, Michael D > *Cc:* Gao, Zhichao ; Wang, Jian J < > jian.j.wang@intel.com>; Gao, Liming > *Subject:* RE: [edk2-devel] [PATCH 2/3] MdeModulePkg/Logo: Add a PCD to > control the position of the Logo > > > > Ray, > > > > Are you suggesting that the exiting logic be updated for this use case > without adding a new enum? > > > > Sean, can you provide a revised patch that does this? > > > > Thanks, > > > > Mike > > > > *From:* devel@edk2.groups.io *On Behalf Of *Ni, Ra= y > *Sent:* Tuesday, October 25, 2022 12:58 AM > *To:* devel@edk2.groups.io; Rhodes, Sean > *Cc:* Gao, Zhichao ; Wang, Jian J < > jian.j.wang@intel.com>; Gao, Liming > *Subject:* Re: [edk2-devel] [PATCH 2/3] MdeModulePkg/Logo: Add a PCD to > control the position of the Logo > > > > I need a reason of adding > EdkiiPlatformLogoDisplayAttributeMicrosoftRecommended. > > In my opinion, without adding this new enum value, it=E2=80=99s still pos= sible to > support MS recommendation. > > > > *From:* devel@edk2.groups.io *On Behalf Of *Sean > Rhodes > *Sent:* Tuesday, October 25, 2022 3:27 PM > *To:* Ni, Ray > *Cc:* devel@edk2.groups.io; Gao, Zhichao ; Wang, > Jian J ; Gao, Liming > *Subject:* Re: [edk2-devel] [PATCH 2/3] MdeModulePkg/Logo: Add a PCD to > control the position of the Logo > > > > Hi Ray > > > > Where would you suggest this code goes? edk2 should support both Microsof= t > recommended and "normal". The original patch handled this well. > > > > Thanks > > > > Sean > > > > On Mon, 10 Oct 2022 at 10:25, Ni, Ray wrote: > > The logic I shared below is from the LogoDxe driver which produces > EDKII_PLATFORM_LOGO_PROTOCOL. > > This driver should know the image size and it can account for the image > size. > > > > Thanks, > > Ray > > > > *From:* Sean Rhodes > *Sent:* Monday, October 10, 2022 4:51 PM > *To:* Ni, Ray > *Cc:* devel@edk2.groups.io; Gao, Zhichao ; Wang, > Jian J ; Gao, Liming > *Subject:* Re: [PATCH 2/3] MdeModulePkg/Logo: Add a PCD to control the > position of the Logo > > > > Hi Ray > > > > Thank you, it does, and I think it will work for most splash images. > However, the way it's written in my patch accounts for the Image size. Th= is > will handle splash images that are equal to, or larger than the resolutio= n > of the display. > > > > Thanks > > > > Sean > > > > On Sat, 8 Oct 2022 at 03:02, Ni, Ray wrote: > > Sean, > I remember that I evaluated the BGRT requirement when designing the > PlatformLogo protocol. > > So, I went back to got the code I wrote long time ago as below. > I didn't try to understand them now. Does it make sense to you? > > Status =3D gBS->HandleProtocol (gST->ConsoleOutHandle, > &gEfiGraphicsOutputProtocolGuid, (VOID **) &GraphicsOutput); > if (!EFI_ERROR (Status)) { > // > // Center of LOGO is in the vertical position 38.2% when > PcdBootLogoOnlyEnable is TRUE > // Y =3D (VerticalResolution - LogoHeight) / 2 > // Y' =3D VerticalResolution * 0.382 - LogoHeight * 0.5 > // OffsetY + Y =3D Y' > // OffsetY =3D Y' - Y =3D -0.118 * VerticalResolution > // > *Attribute =3D EdkiiPlatformLogoDisplayAttributeCenter; > *OffsetX =3D 0; > *OffsetY =3D -118 * (INTN) > GraphicsOutput->Mode->Info->VerticalResolution / 1000; > } > > Thanks, > Ray > > > -----Original Message----- > > From: Sean Rhodes > > Sent: Monday, September 26, 2022 4:10 PM > > To: devel@edk2.groups.io > > Cc: Rhodes, Sean ; Gao, Zhichao > > ; Ni, Ray ; Wang, Jian J > > ; Gao, Liming > > Subject: [PATCH 2/3] MdeModulePkg/Logo: Add a PCD to control the > > position of the Logo > > > > When set to true, the Logo is positioned according to the BGRT > > specification, 38.2% from the top of the screen. When set to false, > > no behaviour is changed and the logo is positioned centrally. > > > > Cc: Zhichao Gao > > Cc: Ray Ni > > Cc: Jian J Wang > > Cc: Liming Gao > > Signed-off-by: Sean Rhodes > > --- > > MdeModulePkg/Logo/Logo.c | 5 +++++ > > MdeModulePkg/Logo/LogoDxe.inf | 4 ++++ > > MdeModulePkg/MdeModulePkg.dec | 6 ++++++ > > MdeModulePkg/MdeModulePkg.uni | 6 ++++++ > > 4 files changed, 21 insertions(+) > > > > diff --git a/MdeModulePkg/Logo/Logo.c b/MdeModulePkg/Logo/Logo.c > > index 8ab874d2da..1638d0f984 100644 > > --- a/MdeModulePkg/Logo/Logo.c > > +++ b/MdeModulePkg/Logo/Logo.c > > @@ -13,6 +13,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent > > #include > > > > #include > > > > #include > > > > +#include > > > > > > > > typedef struct { > > > > EFI_IMAGE_ID ImageId; > > > > @@ -69,6 +70,10 @@ GetImage ( > > return EFI_NOT_FOUND; > > > > } > > > > > > > > + if (FixedPcdGetBool (PcdFollowMicrosoftRecommended)) { > > > > + mLogos[Current].Attribute =3D > > EdkiiPlatformLogoDisplayAttributeMicrosoftRecommended; > > > > + } > > > > + > > > > (*Instance)++; > > > > *Attribute =3D mLogos[Current].Attribute; > > > > *OffsetX =3D mLogos[Current].OffsetX; > > > > diff --git a/MdeModulePkg/Logo/LogoDxe.inf > > b/MdeModulePkg/Logo/LogoDxe.inf > > index 41215d25d8..ce29950089 100644 > > --- a/MdeModulePkg/Logo/LogoDxe.inf > > +++ b/MdeModulePkg/Logo/LogoDxe.inf > > @@ -41,6 +41,7 @@ > > UefiBootServicesTableLib > > > > UefiDriverEntryPoint > > > > DebugLib > > > > + PcdLib > > > > > > > > [Protocols] > > > > gEfiHiiDatabaseProtocolGuid ## CONSUMES > > > > @@ -48,6 +49,9 @@ > > gEfiHiiPackageListProtocolGuid ## PRODUCES CONSUMES > > > > gEdkiiPlatformLogoProtocolGuid ## PRODUCES > > > > > > > > +[Pcd] > > > > + gEfiMdeModulePkgTokenSpaceGuid.PcdFollowMicrosoftRecommended > > ## CONSUMES > > > > + > > > > [Depex] > > > > gEfiHiiDatabaseProtocolGuid AND > > > > gEfiHiiImageExProtocolGuid > > > > diff --git a/MdeModulePkg/MdeModulePkg.dec > > b/MdeModulePkg/MdeModulePkg.dec > > index 58e6ab0048..ac437990f1 100644 > > --- a/MdeModulePkg/MdeModulePkg.dec > > +++ b/MdeModulePkg/MdeModulePkg.dec > > @@ -2102,6 +2102,12 @@ > > # @Prompt The shared bit mask when Intel Tdx is enabled. > > > > > > gEfiMdeModulePkgTokenSpaceGuid.PcdTdxSharedBitMask|0x0|UINT64|0x > > 10000025 > > > > > > > > + ## This PCD sets the position of the Boot Logo. > > > > + # TRUE - The Logo is positioned following the recommendations fro= m > > Microsoft. > > > > + # FALSE - The logo is positioned in the center of the screen. > > > > + # @ Prompt This position of the boot logo > > > > + > > gEfiMdeModulePkgTokenSpaceGuid.PcdFollowMicrosoftRecommended|FA > > LSE|BOOLEAN|0x10000026 > > > > + > > > > [PcdsPatchableInModule] > > > > ## Specify memory size with page number for PEI code when > > > > # Loading Module at Fixed Address feature is enabled. > > > > diff --git a/MdeModulePkg/MdeModulePkg.uni > > b/MdeModulePkg/MdeModulePkg.uni > > index 33ce9f6198..09c1ac1cc1 100644 > > --- a/MdeModulePkg/MdeModulePkg.uni > > +++ b/MdeModulePkg/MdeModulePkg.uni > > @@ -1338,3 +1338,9 @@ > > #string > > STR_gEfiMdeModulePkgTokenSpaceGuid_PcdPcieResizableBarSupport_HEL > > P #language en-US "Indicates if the PCIe Resizable BAR Capability > > Supported.

\n" > > > > > "TRUE - PCIe Resizable BAR > > Capability is supported.
\n" > > > > > "FALSE - PCIe Resizable BAR > > Capability is not supported.
" > > > > + > > > > +#string > > STR_gEfiMdeModulePkgTokenSpaceGuid_PcdFollowMicrosoftRecommende > > d_PROMPT #language en-US "The position of the Boot Logo" > > > > + > > > > +#string > > STR_gEfiMdeModulePkgTokenSpaceGuid_PcdFollowMicrosoftRecommend_ > > HELP #language en-US "Sets the position of the Logo. When set to true= , > the > > Logo is positioned following the recommendations" > > > > + > " from Microsoft, 38.2% from > > the top of the screen." > > > > + > > > > -- > > 2.34.1 > >=20 > --0000000000004eff3a05ebf5e50b Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Mike

This patch is being upstreamed fro= m the coreboot fork; about 70% of the coreboot community wants the logo cen= tred (as the target OS is not Windows), and the rest want to use the 38.2% = rule!=C2=A0

Thanks

Sean

On Wed, 26 Oct= 2022 at 05:55, Kinney, Michael D <michael.d.kinney@intel.com> wrote:

Sean provided a sample PR that adds a PCD.<= /u>

=C2=A0

I think we agree that a PCD is not required.=C2=A0 The existing logic that centers the logo should be updated to use th= e 38.2% rule.

=C2=A0

Mike

=C2=A0

From: Ni, Ray <ray.ni@intel.com>
Sent: Tuesday, October 25, 2022 7:32 PM
To: Kinney, Michael D <michael.d.kinney@intel.com>; devel@edk2.groups.io; Rhodes, = Sean <sean@starlabs.systems>
Cc: Gao, Zhichao <zhichao.gao@intel.com>; Wang, Jian J <jian.j.wang@intel.com>; = Gao, Liming <gaoliming@byosoft.com.cn>
Subject: RE: [edk2-devel] [PATCH 2/3] MdeModulePkg/Logo: Add a PCD t= o control the position of the Logo

=C2=A0

Are you suggesting that the exiting logic be updated= for this use case without adding a new enum?

  • yes.

=C2=A0

From: Kinney, Michael D <michael.d.kinney@intel.com>
Sent: Wednesday, October 26, 2022 12:21 AM
To: devel@= edk2.groups.io; Ni, Ray <ray.ni@intel.com>; Rhodes, Sean <sean@starlabs.systems>; Kinne= y, Michael D <michael.d.kinney@intel.com>
Cc: Gao, Zhichao <zhichao.gao@intel.com>; Wang, Jian J <jian.j.wang@intel.com>; = Gao, Liming <gaoliming@byosoft.com.cn>
Subject: RE: [edk2-devel] [PATCH 2/3] MdeModulePkg/Logo: Add a PCD t= o control the position of the Logo

=C2=A0

Ray,

=C2=A0

Are you suggesting that the exiting logic be updated= for this use case without adding a new enum?

=C2=A0

Sean, can you provide a revised patch that does this= ?

=C2=A0

Thanks,

=C2=A0

Mike

=C2=A0

From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Ni, Ray
Sent: Tuesday, October 25, 2022 12:58 AM
To: devel@= edk2.groups.io; Rhodes, Sean <sean@starlabs.systems>
Cc: Gao, Zhichao <zhichao.gao@intel.com>; Wang, Jian J <jian.j.wang@intel.com>; = Gao, Liming <gaoliming@byosoft.com.cn>
Subject: Re: [edk2-devel] [PATCH 2/3] MdeModulePkg/Logo: Add a PCD t= o control the position of the Logo

=C2=A0

I need a reason of adding EdkiiPlatformLogoDisplayAt= tributeMicrosoftRecommended.

In my opinion, without adding this new enum value, i= t=E2=80=99s still possible to support MS recommendation.

=C2=A0

From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Sean Rhodes
Sent: Tuesday, October 25, 2022 3:27 PM
To: Ni, Ray <ray.ni@intel.com>
Cc: devel@= edk2.groups.io; Gao, Zhichao <zhichao.gao@intel.com>; Wang, Jian J <jian.j.wang@intel.com<= /a>>; Gao, Liming <gaoliming@byosoft.com.cn>
Subject: Re: [edk2-devel] [PATCH 2/3] MdeModulePkg/Logo: Add a PCD t= o control the position of the Logo

=C2=A0

Hi Ray

=C2=A0

Where would you suggest this code goes? edk2 should support bot= h Microsoft recommended and "normal". The original patch handled = this well.

=C2=A0

Thanks

=C2=A0

Sean

=C2=A0

On Mon, 10 Oct 2022 at 10:25, Ni, Ray <ray.ni@intel.com> wrote:=

The logic I shared below is from the LogoDxe driver = which produces EDKII_PLATFORM_LOGO_PROTOCOL.

This driver should know the image size and it can ac= count for the image size.

=C2=A0

Thanks,

Ray

=C2=A0

From: Sean Rhodes <sean@starlabs.systems>
Sent: Monday, October 10, 2022 4:51 PM
To: Ni, Ray <ray.ni@intel.com>
Cc: devel@= edk2.groups.io; Gao, Zhichao <zhichao.gao@intel.com>; Wang, Jian J <jian.j.wang@intel.com<= /a>>; Gao, Liming <gaoliming@byosoft.com.cn>
Subject: Re: [PATCH 2/3] MdeModulePkg/Logo: Add a PCD to control the= position of the Logo

=C2=A0

Hi Ray

=C2=A0

Thank you, it does, and I think it will work for most splash im= ages. However, the way it's written in my patch accounts for the Image size. This will handle splash images that are equal to, or larger th= an the resolution of the display.=C2=A0

=C2=A0

Thanks

=C2=A0

Sean

=C2=A0

On Sat, 8 Oct 2022 at 03:02, Ni, Ray <ray.ni@intel.com> wrote:<= u>

Sean,
I remember that I evaluated the BGRT requirement when designing the Platfor= mLogo protocol.

So, I went back to got the code I wrote long time ago as below.
I didn't try to understand them now. Does it make sense to you?

=C2=A0 =C2=A0 Status =3D gBS->HandleProtocol (gST->ConsoleOutHandle, = &gEfiGraphicsOutputProtocolGuid, (VOID **) &GraphicsOutput);
=C2=A0 =C2=A0 if (!EFI_ERROR (Status)) {
=C2=A0 =C2=A0 =C2=A0 //
=C2=A0 =C2=A0 =C2=A0 // Center of LOGO is in the vertical position 38.2% wh= en PcdBootLogoOnlyEnable is TRUE
=C2=A0 =C2=A0 =C2=A0 // Y =3D (VerticalResolution - LogoHeight) / 2
=C2=A0 =C2=A0 =C2=A0 // Y' =3D VerticalResolution * 0.382 - LogoHeight = * 0.5
=C2=A0 =C2=A0 =C2=A0 // OffsetY + Y =3D Y'
=C2=A0 =C2=A0 =C2=A0 // OffsetY =3D Y' - Y =3D -0.118 * VerticalResolut= ion
=C2=A0 =C2=A0 =C2=A0 //
=C2=A0 =C2=A0 =C2=A0 *Attribute =3D EdkiiPlatformLogoDisplayAttributeCenter= ;
=C2=A0 =C2=A0 =C2=A0 *OffsetX=C2=A0 =C2=A0=3D 0;
=C2=A0 =C2=A0 =C2=A0 *OffsetY=C2=A0 =C2=A0=3D -118 * (INTN) GraphicsOutput-= >Mode->Info->VerticalResolution / 1000;
=C2=A0 =C2=A0 }

Thanks,
Ray

> -----Original Message-----
> From: Sean Rhodes <sean@starlabs.systems>
> Sent: Monday, September 26, 2022 4:10 PM
> To: devel@ed= k2.groups.io
> Cc: Rhodes, Sean <sean@starlabs.systems>; Gao, Zhichao
> <zhichao= .gao@intel.com>; Ni, Ray <ray.ni@intel.com>; Wang, Jian J
> <jian.j.= wang@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>
> Subject: [PATCH 2/3] MdeModulePkg/Logo: Add a PCD to control the
> position of the Logo
>
> When set to true, the Logo is positioned according to the BGRT
> specification, 38.2% from the top of the screen. When set to false, > no behaviour is changed and the logo is positioned centrally.
>
> Cc: Zhichao Gao <zhichao.gao@intel.com>
> Cc: Ray Ni <r= ay.ni@intel.com>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Signed-off-by: Sean Rhodes <sean@starlabs.systems>
> ---
>=C2=A0 MdeModulePkg/Logo/Logo.c=C2=A0 =C2=A0 =C2=A0 | 5 +++++
>=C2=A0 MdeModulePkg/Logo/LogoDxe.inf | 4 ++++
>=C2=A0 MdeModulePkg/MdeModulePkg.dec | 6 ++++++
>=C2=A0 MdeModulePkg/MdeModulePkg.uni | 6 ++++++
>=C2=A0 4 files changed, 21 insertions(+)
>
> diff --git a/MdeModulePkg/Logo/Logo.c b/MdeModulePkg/Logo/Logo.c
> index 8ab874d2da..1638d0f984 100644
> --- a/MdeModulePkg/Logo/Logo.c
> +++ b/MdeModulePkg/Logo/Logo.c
> @@ -13,6 +13,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
>=C2=A0 #include <Protocol/HiiPackageList.h>
>
>=C2=A0 #include <Library/UefiBootServicesTableLib.h>
>
>=C2=A0 #include <Library/DebugLib.h>
>
> +#include <Library/PcdLib.h>
>
>
>
>=C2=A0 typedef struct {
>
>=C2=A0 =C2=A0 EFI_IMAGE_ID=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0ImageId;
>
> @@ -69,6 +70,10 @@ GetImage (
>=C2=A0 =C2=A0 =C2=A0 return EFI_NOT_FOUND;
>
>=C2=A0 =C2=A0 }
>
>
>
> +=C2=A0 if (FixedPcdGetBool (PcdFollowMicrosoftRecommended)) {
>
> +=C2=A0 =C2=A0 mLogos[Current].Attribute =3D
> EdkiiPlatformLogoDisplayAttributeMicrosoftRecommended;
>
> +=C2=A0 }
>
> +
>
>=C2=A0 =C2=A0 (*Instance)++;
>
>=C2=A0 =C2=A0 *Attribute =3D mLogos[Current].Attribute;
>
>=C2=A0 =C2=A0 *OffsetX=C2=A0 =C2=A0=3D mLogos[Current].OffsetX;
>
> diff --git a/MdeModulePkg/Logo/LogoDxe.inf
> b/MdeModulePkg/Logo/LogoDxe.inf
> index 41215d25d8..ce29950089 100644
> --- a/MdeModulePkg/Logo/LogoDxe.inf
> +++ b/MdeModulePkg/Logo/LogoDxe.inf
> @@ -41,6 +41,7 @@
>=C2=A0 =C2=A0 UefiBootServicesTableLib
>
>=C2=A0 =C2=A0 UefiDriverEntryPoint
>
>=C2=A0 =C2=A0 DebugLib
>
> +=C2=A0 PcdLib
>
>
>
>=C2=A0 [Protocols]
>
>=C2=A0 =C2=A0 gEfiHiiDatabaseProtocolGuid=C2=A0 =C2=A0 =C2=A0 =C2=A0 ##= CONSUMES
>
> @@ -48,6 +49,9 @@
>=C2=A0 =C2=A0 gEfiHiiPackageListProtocolGuid=C2=A0 =C2=A0 =C2=A0## PROD= UCES CONSUMES
>
>=C2=A0 =C2=A0 gEdkiiPlatformLogoProtocolGuid=C2=A0 =C2=A0 =C2=A0## PROD= UCES
>
>
>
> +[Pcd]
>
> +=C2=A0 gEfiMdeModulePkgTokenSpaceGuid.PcdFollowMicrosoftRecommended > ## CONSUMES
>
> +
>
>=C2=A0 [Depex]
>
>=C2=A0 =C2=A0 gEfiHiiDatabaseProtocolGuid AND
>
>=C2=A0 =C2=A0 gEfiHiiImageExProtocolGuid
>
> diff --git a/MdeModulePkg/MdeModulePkg.dec
> b/MdeModulePkg/MdeModulePkg.dec
> index 58e6ab0048..ac437990f1 100644
> --- a/MdeModulePkg/MdeModulePkg.dec
> +++ b/MdeModulePkg/MdeModulePkg.dec
> @@ -2102,6 +2102,12 @@
>=C2=A0 =C2=A0 # @Prompt The shared bit mask when Intel Tdx is enabled.<= br> >
>
> gEfiMdeModulePkgTokenSpaceGuid.PcdTdxSharedBitMask|0x0|UINT64|0x
> 10000025
>
>
>
> +=C2=A0 ## This PCD sets the position of the Boot Logo.
>
> +=C2=A0 #=C2=A0 =C2=A0TRUE=C2=A0 - The Logo is positioned following th= e recommendations from
> Microsoft.
>
> +=C2=A0 #=C2=A0 =C2=A0FALSE - The logo is positioned in the center of = the screen.
>
> +=C2=A0 # @ Prompt This position of the boot logo
>
> +
> gEfiMdeModulePkgTokenSpaceGuid.PcdFollowMicrosoftRecommended|FA
> LSE|BOOLEAN|0x10000026
>
> +
>
>=C2=A0 [PcdsPatchableInModule]
>
>=C2=A0 =C2=A0 ## Specify memory size with page number for PEI code when=
>
>=C2=A0 =C2=A0 #=C2=A0 Loading Module at Fixed Address feature is enable= d.
>
> diff --git a/MdeModulePkg/MdeModulePkg.uni
> b/MdeModulePkg/MdeModulePkg.uni
> index 33ce9f6198..09c1ac1cc1 100644
> --- a/MdeModulePkg/MdeModulePkg.uni
> +++ b/MdeModulePkg/MdeModulePkg.uni
> @@ -1338,3 +1338,9 @@
>=C2=A0 #string
> STR_gEfiMdeModulePkgTokenSpaceGuid_PcdPcieResizableBarSupport_HEL
> P #language en-US "Indicates if the PCIe Resizable BAR Capability=
> Supported.<BR><BR>\n"
>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 "TRUE=C2=A0 - PCIe Resizable BA= R
> Capability is supported.<BR>\n"
>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 "FALSE - PCIe Resizable BAR
> Capability is not supported.<BR>"
>
> +
>
> +#string
> STR_gEfiMdeModulePkgTokenSpaceGuid_PcdFollowMicrosoftRecommende
> d_PROMPT #language en-US "The position of the Boot Logo"
>
> +
>
> +#string
> STR_gEfiMdeModulePkgTokenSpaceGuid_PcdFollowMicrosoftRecommend_
> HELP=C2=A0 =C2=A0#language en-US "Sets the position of the Logo. = When set to true, the
> Logo is positioned following the recommendations"
>
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0" from Microsoft, 38.2% from
> the top of the screen."
>
> +
>
> --
> 2.34.1

--0000000000004eff3a05ebf5e50b--