From: "Sean Rhodes" <sean@starlabs.systems>
To: "Dong, Guo" <guo.dong@intel.com>
Cc: devel@edk2.groups.io, "Ni, Ray" <ray.ni@intel.com>
Subject: Re: [PATCH 3/3] UefiPayloadPkg: Hook up MICROSOFT_RECOMMENDED macro
Date: Tue, 9 Aug 2022 08:59:52 +0100 [thread overview]
Message-ID: <CABtds-13YPBpT2eNANC27P4nZ-j19x+d=eSm29_8Q89i46aiVg@mail.gmail.com> (raw)
In-Reply-To: <CY5PR11MB626024E29DDD7C55878F00869E629@CY5PR11MB6260.namprd11.prod.outlook.com>
[-- Attachment #1: Type: text/plain, Size: 1809 bytes --]
Hi Guo
Yes, that's fine with me.
This single patch can be disregarded then.
Thank you
Sean
On Tue, 9 Aug 2022, 06:29 Dong, Guo, <guo.dong@intel.com> wrote:
>
> Hi Sean,
> How about directly setting the PCD in the build command line instead of
> adding a MACRO?
> Prefer not adding new MACRO if we could avoid it.
>
> Thanks,
> Guo
> -----Original Message-----
> From: Sean Rhodes <sean@starlabs.systems>
> Sent: Friday, August 5, 2022 12:53 AM
> To: devel@edk2.groups.io
> Cc: Rhodes, Sean <sean@starlabs.systems>; Dong, Guo <guo.dong@intel.com>;
> Ni, Ray <ray.ni@intel.com>
> Subject: [PATCH 3/3] UefiPayloadPkg: Hook up MICROSOFT_RECOMMENDED macro
>
> Hook up MICROSOFT_RECOMMENDED macro to PcdFollowMicrosoftRecommended.
>
> Cc: Guo Dong <guo.dong@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Signed-off-by: Sean Rhodes <sean@starlabs.systems>
> ---
> UefiPayloadPkg/UefiPayloadPkg.dsc | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/UefiPayloadPkg/UefiPayloadPkg.dsc
> b/UefiPayloadPkg/UefiPayloadPkg.dsc
> index 91cd78dbf1..b3ed0f6a2e 100644
> --- a/UefiPayloadPkg/UefiPayloadPkg.dsc
> +++ b/UefiPayloadPkg/UefiPayloadPkg.dsc
> @@ -43,6 +43,7 @@
> DEFINE SD_MMC_TIMEOUT = 1000000
>
> DEFINE USE_CBMEM_FOR_CONSOLE = FALSE
>
> DEFINE BOOTSPLASH_IMAGE = FALSE
>
> + DEFINE MICROSOFT_RECOMMENDED = FALSE
>
>
>
> #
>
> # NULL: NullMemoryTestDxe
>
> @@ -440,6 +441,7 @@
>
>
>
> gUefiPayloadPkgTokenSpaceGuid.PcdDispatchModuleAbove4GMemory|$(ABOVE_4G_MEMORY)
>
>
> gUefiPayloadPkgTokenSpaceGuid.PcdBootManagerEscape|$(BOOT_MANAGER_ESCAPE)
>
> +
> gEfiMdeModulePkgTokenSpaceGuid.PcdFollowMicrosoftRecommended|$(MICROSOFT_RECOMMENDED)
>
>
>
> gEfiMdePkgTokenSpaceGuid.PcdMaximumUnicodeStringLength|1800000
>
>
>
> --
> 2.34.1
>
>
[-- Attachment #2: Type: text/html, Size: 2904 bytes --]
prev parent reply other threads:[~2022-08-09 8:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-05 7:52 [PATCH 1/3] MdeModulePkg/BootLogoLib: Add option to follow Microsoft Recommendations Sean Rhodes
2022-08-05 7:52 ` [PATCH 2/3] MdeModulePkg/Logo: Add a PCD to control the position of the Logo Sean Rhodes
2022-08-05 7:52 ` [PATCH 3/3] UefiPayloadPkg: Hook up MICROSOFT_RECOMMENDED macro Sean Rhodes
2022-08-09 5:29 ` Guo Dong
2022-08-09 7:59 ` Sean Rhodes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CABtds-13YPBpT2eNANC27P4nZ-j19x+d=eSm29_8Q89i46aiVg@mail.gmail.com' \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox