From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f172.google.com (mail-yw1-f172.google.com [209.85.128.172]) by mx.groups.io with SMTP id smtpd.web09.9176.1660032005085527195 for ; Tue, 09 Aug 2022 01:00:05 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@starlabs-systems.20210112.gappssmtp.com header.s=20210112 header.b=EhYrUedh; spf=pass (domain: starlabs.systems, ip: 209.85.128.172, mailfrom: sean@starlabs.systems) Received: by mail-yw1-f172.google.com with SMTP id 00721157ae682-328a1cff250so103891697b3.6 for ; Tue, 09 Aug 2022 01:00:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=starlabs-systems.20210112.gappssmtp.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=PB1O+mz6vPio7dwW2OQTzC7yJE7OXQDs3ipPy9UYgNw=; b=EhYrUedhoqPICn8tOxIEydu5SQxHPJCBRRMO7iXi+o0HbD+qP0Cpl13ZtrOW2ufUbn bayDGGXT/iG2GKQVni5k6IteNylD9HfSJJAmwRxtNYVKRgQ09rZ8Hd8pLfWmB+QYflHd R6tWGHP2hqBcjv69BWNujKt4AE+T6Id8yd8OuNVC0jpnfMjfTRfcxw0wuk2eunpOWWM1 FV3J7vjyQg3SoYYaLjh5wZWycKtSgb246y87CvIz5Q/x2l0v5FNM5Mb0v3f82pPIRhfc 3wK7kYFxbDHw2kErZYFEFJpQzj/f9sfZKTLl4RQgtE4nv6ADgx+lMAVv3AJYXAKD6owK IALA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=PB1O+mz6vPio7dwW2OQTzC7yJE7OXQDs3ipPy9UYgNw=; b=5tZy94gew7ASk8YxHquavffhGHZIdE09nuxZXSJz4mSGQD4nINrXZVY+cuOYVQLg4i viAYwg4dX1RPZLPLtAifbIzVvdSmZg8E8EN55yddAb9gtXNzC8PQN5QXYmpwF3V8sXtc ziNQn0rjDtoJhd1E98ANLVUfjNDH8760kh8H8IrMxe2DAIn2j+ySZxV/WVNJrQVKSMto pvLyxWT4RgKrWuhae5dF5Aq+FMm5dSrT54kZYslu6Vj/UNIhL08FKYCE82J4PtdtFdu4 o3bGXLj7rrbVizfmbbxT+pxiLjX0GE5rFbGo4bPOIKPFG1PSKaESnTNgmugCyu1YZdPX Wvxw== X-Gm-Message-State: ACgBeo1e0tU7W883VHJ7Ic4RCDFufnFOKuzAc4VmJZdojbtyHBJ2/nw+ Qe1FegQeJEnY1moY05Q3N8dObebgvXniST5tbBVW X-Google-Smtp-Source: AA6agR4ZzrejRnFDkxkFPY3Bz3DB+c5pWRlRrvR4QQf2reNbVCNTEjvMwKt6xa7BhELftcv7trAo9XFb/8Z3eFag+cg= X-Received: by 2002:a81:688:0:b0:324:e4fe:8f75 with SMTP id 130-20020a810688000000b00324e4fe8f75mr21943823ywg.461.1660032003291; Tue, 09 Aug 2022 01:00:03 -0700 (PDT) MIME-Version: 1.0 References: <83963289b879f8f69e8a385038cb88dd73a8c250.1659685959.git.sean@starlabs.systems> <49c713d5fd5ff71b8f8fea7e14a15fd482300f8b.1659685959.git.sean@starlabs.systems> In-Reply-To: From: "Sean Rhodes" Date: Tue, 9 Aug 2022 08:59:52 +0100 Message-ID: Subject: Re: [PATCH 3/3] UefiPayloadPkg: Hook up MICROSOFT_RECOMMENDED macro To: "Dong, Guo" Cc: devel@edk2.groups.io, "Ni, Ray" Content-Type: multipart/alternative; boundary="000000000000df514805e5ca515c" --000000000000df514805e5ca515c Content-Type: text/plain; charset="UTF-8" Hi Guo Yes, that's fine with me. This single patch can be disregarded then. Thank you Sean On Tue, 9 Aug 2022, 06:29 Dong, Guo, wrote: > > Hi Sean, > How about directly setting the PCD in the build command line instead of > adding a MACRO? > Prefer not adding new MACRO if we could avoid it. > > Thanks, > Guo > -----Original Message----- > From: Sean Rhodes > Sent: Friday, August 5, 2022 12:53 AM > To: devel@edk2.groups.io > Cc: Rhodes, Sean ; Dong, Guo ; > Ni, Ray > Subject: [PATCH 3/3] UefiPayloadPkg: Hook up MICROSOFT_RECOMMENDED macro > > Hook up MICROSOFT_RECOMMENDED macro to PcdFollowMicrosoftRecommended. > > Cc: Guo Dong > Cc: Ray Ni > Signed-off-by: Sean Rhodes > --- > UefiPayloadPkg/UefiPayloadPkg.dsc | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/UefiPayloadPkg/UefiPayloadPkg.dsc > b/UefiPayloadPkg/UefiPayloadPkg.dsc > index 91cd78dbf1..b3ed0f6a2e 100644 > --- a/UefiPayloadPkg/UefiPayloadPkg.dsc > +++ b/UefiPayloadPkg/UefiPayloadPkg.dsc > @@ -43,6 +43,7 @@ > DEFINE SD_MMC_TIMEOUT = 1000000 > > DEFINE USE_CBMEM_FOR_CONSOLE = FALSE > > DEFINE BOOTSPLASH_IMAGE = FALSE > > + DEFINE MICROSOFT_RECOMMENDED = FALSE > > > > # > > # NULL: NullMemoryTestDxe > > @@ -440,6 +441,7 @@ > > > > gUefiPayloadPkgTokenSpaceGuid.PcdDispatchModuleAbove4GMemory|$(ABOVE_4G_MEMORY) > > > gUefiPayloadPkgTokenSpaceGuid.PcdBootManagerEscape|$(BOOT_MANAGER_ESCAPE) > > + > gEfiMdeModulePkgTokenSpaceGuid.PcdFollowMicrosoftRecommended|$(MICROSOFT_RECOMMENDED) > > > > gEfiMdePkgTokenSpaceGuid.PcdMaximumUnicodeStringLength|1800000 > > > > -- > 2.34.1 > > --000000000000df514805e5ca515c Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Guo

Yes, = that's fine with me.

This single patch can be disregarded then.

Thank you

Sean

On Tue, 9 Aug 2022, 06:29 Dong, Guo, <guo.dong@intel.com> wrote:

Hi Sean,
How about directly setting the PCD in the build command line instead of add= ing a MACRO?
Prefer not adding new MACRO if we could avoid it.

Thanks,
Guo
-----Original Message-----
From: Sean Rhodes <sean@starlabs.systems>
Sent: Friday, August 5, 2022 12:53 AM
To: devel@edk2.groups.io
Cc: Rhodes, Sean <sean@starlabs.systems>; Dong, Guo <guo.dong@inte= l.com>; Ni, Ray <ray.ni@intel.com>
Subject: [PATCH 3/3] UefiPayloadPkg: Hook up MICROSOFT_RECOMMENDED macro
Hook up MICROSOFT_RECOMMENDED macro to PcdFollowMicrosoftRecommended.

Cc: Guo Dong <guo.dong@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Signed-off-by: Sean Rhodes <sean@starlabs.systems>
---
=C2=A0UefiPayloadPkg/UefiPayloadPkg.dsc | 2 ++
=C2=A01 file changed, 2 insertions(+)

diff --git a/UefiPayloadPkg/UefiPayloadPkg.dsc b/UefiPayloadPkg/UefiPayload= Pkg.dsc
index 91cd78dbf1..b3ed0f6a2e 100644
--- a/UefiPayloadPkg/UefiPayloadPkg.dsc
+++ b/UefiPayloadPkg/UefiPayloadPkg.dsc
@@ -43,6 +43,7 @@
=C2=A0 =C2=A0DEFINE SD_MMC_TIMEOUT=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0=3D 1000000

=C2=A0 =C2=A0DEFINE USE_CBMEM_FOR_CONSOLE=C2=A0 =C2=A0 =C2=A0 =C2=A0 =3D FA= LSE

=C2=A0 =C2=A0DEFINE BOOTSPLASH_IMAGE=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0=3D FALSE

+=C2=A0 DEFINE MICROSOFT_RECOMMENDED=C2=A0 =C2=A0 =C2=A0 =C2=A0 =3D FALSE


=C2=A0 =C2=A0#

=C2=A0 =C2=A0# NULL:=C2=A0 =C2=A0 NullMemoryTestDxe

@@ -440,6 +441,7 @@


=C2=A0 =C2=A0gUefiPayloadPkgTokenSpaceGuid.PcdDispatchModuleAbove4GMemory|$= (ABOVE_4G_MEMORY)

=C2=A0 =C2=A0gUefiPayloadPkgTokenSpaceGuid.PcdBootManagerEscape|$(BOOT_MANA= GER_ESCAPE)

+=C2=A0 gEfiMdeModulePkgTokenSpaceGuid.PcdFollowMicrosoftRecommended|$(MICR= OSOFT_RECOMMENDED)



=C2=A0 =C2=A0gEfiMdePkgTokenSpaceGuid.PcdMaximumUnicodeStringLength|1800000=



--
2.34.1

--000000000000df514805e5ca515c--