From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yb1-f172.google.com (mail-yb1-f172.google.com [209.85.219.172]) by mx.groups.io with SMTP id smtpd.web11.41802.1671699463780231008 for ; Thu, 22 Dec 2022 00:57:44 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@starlabs-systems.20210112.gappssmtp.com header.s=20210112 header.b=SkK3vVzz; spf=pass (domain: starlabs.systems, ip: 209.85.219.172, mailfrom: sean@starlabs.systems) Received: by mail-yb1-f172.google.com with SMTP id b16so1269373yba.0 for ; Thu, 22 Dec 2022 00:57:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=starlabs-systems.20210112.gappssmtp.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=XbWfdttEGuEsHr4LDy1UAngqbbNZvPm8Ihz4gwgkWLY=; b=SkK3vVzzW3qYTuzivsyrejFGxjx8KCNYypeyDdfh/UdmDHO+LY8vX+1k3hKjpdUKyO 2KLUl1WJdIhYxfo6wA52wEfmGxIhLT+ak19U1GSp9kptfDY11cBci+qfP8km0qOi0hu0 n4huiRXJoTTMYfy2e1OdOg2b6XoVzcnIcei2rxlCxzNPsTivgQFQQvaDCAds4+mK2KlA +gkAmSD/vaxeuXOC58Kq/YWyVr8QULl+z6Rn62cMJENsp445uZM0wQQPdWiOkBL1cGR/ qV1dF+S7P91qFwJSn7jU/CKiIB10j3ngnqV+HM885UnrL/wKdENOqXWGYcpcmp01HoTI R3mw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=XbWfdttEGuEsHr4LDy1UAngqbbNZvPm8Ihz4gwgkWLY=; b=c8wy4K1UTFSP/JjKlk375sFEjuOIgrgRoLaXrRjBw//hddwFexjsYI+mBswelMR0Sm h6+SxMduH75Hc10eh2OpFSHBab4ddDUUcRLB67wZ1f+1dpOgYiYjCGSVKF/N/grNeLRB t1roIC1q+9w3mw9ZSfhLGei8lxzL9fD3pzwI1eYlOShQgp7FVVUjV0UHNQ5C9X5Bvqor pfnGJDLQBdH00YIUSbqkbG+/tyattSwvXQk0yg+hrUYL5jLNRxAUV+cbwBF7EPo+wgOg Wg8W3qGpzcHpeSMxvnfsBAwx4D/ASm2FXao3cae5cJZt/UVvZgqSUj3Zv3ygYBWDwIP5 MWow== X-Gm-Message-State: AFqh2kpWNaH5YLC670h5TCj1AhAslQ/gvfFvOE+S8gNCwU18jSrHMssX Fx5CwRtQMhEJjopcg1bhla9Jqop6UA5SrbhTJij9iH1OTfVl1AM= X-Google-Smtp-Source: AMrXdXu+KlT8JN8zBs/ezMUvl5tTsvomjLXwCJcl2uO5FrJPEqeWkwkGmD85xyfsPUTtOZbuS2wPeiBLAVviNwozUy0= X-Received: by 2002:a25:9ac9:0:b0:74d:d1c0:e2a7 with SMTP id t9-20020a259ac9000000b0074dd1c0e2a7mr510908ybo.184.1671699462144; Thu, 22 Dec 2022 00:57:42 -0800 (PST) MIME-Version: 1.0 References: <20221221212433.1028-1-guo.dong@intel.com> In-Reply-To: From: "Sean Rhodes" Date: Thu, 22 Dec 2022 08:57:31 +0000 Message-ID: Subject: Re: [edk2-devel][PATCH] UefiPayloadPkg: Fix boot issue for non-universal payload To: devel@edk2.groups.io, james.lu@intel.com Cc: "Dong, Guo" , "Ni, Ray" , "Guo, Gua" Content-Type: multipart/alternative; boundary="0000000000009cd88005f066dca6" --0000000000009cd88005f066dca6 Content-Type: text/plain; charset="UTF-8" Okay, a bit more testing - it seems all debug builds hang at that point. I tested back to edk2-stable202111 so I think that's a coreboot problem. Your patch does resolve release builds not booting. > Could you help to use latest Edk2 repo UPL to reproduce the issue that @Sean Rhodes encounter from Coreboot + ShimLayer + UPL ? I'm only testing non-universal payload - the shimlayer doesn't work as no-one could figure out how to make `ElfCt->FileSize` the right size. On Thu, 22 Dec 2022 at 02:49, Lu, James wrote: > Reviewed-by: James Lu > > -----Original Message----- > From: Dong, Guo > Sent: Thursday, December 22, 2022 5:25 AM > To: devel@edk2.groups.io > Cc: Dong, Guo ; Ni, Ray ; Rhodes, > Sean ; Lu, James ; Guo, Gua < > gua.guo@intel.com> > Subject: [edk2-devel][PATCH] UefiPayloadPkg: Fix boot issue for > non-universal payload > > From: Guo Dong > > BDS module was moved from DXEFV to newly created BDSFV recently. > Non-universal UEFI payload doesn't support multiple FV, so it failed to > boot since BDS module could not be found. > This patch add BDS back to DXEFV when UNIVERSAL_PAYLOAD is not set. > > Cc: Ray Ni > Cc: Sean Rhodes > Cc: James Lu > Cc: Gua Guo > Signed-off-by: Guo Dong > --- > UefiPayloadPkg/UefiPayloadPkg.fdf | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/UefiPayloadPkg/UefiPayloadPkg.fdf > b/UefiPayloadPkg/UefiPayloadPkg.fdf > index 94ba922244..ee7d718b3f 100644 > --- a/UefiPayloadPkg/UefiPayloadPkg.fdf > +++ b/UefiPayloadPkg/UefiPayloadPkg.fdf > @@ -59,9 +59,6 @@ INF UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.inf > FILE FV_IMAGE = 4E35FD93-9C72-4c15-8C4B-E77F1DB2D793 { SECTION > FV_IMAGE = DXEFV }-FILE FV_IMAGE = FBE6C1E3-2F80-4770-88B0-494186E3346F {- > SECTION FV_IMAGE = BDSFV-} > ################################################################################ > [FV.BDSFV]@@ -277,6 +274,10 @@ INF > MdeModulePkg/Universal/Acpi/AcpiPlatformDxe/AcpiPlatformDxe.inf > INF > MdeModulePkg/Universal/Acpi/BootGraphicsResourceTableDxe/BootGraphicsResourceTableDxe.inf > !endif +!if $(UNIVERSAL_PAYLOAD) == FALSE+INF > MdeModulePkg/Universal/BdsDxe/BdsDxe.inf+!endif+ # # UEFI network modules > #-- > 2.35.1.windows.2 > > > > > > > --0000000000009cd88005f066dca6 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Okay, a bit more testing - it seems all debug builds hang = at that point. I tested back to=C2=A0edk2-stable202111 so I think that'= s a coreboot problem.

Your patch does resolve release builds= not booting.

>=C2=A0Could you help to use latest Edk2 repo UPL to reproduce = the issue that=C2=A0@Sean Rhodes=C2=A0encounter from Coreboot + ShimLayer + UPL = ?


I'm only testing non-universal payload - the shimlay= er doesn't work as no-one could figure out how to make `ElfCt->FileS= ize` the right size.

On Thu, 22 Dec 2022 at 02:49, Lu, James <james.lu@intel.com> wrote:
Reviewed-by: James Lu &l= t;james.lu@intel.co= m>

-----Original Message-----
From: Dong, Guo <guo.dong@intel.com>
Sent: Thursday, December 22, 2022 5:25 AM
To: devel@edk2.gr= oups.io
Cc: Dong, Guo <g= uo.dong@intel.com>; Ni, Ray <ray.ni@intel.com>; Rhodes, Sean <sean@starlabs.= systems>; Lu, James <james.lu@intel.com>; Guo, Gua <gua.guo@intel.com>
Subject: [edk2-devel][PATCH] UefiPayloadPkg: Fix boot issue for non-univers= al payload

From: Guo Dong <= guo.dong@intel.com>

BDS module was moved from DXEFV to newly created BDSFV recently.
Non-universal UEFI payload doesn't support multiple FV, so it failed to= boot since BDS module could not be found.
This patch add BDS back to DXEFV when UNIVERSAL_PAYLOAD is not set.

Cc: Ray Ni <ray.ni= @intel.com>
Cc: Sean Rhodes <sean@starlabs.systems>
Cc: James Lu <ja= mes.lu@intel.com>
Cc: Gua Guo <gua.= guo@intel.com>
Signed-off-by: Guo Dong <guo.dong@intel.com>
---
=C2=A0UefiPayloadPkg/UefiPayloadPkg.fdf | 7 ++++---
=C2=A01 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/UefiPayloadPkg/UefiPayloadPkg.fdf b/UefiPayloadPkg/UefiPayload= Pkg.fdf
index 94ba922244..ee7d718b3f 100644
--- a/UefiPayloadPkg/UefiPayloadPkg.fdf
+++ b/UefiPayloadPkg/UefiPayloadPkg.fdf
@@ -59,9 +59,6 @@ INF UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.inf<= br> =C2=A0FILE FV_IMAGE =3D 4E35FD93-9C72-4c15-8C4B-E77F1DB2D793 {=C2=A0 =C2=A0= =C2=A0SECTION FV_IMAGE =3D DXEFV }-FILE FV_IMAGE =3D FBE6C1E3-2F80-4770-88= B0-494186E3346F {-=C2=A0 =C2=A0 SECTION FV_IMAGE =3D BDSFV-}=C2=A0 ########= ######################################################################## [F= V.BDSFV]@@ -277,6 +274,10 @@ INF=C2=A0 MdeModulePkg/Universal/Acpi/AcpiPlat= formDxe/AcpiPlatformDxe.inf
=C2=A0INF=C2=A0 MdeModulePkg/Universal/Acpi/BootGraphicsResourceTableDxe/Bo= otGraphicsResourceTableDxe.inf !endif +!if $(UNIVERSAL_PAYLOAD) =3D=3D FALS= E+INF MdeModulePkg/Universal/BdsDxe/BdsDxe.inf+!endif+ # # UEFI network mod= ules #--
2.35.1.windows.2






--0000000000009cd88005f066dca6--