From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f169.google.com (mail-yw1-f169.google.com [209.85.128.169]) by mx.groups.io with SMTP id smtpd.web08.26088.1652687652914097158 for ; Mon, 16 May 2022 00:54:14 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@starlabs-systems.20210112.gappssmtp.com header.s=20210112 header.b=cfbxL+YY; spf=pass (domain: starlabs.systems, ip: 209.85.128.169, mailfrom: sean@starlabs.systems) Received: by mail-yw1-f169.google.com with SMTP id 00721157ae682-2fedd26615cso30887787b3.7 for ; Mon, 16 May 2022 00:54:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=starlabs-systems.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=3+pcRuLGwDbfXAs43j8x08YOYgvsq4c+fIMlL6WdcGY=; b=cfbxL+YYZtfzUJM/ydKXAArDiyChlmE5UF3eN3f+mGrKtoQ/8LqWtO5xiQsC011hjJ OX5vvIicSW2oRn/E0KyEEgIB4m8SUVRRbxBPuZNQywOTkoUzgLkzd/szshQSq3is3ZR5 LoEgTYwJCCqkqAGPFEyFBHtSzFonSP+tRN1QUcqD2saM9CWYQ6jnNDQuOCZH8+fQ7Cf8 5CkklHQR27DGOMcMqLs1RxjSG/02r5nBGdobcJLGIU6PDxkl7Cdw6EOzwcXb69JN+uTH mpFsaHSwr4AGrbDiaUw6Uht3kmQpLKeCrzcjALh8jT0PFRXou9tHIB3Rfd1vzy05rFJd XWeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3+pcRuLGwDbfXAs43j8x08YOYgvsq4c+fIMlL6WdcGY=; b=DILctipqvKag1MA7nPQs+lsvwHAjFEgL6YaRbHDAFevDcsVUrPjgHN4P1xKmVWYXsu ZS2P0A6F7FjSpsz7RsfRv5/tCORroTTT4ATWc2sVN3uYLLPXGNdmRIstvwYu97hHSTgq mytxQJLTUj37mBhiPRt0Dm52Y0DQbpj8IiSdyxjmVmneMHnRlFbECq4cJN2tsaYtXRRd P6oz45ORpkE9QFknB1zP8JxUM7n225XZ8pn3SaCLMvc8V9VrqrJXSs3mdX0Inbd61hC9 43eeYr3DSWe5eULXhDa6tUnxK2k71Xxxf3SM0peDi3+A2i2WKjaGycFr3vbcyJNOxDJK clzg== X-Gm-Message-State: AOAM530sj9bWNYXbAJH+HPAcXFxKQTZTR+ey/lyk1jmLXH1tBllbaeUN R6pXQ7BjAYiWyDHx4KWY8lrW55G8iTBU88wy34Ew X-Google-Smtp-Source: ABdhPJwJUpu8PdW7XY2JhsCCu/Kg/7y8gRc1s0rFE5fOXI8D1gGjf96ZORy4M1dmqQdp5laO+5wun5PbDxiDCiIpPLY= X-Received: by 2002:a0d:d0c1:0:b0:2dc:5950:c72f with SMTP id s184-20020a0dd0c1000000b002dc5950c72fmr17462183ywd.185.1652687650956; Mon, 16 May 2022 00:54:10 -0700 (PDT) MIME-Version: 1.0 References: <2106.1652684379544394027@groups.io> In-Reply-To: From: "Sean Rhodes" Date: Mon, 16 May 2022 08:53:59 +0100 Message-ID: Subject: Re: [edk2-devel] [PATCH] MdeModulePkg/FaultTolerantWriteDxe: Don't check for address alignment To: "Wu, Hao A" Cc: "devel@edk2.groups.io" Content-Type: multipart/alternative; boundary="0000000000005c3b7e05df1c54b2" --0000000000005c3b7e05df1c54b2 Content-Type: text/plain; charset="UTF-8" The bug discovered was with coreboot, and the PCD values are derived from the block size of its SMMStore (NvStorage) region. The discussion on the patch can be found here: https://review.coreboot.org/c/coreboot/+/62990 Hacking the PCDs could work,, but why would we want to keep an incorrect check? Thanks! On Mon, 16 May 2022 at 08:36, Wu, Hao A wrote: > Sorry for not being clear on what I mean. > > Is it possible to change the platform PCD values and keep these block size > alignment requirements. > > > > Best Regards, > > Hao Wu > > > > *From:* devel@edk2.groups.io * On Behalf Of *Sean > Rhodes > *Sent:* Monday, May 16, 2022 3:00 PM > *To:* Wu; Wu, Hao A ; devel@edk2.groups.io > *Subject:* Re: [edk2-devel] [PATCH] MdeModulePkg/FaultTolerantWriteDxe: > Don't check for address alignment > > > > Hi Hao > > Yes, it does conflict - I will update the patch to fix these comments :) > > Thank you > > > --0000000000005c3b7e05df1c54b2 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
The bug discovered was with coreboot, and the PCD values a= re derived from the block size of its SMMStore (NvStorage) region. The disc= ussion on the patch can be found here: https://review.coreboot.org/c/coreboot/+/62990
=

Hacking the PCDs could work,, but why would we w= ant to keep an incorrect check?

Than= ks!


On Mon, 16 May 2022 at 08:36, Wu, Hao A <hao.a.wu@intel.com> wrote:

Sorry for not being clear on what I mean.<= /u>

Is it possible to change the platform PCD values and= keep these block size alignment requirements.

=C2=A0

Best Regards,

Hao Wu

=C2=A0

From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Sean Rhodes
Sent: Monday, May 16, 2022 3:00 PM
To: Wu; Wu, Hao A <hao.a.wu@intel.com>; devel@edk2.groups.io
Subject: Re: [edk2-devel] [PATCH] MdeModulePkg/FaultTolerantWriteDxe= : Don't check for address alignment

=C2=A0

Hi Hao

Yes, it does conflict - I will update the patch to fix these comments :)
Thank you

--0000000000005c3b7e05df1c54b2--