From: "Sean Rhodes" <sean@starlabs.systems>
To: Patrick Rudolph <patrick.rudolph@9elements.com>
Cc: devel@edk2.groups.io, guo.dong@intel.com, ray.ni@intel.com,
james.lu@intel.com, gua.guo@intel.com
Subject: Re: [PATCH 3/3] ShellPkg/TftpDynamicCommand.inf: Add missing DEPEX
Date: Mon, 6 Mar 2023 08:39:09 +0000 [thread overview]
Message-ID: <CABtds-3-kWz8FCO8eG+EZ8=frD_Ck7zqqcVvQG8s2puZ71ycLg@mail.gmail.com> (raw)
In-Reply-To: <20230306083757.26274-3-patrick.rudolph@9elements.com>
[-- Attachment #1: Type: text/plain, Size: 976 bytes --]
Reviewed-by: Sean Rhodes <sean@starlabs.systems>
On Mon, 6 Mar 2023 at 08:38, Patrick Rudolph <patrick.rudolph@9elements.com>
wrote:
> Add protocol gEfiHiiPackageListProtocolGuid to DEPEX
> to make sure it's present before using it.
>
> Fixes ASSERTION seen on DEBUG build.
>
> Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com>
> ---
> ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand.inf | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git
> a/ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand.inf
> b/ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand.inf
> index b0c8e8f84b..d0d849a1eb 100644
> --- a/ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand.inf
> +++ b/ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand.inf
> @@ -57,4 +57,4 @@
> gEfiShellDynamicCommandProtocolGuid ## PRODUCES
>
> [DEPEX]
> - TRUE
> + gEfiHiiPackageListProtocolGuid
> --
> 2.39.1
>
>
[-- Attachment #2: Type: text/html, Size: 1511 bytes --]
next prev parent reply other threads:[~2023-03-06 8:39 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-06 8:37 [PATCH 1/3] BaseTools/Conf/tools_def: Fix linking using CLANGDWARF_IA32_X64 Patrick Rudolph
2023-03-06 8:37 ` [PATCH 2/3] BaseTools/Conf/tools_def: Fix CLANGDWARF_IA32_X64 Patrick Rudolph
2023-03-06 8:39 ` Sean Rhodes
2023-03-15 16:52 ` [edk2-devel] " Sheng Lean Tan
2023-03-06 8:37 ` [PATCH 3/3] ShellPkg/TftpDynamicCommand.inf: Add missing DEPEX Patrick Rudolph
2023-03-06 8:39 ` Sean Rhodes [this message]
2023-03-15 16:54 ` [edk2-devel] " Sheng Lean Tan
2023-03-16 2:08 ` Gao, Zhichao
2023-03-15 16:45 ` [edk2-devel] [PATCH 1/3] BaseTools/Conf/tools_def: Fix linking using CLANGDWARF_IA32_X64 Sheng Lean Tan
[not found] ` <174CA58C1DBF1462.24874@groups.io>
2023-03-15 16:51 ` Sheng Lean Tan
2023-03-15 22:16 ` Marvin Häuser
2023-03-15 22:50 ` Ard Biesheuvel
2023-03-15 22:56 ` Marvin Häuser
2023-03-16 0:05 ` Ard Biesheuvel
2023-03-17 14:07 ` Patrick Rudolph
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CABtds-3-kWz8FCO8eG+EZ8=frD_Ck7zqqcVvQG8s2puZ71ycLg@mail.gmail.com' \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox