From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail-yb1-f181.google.com (mail-yb1-f181.google.com [209.85.219.181])
 by mx.groups.io with SMTP id smtpd.web11.28859.1678091962362754150
 for <devel@edk2.groups.io>;
 Mon, 06 Mar 2023 00:39:22 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@starlabs-systems.20210112.gappssmtp.com header.s=20210112 header.b=N1VDdhec;
 spf=pass (domain: starlabs.systems, ip: 209.85.219.181, mailfrom: sean@starlabs.systems)
Received: by mail-yb1-f181.google.com with SMTP id x12so7276301ybt.7
        for <devel@edk2.groups.io>; Mon, 06 Mar 2023 00:39:21 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=starlabs-systems.20210112.gappssmtp.com; s=20210112; t=1678091961;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:from:to:cc:subject:date:message-id:reply-to;
        bh=QiFZYrrEpmkwfNModT7BFZmeEtHSmT30p9yKXWSX3Ks=;
        b=N1VDdhecRsy2eF33c8RB6nTiJ3SU9LIUkUUDj1CtE4myJBek28mxIM09BQBAEkUPX3
         vGqSSEg+EfuC/fYzywF8ISwskLDfP4WN1YSz/G7QpIGApbXbloJfrkJa0zoUjdRldpdS
         LfQ3ha5Me7rNvG2Jpj2enttiipE+iNmba98NvR5rsHMbFoIHoiIJHLq7D81Y82DbrBEa
         8qnWdUUFlkjFw4O62Wp+PSfq/Uo9i04kP4ktfia0Xk8Uv6Fpx2gjp2RKnMG11Mk7XtaA
         xf2YgLAiE9bqXZBXPaMBOpoVuB4GSYy3qazH5N92n+QQk4/We3FnX6b6eyq9vUkOOsvi
         CPxA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112; t=1678091961;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id
         :reply-to;
        bh=QiFZYrrEpmkwfNModT7BFZmeEtHSmT30p9yKXWSX3Ks=;
        b=Qq4S4pRiNjY+1PoK/5qH8ATmfleuvLOHlM4LWElenjHG/wVPE1+aNeSgfBZswxqVe1
         U6Vuvy7t+du+jBrt64YsCsvbfvfPVhKmZh5R6p48K1YXQnMLsce3JwHtBN5hv0bJvnXl
         tBhXCstMF9jGnVwO4oDwj0oZLuz9XX+U9OciiOcDDulR2grMEElPdMpUAbmhHpSve2IO
         QUBps9niQKa3aurvmN9TXIEPNWsN9yBWZ7uxgpCRgZwKbV0RjV0E+QrKdQfIStOaHytj
         hBiShc+KcOp468ZADZUn3WtMOGZOPVrT+DSvqjo0VyFMtjX/02tp0KRr4+lCSv5dXjDK
         Jc7Q==
X-Gm-Message-State: AO0yUKUqe5KCffOc6kPeA/4bk7S7sInkiiRQ3koIjkULhu+9KY2gC0kp
	UNTZcgHdujFyyQQLRKj3XUo666DPBoRHZCRc6EdaSZW8WqwTt1L0cg==
X-Google-Smtp-Source: AK7set8kJoTd5wE3llpOSAWYQOT/gYSmGYuG+Rju6qVScc/MFco69UkAGdnmvEthgFXNyLYJY1TBQbqz8jHxioroV4Q=
X-Received: by 2002:a5b:a0c:0:b0:a24:1001:1fd2 with SMTP id
 k12-20020a5b0a0c000000b00a2410011fd2mr5924900ybq.0.1678091960816; Mon, 06 Mar
 2023 00:39:20 -0800 (PST)
MIME-Version: 1.0
References: <20230306083757.26274-1-patrick.rudolph@9elements.com> <20230306083757.26274-3-patrick.rudolph@9elements.com>
In-Reply-To: <20230306083757.26274-3-patrick.rudolph@9elements.com>
From: "Sean Rhodes" <sean@starlabs.systems>
Date: Mon, 6 Mar 2023 08:39:09 +0000
Message-ID: <CABtds-3-kWz8FCO8eG+EZ8=frD_Ck7zqqcVvQG8s2puZ71ycLg@mail.gmail.com>
Subject: Re: [PATCH 3/3] ShellPkg/TftpDynamicCommand.inf: Add missing DEPEX
To: Patrick Rudolph <patrick.rudolph@9elements.com>
Cc: devel@edk2.groups.io, guo.dong@intel.com, ray.ni@intel.com, 
	james.lu@intel.com, gua.guo@intel.com
Content-Type: multipart/alternative; boundary="00000000000039a76605f6373bd0"

--00000000000039a76605f6373bd0
Content-Type: text/plain; charset="UTF-8"

Reviewed-by: Sean Rhodes <sean@starlabs.systems>

On Mon, 6 Mar 2023 at 08:38, Patrick Rudolph <patrick.rudolph@9elements.com>
wrote:

> Add protocol gEfiHiiPackageListProtocolGuid to DEPEX
> to make sure it's present before using it.
>
> Fixes ASSERTION seen on DEBUG build.
>
> Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com>
> ---
>  ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand.inf | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git
> a/ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand.inf
> b/ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand.inf
> index b0c8e8f84b..d0d849a1eb 100644
> --- a/ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand.inf
> +++ b/ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand.inf
> @@ -57,4 +57,4 @@
>    gEfiShellDynamicCommandProtocolGuid            ## PRODUCES
>
>  [DEPEX]
> -  TRUE
> +  gEfiHiiPackageListProtocolGuid
> --
> 2.39.1
>
>

--00000000000039a76605f6373bd0
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div class=3D"gmail_default" style=3D"font-family:trebuche=
t ms,sans-serif">Reviewed-by: Sean Rhodes &lt;sean@starlabs.systems&gt;<br>=
</div></div><br><div class=3D"gmail_quote"><div dir=3D"ltr" class=3D"gmail_=
attr">On Mon, 6 Mar 2023 at 08:38, Patrick Rudolph &lt;<a href=3D"mailto:pa=
trick.rudolph@9elements.com">patrick.rudolph@9elements.com</a>&gt; wrote:<b=
r></div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex=
;border-left:1px solid rgb(204,204,204);padding-left:1ex">Add protocol gEfi=
HiiPackageListProtocolGuid to DEPEX<br>
to make sure it&#39;s present before using it.<br>
<br>
Fixes ASSERTION seen on DEBUG build.<br>
<br>
Signed-off-by: Patrick Rudolph &lt;<a href=3D"mailto:patrick.rudolph@9eleme=
nts.com" target=3D"_blank">patrick.rudolph@9elements.com</a>&gt;<br>
---<br>
=C2=A0ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand.inf | 2=
 +-<br>
=C2=A01 file changed, 1 insertion(+), 1 deletion(-)<br>
<br>
diff --git a/ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand.=
inf b/ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand.inf<br>
index b0c8e8f84b..d0d849a1eb 100644<br>
--- a/ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand.inf<br>
+++ b/ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand.inf<br>
@@ -57,4 +57,4 @@<br>
=C2=A0 =C2=A0gEfiShellDynamicCommandProtocolGuid=C2=A0 =C2=A0 =C2=A0 =C2=A0=
 =C2=A0 =C2=A0 ## PRODUCES<br>
<br>
=C2=A0[DEPEX]<br>
-=C2=A0 TRUE<br>
+=C2=A0 gEfiHiiPackageListProtocolGuid<br>
-- <br>
2.39.1<br>
<br>
</blockquote></div>

--00000000000039a76605f6373bd0--