From: "Sean Rhodes" <sean@starlabs.systems>
To: devel@edk2.groups.io, "Ni, Ray" <ray.ni@intel.com>
Subject: Re: [edk2-devel] [PATCH 1/3] MdeModulePkg/BmBoot: Skip removable media if it is not present
Date: Sat, 28 Jan 2023 19:01:56 +0000 [thread overview]
Message-ID: <CABtds-3UkRWzd7j5QSbaYCN3Gps2K=Vs46_NS15yLg8Tvo3v0w@mail.gmail.com> (raw)
In-Reply-To: <CY4PR11MB1622BFDF6924C020361C17C58CE69@CY4PR11MB1622.namprd11.prod.outlook.com>
[-- Attachment #1: Type: text/plain, Size: 2615 bytes --]
Hi Ray
Would it be possible to merge this?
Thanks
Sean
On Fri, 16 Dec 2022, 09:03 Ni, Ray, <ray.ni@intel.com> wrote:
> Reviewed-by: Ray Ni <ray.ni@intel.com>
>
>
> > -----Original Message-----
> > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Sean
> Rhodes
> > Sent: Friday, December 16, 2022 4:58 PM
> > To: devel@edk2.groups.io
> > Cc: Matt DeVillier <matt.devillier@gmail.com>; Wu, Hao A <
> hao.a.wu@intel.com>; Wang, Jian J <jian.j.wang@intel.com>;
> > Gao, Liming <gaoliming@byosoft.com.cn>; Gao, Zhichao <
> zhichao.gao@intel.com>; Ni, Ray <ray.ni@intel.com>; Rhodes,
> > Sean <sean@starlabs.systems>
> > Subject: [edk2-devel] [PATCH 1/3] MdeModulePkg/BmBoot: Skip removable
> media if it is not present
> >
> > From: Matt DeVillier <matt.devillier@gmail.com>
> >
> > Only enumerate devices that have media present.
> >
> > Cc: Hao A Wu <hao.a.wu@intel.com>
> > Cc: Jian J Wang <jian.j.wang@intel.com>
> > Cc: Liming Gao <gaoliming@byosoft.com.cn>
> > Cc: Zhichao Gao <zhichao.gao@intel.com>
> > Cc: Ray Ni <ray.ni@intel.com>
> > Reviewed-by: Sean Rhodes <sean@starlabs.systems>
> > Signed-off-by: Matt DeVillier <matt.devillier@gmail.com>
> > Change-Id: I78a0b8be3e2f33edce2d43bbdd7670e6174d0ff8
> > ---
> > MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c | 9 +++++++++
> > 1 file changed, 9 insertions(+)
> >
> > diff --git a/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c
> > b/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c
> > index 962892d38f..bde22fa659 100644
> > --- a/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c
> > +++ b/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c
> > @@ -2218,6 +2218,15 @@ BmEnumerateBootOptions (
> > continue;
> >
> > }
> >
> >
> >
> > + //
> >
> > + // Skip removable media if not present
> >
> > + //
> >
> > + if ((BlkIo->Media->RemovableMedia == TRUE) &&
> >
> > + (BlkIo->Media->MediaPresent == FALSE))
> >
> > + {
> >
> > + continue;
> >
> > + }
> >
> > +
> >
> > Description = BmGetBootDescription (Handles[Index]);
> >
> > BootOptions = ReallocatePool (
> >
> > sizeof (EFI_BOOT_MANAGER_LOAD_OPTION) *
> (*BootOptionCount),
> >
> > --
> > 2.37.2
> >
> >
> >
> > -=-=-=-=-=-=
> > Groups.io Links: You receive all messages sent to this group.
> > View/Reply Online (#97498): https://edk2.groups.io/g/devel/message/97498
> > Mute This Topic: https://groups.io/mt/95706437/1712937
> > Group Owner: devel+owner@edk2.groups.io
> > Unsubscribe: https://edk2.groups.io/g/devel/unsub [ray.ni@intel.com]
> > -=-=-=-=-=-=
> >
>
>
>
>
>
>
>
[-- Attachment #2: Type: text/html, Size: 5410 bytes --]
next prev parent reply other threads:[~2023-01-28 19:02 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-16 8:58 [PATCH 1/3] MdeModulePkg/BmBoot: Skip removable media if it is not present Sean Rhodes
2022-12-16 8:58 ` [PATCH 2/3] MdeModulePkg/XhciDxe/Xhci: Don't check for invalid PSIV Sean Rhodes
2022-12-19 6:16 ` Wu, Hao A
2022-12-21 0:48 ` [edk2-devel] " Wu, Hao A
2022-12-16 8:58 ` [PATCH 3/3] MdeModulePkg/Bus/Pci/XhciDxe: Check port is compatible before getting PSIV Sean Rhodes
2022-12-19 7:46 ` [edk2-devel] " Wu, Hao A
2022-12-21 0:49 ` Wu, Hao A
2022-12-16 9:03 ` [edk2-devel] [PATCH 1/3] MdeModulePkg/BmBoot: Skip removable media if it is not present Ni, Ray
2023-01-28 19:01 ` Sean Rhodes [this message]
2023-02-13 10:01 ` Sheng Lean Tan
2023-02-13 11:56 ` Ni, Ray
2023-02-17 12:56 ` Sheng Lean Tan
[not found] ` <17449DF2E9A4F10E.28744@groups.io>
2023-03-06 9:57 ` Sheng Lean Tan
2023-03-07 11:32 ` Sheng Lean Tan
2023-03-08 8:54 ` Sheng Lean Tan
2023-03-08 8:57 ` Ni, Ray
2023-03-09 0:54 ` 回复: " gaoliming
2023-03-10 11:29 ` [edk2-devel] " Sheng Lean Tan
2023-03-15 16:41 ` Sheng Lean Tan
2023-03-17 3:03 ` 回复: " gaoliming
[not found] ` <174A9A2823F47D61.24021@groups.io>
2023-03-10 2:20 ` gaoliming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CABtds-3UkRWzd7j5QSbaYCN3Gps2K=Vs46_NS15yLg8Tvo3v0w@mail.gmail.com' \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox