From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yb1-f170.google.com (mail-yb1-f170.google.com [209.85.219.170]) by mx.groups.io with SMTP id smtpd.web11.1120.1674932528888649191 for ; Sat, 28 Jan 2023 11:02:09 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@starlabs-systems.20210112.gappssmtp.com header.s=20210112 header.b=T7NwAHaZ; spf=pass (domain: starlabs.systems, ip: 209.85.219.170, mailfrom: sean@starlabs.systems) Received: by mail-yb1-f170.google.com with SMTP id b1so9705547ybn.11 for ; Sat, 28 Jan 2023 11:02:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=starlabs-systems.20210112.gappssmtp.com; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=y7hQFvED3ZlVq9nfewbxzxzwf3uXD48D/8KwhhnaEkI=; b=T7NwAHaZwn41DSy7h82URQ3PxzxsElu5U+ga4M1GU4+UFXPaxRPGaoZu62XjCqW+eZ 2v3lGq6SExOrGPR6L2rTRTu/x9kMfp9kwIEh4gKCPH4YbfpAZ3CWw3GY2OHComg8sS6a b0NVnEnDwjs+bv/2zQiqO6IPAxfEiyV//f9JsbCjHicDx7JYZFOSR0Jx6oQ7vsZm8VxW qFYxo0o5xHtf3cBPb0rG/jwLqaG94bth+wGKTUrRq6Z6MbbmYaVW4j7D32g4y5W7AMkW rRsK9fWl3AvmkOclBn1RWCgZBskp1W6rdLFwoqUyg7ogIqJmcC9EDytbHfISScqHh3WZ 6AfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=y7hQFvED3ZlVq9nfewbxzxzwf3uXD48D/8KwhhnaEkI=; b=IeWnE4T1JkVXtin+NO4XIDTY3LbDiEzgfrzRpC3oyKQb3LxJcC4iELU7Jn1gniNmVA OFxpx+9RgZ3x8qKEBKb4qeMNOHc6m0jMwdEwjl92tHU17PEM28PpAsQ4J+/ifAavClNP S47Iv8M7H4pOKlAGnNXh3xuL8l2BLcdPSJEhQV0ZyZytGDv6hVfh3XcNGnf2PRTzHe9L 949zzpz4X1UlQ5nzB2eWHHDhAgln7Pgf8XMWjeQcKA5Ut6uiwnFKP6wzN1T/ak9m4dEx al754ui7UBrOF4uIi2C0y1yfyHZXuAPG7VU9BwRW/8c1a6oTZWMeaSGJCrZ0+IBucudi Cz1A== X-Gm-Message-State: AFqh2krxCZA0dh0UunqXPTdrAbjmwns0yond4z0o5oGUxP2ALKpwVS7T +Lrc+A/tn8US2tellFDAQwt8PfoF+8DrOleGEujCsIhjxA0k X-Google-Smtp-Source: AMrXdXuLvPGLQX+RVH3AJ4XEy0RNV7H+azbbIpOwBp5fKf3S5oAfGIyR6W8doZ0uK7ZOQyKfbOYCKxjvNimDcnWH4cE= X-Received: by 2002:a25:2c9:0:b0:803:bfff:635f with SMTP id 192-20020a2502c9000000b00803bfff635fmr3476036ybc.90.1674932527539; Sat, 28 Jan 2023 11:02:07 -0800 (PST) MIME-Version: 1.0 References: <7bad2974b731b7cd8323582aa89ae4ed9f10702c.1671181085.git.sean@starlabs.systems> In-Reply-To: From: "Sean Rhodes" Date: Sat, 28 Jan 2023 19:01:56 +0000 Message-ID: Subject: Re: [edk2-devel] [PATCH 1/3] MdeModulePkg/BmBoot: Skip removable media if it is not present To: devel@edk2.groups.io, "Ni, Ray" Content-Type: multipart/alternative; boundary="00000000000053bf8d05f3579ec7" --00000000000053bf8d05f3579ec7 Content-Type: text/plain; charset="UTF-8" Hi Ray Would it be possible to merge this? Thanks Sean On Fri, 16 Dec 2022, 09:03 Ni, Ray, wrote: > Reviewed-by: Ray Ni > > > > -----Original Message----- > > From: devel@edk2.groups.io On Behalf Of Sean > Rhodes > > Sent: Friday, December 16, 2022 4:58 PM > > To: devel@edk2.groups.io > > Cc: Matt DeVillier ; Wu, Hao A < > hao.a.wu@intel.com>; Wang, Jian J ; > > Gao, Liming ; Gao, Zhichao < > zhichao.gao@intel.com>; Ni, Ray ; Rhodes, > > Sean > > Subject: [edk2-devel] [PATCH 1/3] MdeModulePkg/BmBoot: Skip removable > media if it is not present > > > > From: Matt DeVillier > > > > Only enumerate devices that have media present. > > > > Cc: Hao A Wu > > Cc: Jian J Wang > > Cc: Liming Gao > > Cc: Zhichao Gao > > Cc: Ray Ni > > Reviewed-by: Sean Rhodes > > Signed-off-by: Matt DeVillier > > Change-Id: I78a0b8be3e2f33edce2d43bbdd7670e6174d0ff8 > > --- > > MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c | 9 +++++++++ > > 1 file changed, 9 insertions(+) > > > > diff --git a/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c > > b/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c > > index 962892d38f..bde22fa659 100644 > > --- a/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c > > +++ b/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c > > @@ -2218,6 +2218,15 @@ BmEnumerateBootOptions ( > > continue; > > > > } > > > > > > > > + // > > > > + // Skip removable media if not present > > > > + // > > > > + if ((BlkIo->Media->RemovableMedia == TRUE) && > > > > + (BlkIo->Media->MediaPresent == FALSE)) > > > > + { > > > > + continue; > > > > + } > > > > + > > > > Description = BmGetBootDescription (Handles[Index]); > > > > BootOptions = ReallocatePool ( > > > > sizeof (EFI_BOOT_MANAGER_LOAD_OPTION) * > (*BootOptionCount), > > > > -- > > 2.37.2 > > > > > > > > -=-=-=-=-=-= > > Groups.io Links: You receive all messages sent to this group. > > View/Reply Online (#97498): https://edk2.groups.io/g/devel/message/97498 > > Mute This Topic: https://groups.io/mt/95706437/1712937 > > Group Owner: devel+owner@edk2.groups.io > > Unsubscribe: https://edk2.groups.io/g/devel/unsub [ray.ni@intel.com] > > -=-=-=-=-=-= > > > > > > > > > --00000000000053bf8d05f3579ec7 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Ray

Would= it be possible to merge this?

Thanks

Sean
=

= On Fri, 16 Dec 2022, 09:03 Ni, Ray, <ray.ni@intel.com> wrote:
Re= viewed-by: Ray Ni <ray.ni@intel.com>


> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On= Behalf Of Sean Rhodes
> Sent: Friday, December 16, 2022 4:58 PM
> To: devel@edk2.groups.io
> Cc: Matt DeVillier <matt.devillier@gmail.com>; Wu, Hao= A <hao.a.wu@intel.com>; Wang, Jian J <jian.j.wang@intel.co= m>;
> Gao, Liming <gaoliming@byosoft.com.cn>; Gao, Zhichao &= lt;zhichao.gao@intel.com>; Ni, Ray <ray.ni@intel.com>; Rh= odes,
> Sean <sean@starlabs.systems>
> Subject: [edk2-devel] [PATCH 1/3] MdeModulePkg/BmBoot: Skip removable = media if it is not present
>
> From: Matt DeVillier <matt.devillier@gmail.com>
>
> Only enumerate devices that have media present.
>
> Cc: Hao A Wu <hao.a.wu@intel.com>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Zhichao Gao <zhichao.gao@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Reviewed-by: Sean Rhodes <sean@starlabs.systems>
> Signed-off-by: Matt DeVillier <matt.devillier@gmail.com&g= t;
> Change-Id: I78a0b8be3e2f33edce2d43bbdd7670e6174d0ff8
> ---
>=C2=A0 MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c | 9 +++++++++ >=C2=A0 1 file changed, 9 insertions(+)
>
> diff --git a/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c
> b/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c
> index 962892d38f..bde22fa659 100644
> --- a/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c
> +++ b/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c
> @@ -2218,6 +2218,15 @@ BmEnumerateBootOptions (
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 continue;
>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 }
>
>
>
> +=C2=A0 =C2=A0 =C2=A0 //
>
> +=C2=A0 =C2=A0 =C2=A0 // Skip removable media if not present
>
> +=C2=A0 =C2=A0 =C2=A0 //
>
> +=C2=A0 =C2=A0 =C2=A0 if ((BlkIo->Media->RemovableMedia =3D=3D T= RUE) &&
>
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (BlkIo->Media->MediaPresent = =3D=3D FALSE))
>
> +=C2=A0 =C2=A0 =C2=A0 {
>
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 continue;
>
> +=C2=A0 =C2=A0 =C2=A0 }
>
> +
>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 Description =3D BmGetBootDescription (Handl= es[Index]);
>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 BootOptions =3D ReallocatePool (
>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 sizeof (EFI_BOOT_MANAGER_LOAD_OPTION) * (*BootOptionCount), >
> --
> 2.37.2
>
>
>
> -=3D-=3D-=3D-=3D-=3D-=3D
> Groups.io Links: You receive all messages sent to this group.
> View/Reply Online (#97498): https://edk2= .groups.io/g/devel/message/97498
> Mute This Topic: https://groups.io/mt/95706437/= 1712937
> Group Owner: devel+owner@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsu= b [ray.ni@intel.com]
> -=3D-=3D-=3D-=3D-=3D-=3D
>






--00000000000053bf8d05f3579ec7--