From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f170.google.com (mail-lj1-f170.google.com [209.85.208.170]) by mx.groups.io with SMTP id smtpd.web10.8705.1671181082354511800 for ; Fri, 16 Dec 2022 00:58:02 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@starlabs-systems.20210112.gappssmtp.com header.s=20210112 header.b=zMi+jY7L; spf=pass (domain: starlabs.systems, ip: 209.85.208.170, mailfrom: sean@starlabs.systems) Received: by mail-lj1-f170.google.com with SMTP id f20so1481014lja.4 for ; Fri, 16 Dec 2022 00:58:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=starlabs-systems.20210112.gappssmtp.com; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=GdvF9jK3xtpCwh5t7ew7QJEtP/72E81CpIvQ9f8x2fQ=; b=zMi+jY7LiVZf9geXQ5267FHTWHRQjAkO++ds9wUMilLWv5RJwVXKMdNplK51X8/1+H RZtAbcBzJeLyPAFk80UHqxXE3LMP5Xmynk91f9DZjsBkJHK9Bfiv8NymvAFzqob/rqio YOCjCZLbqDWUzGrNMB5aNr8EdK4dc+Rcz8ldk9AioFbAJg8FsJdWsffajDKEHLEL0qf3 ZXr9buH3YBqLUrhMFL1v24xq7ebb/HnlWblDquMxo2yRA471jNooDKvCx0FDyspH6Dwc uEuxLuIcEQsnQtbcnbalvMWkjXELJnQfLaalXIy7OdMKPt9634PRGbPXg8jbZLUcoOnI OyXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=GdvF9jK3xtpCwh5t7ew7QJEtP/72E81CpIvQ9f8x2fQ=; b=bcQNIokYAVRLyO1EAoIP5SkDBX6Z+4nZiWArRLiEYMf06FCL5GCJo/VQGuQM1qkmwN hEvY5KlSFvoxwqx3FcJRAzzOCCXI9R19QAbn22+jl00QWTNE0ip5Poqdijw2ulqTGZmN Ss81lRRSZknESyYhGHmyhy9znxEZoghVb0IvuU1VOeUBL4JNsM9l1VxoCzyGt2AN5r0i GXiwML6zP6j7WyzpDHYF8VjJ8ymPlfjsFhboena+UqigzfigRPXOh72mK48FTXC6YBgj 332uDuVafYIxG4REOSEJOIk2ow/qi0nS3j6B3utAm6AxjnZ2k1ib6qZqXwX+jy+VPjEA zZng== X-Gm-Message-State: ANoB5pkecrLI1WHwPxLOSakTXzMsCTHLwKU3Q+2pba9HcNZWLpsqJp3e epn7K73e9loHgC5GmTt+KlZfGTZdpDAQuI1t+WC9Vk75G/DM X-Google-Smtp-Source: AA0mqf628qBG3Mhc7uSSZ71hvJB8mhMBwCANpQafr2QEXcR0FVe2MWTDUsS9HgEJ/33gU5Sx9EwicMTsF33hxa7Etbo= X-Received: by 2002:a2e:9c14:0:b0:277:5665:2404 with SMTP id s20-20020a2e9c14000000b0027756652404mr33926143lji.155.1671181079777; Fri, 16 Dec 2022 00:57:59 -0800 (PST) MIME-Version: 1.0 References: <743801c30caf65019b4b4097c0ad1c03ba053238.1671138700.git.sean@starlabs.systems> In-Reply-To: From: "Sean Rhodes" Date: Fri, 16 Dec 2022 08:57:48 +0000 Message-ID: Subject: Re: [edk2-devel] [PATCH] MdeModulePkg/Logo: Add a PCD to control the position of the Logo To: devel@edk2.groups.io, michael.d.kinney@intel.com Content-Type: multipart/alternative; boundary="0000000000009dadd205efee2ac0" --0000000000009dadd205efee2ac0 Content-Type: text/plain; charset="UTF-8" Hi Mike Thanks; didn't work but I'll have a play wth it! Sean On Thu, 15 Dec 2022 at 22:55, Michael D Kinney wrote: > Hi Sean, > > > > Yes, that is the correct section. Hard to tell from patch email alone. > > > > There is a git config that can always include the name of the section of > the INF/DEC/DSC/FDF file where a change is made. > > Can make it a bit easier to review. > > > > > https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git-guide-for-edk2-contributors-and-maintainers#contrib-05 > > > > Specifically this one I think: > > > > git config diff.ini.xfuncname '^\[[A-Za-z0-9_., ]+]' > > > > Mike > > > > *From:* Sean Rhodes > *Sent:* Thursday, December 15, 2022 2:17 PM > *To:* Kinney, Michael D > *Cc:* devel@edk2.groups.io; Gao, Zhichao ; Ni, Ray > ; Wang, Jian J ; Gao, Liming < > gaoliming@byosoft.com.cn> > *Subject:* Re: [edk2-devel] [PATCH] MdeModulePkg/Logo: Add a PCD to > control the position of the Logo > > > > Hi Mike > > > > Thank you; changed to PcdGetBool. > > > > It's in `[PcdsFixedAtBuild, PcdsPatchableInModule, PcdsDynamic, > PcdsDynamicEx]` - is that not right? > > > > Thanks > > > > Sean > > > > On Thu, 15 Dec 2022 at 22:09, Kinney, Michael D < > michael.d.kinney@intel.com> wrote: > > Hi Sean, > > A couple comments related to the PCD type below. > > Mike > > > -----Original Message----- > > From: devel@edk2.groups.io On Behalf Of Sean > Rhodes > > Sent: Thursday, December 15, 2022 1:12 PM > > To: devel@edk2.groups.io > > Cc: Rhodes, Sean ; Gao, Zhichao < > zhichao.gao@intel.com>; Ni, Ray ; Wang, Jian J > > ; Gao, Liming > > Subject: [edk2-devel] [PATCH] MdeModulePkg/Logo: Add a PCD to control > the position of the Logo > > > > When set to true, the Logo is positioned according to the BGRT > > specification, 38.2% from the top of the screen. When set to false, > > no behaviour is changed and the logo is positioned centrally. > > > > Cc: Zhichao Gao > > Cc: Ray Ni > > Cc: Jian J Wang > > Cc: Liming Gao > > Signed-off-by: Sean Rhodes > > --- > > MdeModulePkg/Logo/Logo.c | 28 +++++++++++++++++++++++++++- > > MdeModulePkg/Logo/LogoDxe.inf | 4 ++++ > > MdeModulePkg/MdeModulePkg.dec | 6 ++++++ > > MdeModulePkg/MdeModulePkg.uni | 6 ++++++ > > 4 files changed, 43 insertions(+), 1 deletion(-) > > > > diff --git a/MdeModulePkg/Logo/Logo.c b/MdeModulePkg/Logo/Logo.c > > index 8ab874d2da..48862d3207 100644 > > --- a/MdeModulePkg/Logo/Logo.c > > +++ b/MdeModulePkg/Logo/Logo.c > > @@ -13,6 +13,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent > > #include > > > > #include > > > > #include > > > > +#include > > > > > > > > typedef struct { > > > > EFI_IMAGE_ID ImageId; > > > > @@ -51,12 +52,14 @@ GetImage ( > > IN EDKII_PLATFORM_LOGO_PROTOCOL *This, > > > > IN OUT UINT32 *Instance, > > > > OUT EFI_IMAGE_INPUT *Image, > > > > + EFI_GRAPHICS_OUTPUT_PROTOCOL *GraphicsOutput, > > > > OUT EDKII_PLATFORM_LOGO_DISPLAY_ATTRIBUTE *Attribute, > > > > OUT INTN *OffsetX, > > > > OUT INTN *OffsetY > > > > ) > > > > { > > > > - UINT32 Current; > > > > + UINT32 Current; > > > > + EFI_STATUS Status; > > > > > > > > if ((Instance == NULL) || (Image == NULL) || > > > > (Attribute == NULL) || (OffsetX == NULL) || (OffsetY == NULL)) > > > > @@ -69,6 +72,29 @@ GetImage ( > > return EFI_NOT_FOUND; > > > > } > > > > > > > > + if (FixedPcdGetBool (PcdFollowMicrosoftRecommended)) { > > Should be PcdGetBool(). The only time FixedPcdGetxxx() is required is > if the PCD value is being used to initialize a struct where the value > is needed at build time. This allows the PCD type to be flexible and > can be set in platform scope in the DSC file. > > > > > + // > > > > + // Get current video resolution and text mode > > > > + // > > > > + Status = gBS->HandleProtocol ( > > > > + gST->ConsoleOutHandle, > > > > + &gEfiGraphicsOutputProtocolGuid, > > > > + (VOID **)&GraphicsOutput > > > > + ); > > > > + if (!EFI_ERROR (Status)) { > > > > + // > > > > + // Center of LOGO is in the vertical position 38.2% when > PcdBootLogoOnlyEnable is TRUE > > > > + // Y = (VerticalResolution - LogoHeight) / 2 > > > > + // Y' = VerticalResolution * 0.382 - LogoHeight * 0.5 > > > > + // OffsetY + Y = Y' > > > > + // OffsetY = Y' - Y = -0.118 * VerticalResolution > > > > + // > > > > + *Attribute = EdkiiPlatformLogoDisplayAttributeCenter; > > > > + *OffsetX = 0; > > > > + *OffsetY = -118 * > (INTN)GraphicsOutput->Mode->Info->VerticalResolution / 1000; > > > > + } > > > > + } > > > > + > > > > (*Instance)++; > > > > *Attribute = mLogos[Current].Attribute; > > > > *OffsetX = mLogos[Current].OffsetX; > > > > diff --git a/MdeModulePkg/Logo/LogoDxe.inf > b/MdeModulePkg/Logo/LogoDxe.inf > > index 41215d25d8..ce29950089 100644 > > --- a/MdeModulePkg/Logo/LogoDxe.inf > > +++ b/MdeModulePkg/Logo/LogoDxe.inf > > @@ -41,6 +41,7 @@ > > UefiBootServicesTableLib > > > > UefiDriverEntryPoint > > > > DebugLib > > > > + PcdLib > > > > > > > > [Protocols] > > > > gEfiHiiDatabaseProtocolGuid ## CONSUMES > > > > @@ -48,6 +49,9 @@ > > gEfiHiiPackageListProtocolGuid ## PRODUCES CONSUMES > > > > gEdkiiPlatformLogoProtocolGuid ## PRODUCES > > > > > > > > +[Pcd] > > > > + gEfiMdeModulePkgTokenSpaceGuid.PcdFollowMicrosoftRecommended ## > CONSUMES > > > > + > > > > [Depex] > > > > gEfiHiiDatabaseProtocolGuid AND > > > > gEfiHiiImageExProtocolGuid > > > > diff --git a/MdeModulePkg/MdeModulePkg.dec > b/MdeModulePkg/MdeModulePkg.dec > > index be5e829ca9..c8bb51df3b 100644 > > --- a/MdeModulePkg/MdeModulePkg.dec > > +++ b/MdeModulePkg/MdeModulePkg.dec > > @@ -2102,6 +2102,12 @@ > > # @Prompt The shared bit mask when Intel Tdx is enabled. > > > > > gEfiMdeModulePkgTokenSpaceGuid.PcdTdxSharedBitMask|0x0|UINT64|0x10000025 > > > > > > > > + ## This PCD sets the position of the Boot Logo. > > > > + # TRUE - The Logo is positioned following the recommendations from > Microsoft. > > > > + # FALSE - The logo is positioned in the center of the screen. > > > > + # @ Prompt This position of the boot logo > > > > + > gEfiMdeModulePkgTokenSpaceGuid.PcdFollowMicrosoftRecommended|FALSE|BOOLEAN|0x10000026 > > Which PCD section is this in? This PCD should support all PCD types so > it can allow Fixed or Patchable or Dynmaic PCD types. > > > > > + > > > > [PcdsPatchableInModule] > > > > ## Specify memory size with page number for PEI code when > > > > # Loading Module at Fixed Address feature is enabled. > > > > diff --git a/MdeModulePkg/MdeModulePkg.uni > b/MdeModulePkg/MdeModulePkg.uni > > index 33ce9f6198..09c1ac1cc1 100644 > > --- a/MdeModulePkg/MdeModulePkg.uni > > +++ b/MdeModulePkg/MdeModulePkg.uni > > @@ -1338,3 +1338,9 @@ > > #string > STR_gEfiMdeModulePkgTokenSpaceGuid_PcdPcieResizableBarSupport_HELP > #language en-US "Indicates if the PCIe > > Resizable BAR Capability Supported.

\n" > > > > > "TRUE - PCIe Resizable BAR > > Capability is supported.
\n" > > > > > "FALSE - PCIe Resizable BAR > > Capability is not supported.
" > > > > + > > > > +#string > STR_gEfiMdeModulePkgTokenSpaceGuid_PcdFollowMicrosoftRecommended_PROMPT > #language en-US "The position of the Boot > > Logo" > > > > + > > > > +#string > STR_gEfiMdeModulePkgTokenSpaceGuid_PcdFollowMicrosoftRecommend_HELP > #language en-US "Sets the position of the > > Logo. When set to true, the Logo is positioned following the > recommendations" > > > > + > " from Microsoft, 38.2% from > > the top of the screen." > > > > + > > > > -- > > 2.37.2 > > > > > > > > -=-=-=-=-=-= > > Groups.io Links: You receive all messages sent to this group. > > View/Reply Online (#97479): https://edk2.groups.io/g/devel/message/97479 > > Mute This Topic: https://groups.io/mt/95697776/1643496 > > Group Owner: devel+owner@edk2.groups.io > > Unsubscribe: https://edk2.groups.io/g/devel/unsub [ > michael.d.kinney@intel.com] > > -=-=-=-=-=-= > > > > > > --0000000000009dadd205efee2ac0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Mike

Thanks; didn't work but I'= ll have a play wth it!

Sean

On Thu, 15 Dec 2022 at 22:5= 5, Michael D Kinney <micha= el.d.kinney@intel.com> wrote:

Hi Sean,

=C2=A0

Yes, that is the correct section.=C2=A0 Hard to tell from patch email alone.

=C2=A0

There is a git config that can always include = the name of the section of the INF/DEC/DSC/FDF file where a change is made.=

Can make it a bit easier to review.<= /u>

=C2=A0

https://github.com/tianocore/tia= nocore.github.io/wiki/Laszlo's-unkempt-git-guide-for-edk2-contributors-= and-maintainers#contrib-05

=C2=A0

Specifically this one I think:

=C2=A0

git config diff.in= i.xfuncname=C2=A0=C2=A0=C2=A0=C2=A0 '^\[[A-Za-z0-9_., ]+]'

=C2=A0

Mike

=C2=A0

From: Sean Rhodes <sean= @starlabs.systems>
Sent: Thursday, December 15, 2022 2:17 PM
To: Kinney, Michael D <michael.d.kinney@intel.com>
Cc: devel@= edk2.groups.io; Gao, Zhichao <zhichao.gao@intel.com>; Ni, Ray <ray.ni@intel.com>; Wang, = Jian J <jian.= j.wang@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>
Subject: Re: [edk2-devel] [PATCH] MdeModulePkg/Logo: Add a PCD to co= ntrol the position of the Logo

=C2=A0

Hi Mike

=C2=A0

Thank you; changed to PcdGetBool.

=C2=A0

It's in `[PcdsFixedAtBuild, PcdsPatchableInModule, PcdsDynamic, PcdsDynamicEx]` - = is that not right?

=C2=A0

Thanks<= /span>

=C2=A0

Sean=

=C2=A0

On Thu, 15 Dec 2022 at 22:09, Kinney, Michael D <= michael.d.k= inney@intel.com> wrote:

Hi Sean,

A couple comments related to the PCD type below.

Mike

> -----Original Message-----
> From: devel@= edk2.groups.io <devel@edk2.groups.io> On Behalf Of Sean Rhodes
> Sent: Thursday, December 15, 2022 1:12 PM
> To: devel@ed= k2.groups.io
> Cc: Rhodes, Sean <sean@starlabs.systems>; Gao, Zhichao <zhichao.gao@intel.com>; = Ni, Ray <ray.ni@in= tel.com>; Wang, Jian J
> <jian.j.= wang@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>
> Subject: [edk2-devel] [PATCH] MdeModulePkg/Logo: Add a PCD to control = the position of the Logo
>
> When set to true, the Logo is positioned according to the BGRT
> specification, 38.2% from the top of the screen. When set to false, > no behaviour is changed and the logo is positioned centrally.
>
> Cc: Zhichao Gao <zhichao.gao@intel.com>
> Cc: Ray Ni <r= ay.ni@intel.com>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Signed-off-by: Sean Rhodes <sean@starlabs.systems>
> ---
>=C2=A0 MdeModulePkg/Logo/Logo.c=C2=A0 =C2=A0 =C2=A0 | 28 ++++++++++++++= +++++++++++++-
>=C2=A0 MdeModulePkg/Logo/LogoDxe.inf |=C2=A0 4 ++++
>=C2=A0 MdeModulePkg/MdeModulePkg.dec |=C2=A0 6 ++++++
>=C2=A0 MdeModulePkg/MdeModulePkg.uni |=C2=A0 6 ++++++
>=C2=A0 4 files changed, 43 insertions(+), 1 deletion(-)
>
> diff --git a/MdeModulePkg/Logo/Logo.c b/MdeModulePkg/Logo/Logo.c
> index 8ab874d2da..48862d3207 100644
> --- a/MdeModulePkg/Logo/Logo.c
> +++ b/MdeModulePkg/Logo/Logo.c
> @@ -13,6 +13,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
>=C2=A0 #include <Protocol/HiiPackageList.h>
>
>=C2=A0 #include <Library/UefiBootServicesTableLib.h>
>
>=C2=A0 #include <Library/DebugLib.h>
>
> +#include <Library/PcdLib.h>
>
>
>
>=C2=A0 typedef struct {
>
>=C2=A0 =C2=A0 EFI_IMAGE_ID=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0ImageId;
>
> @@ -51,12 +52,14 @@ GetImage (
>=C2=A0 =C2=A0 IN=C2=A0 =C2=A0 =C2=A0EDKII_PLATFORM_LOGO_PROTOCOL=C2=A0 = =C2=A0 =C2=A0 =C2=A0 *This,
>
>=C2=A0 =C2=A0 IN OUT UINT32=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 *Instance, >
>=C2=A0 =C2=A0 OUT EFI_IMAGE_INPUT=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 *Image,
>
> +=C2=A0 EFI_GRAPHICS_OUTPUT_PROTOCOL=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0*GraphicsOutput,
>
>=C2=A0 =C2=A0 OUT EDKII_PLATFORM_LOGO_DISPLAY_ATTRIBUTE=C2=A0 *Attribut= e,
>
>=C2=A0 =C2=A0 OUT INTN=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0*OffsetX,
>
>=C2=A0 =C2=A0 OUT INTN=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0*OffsetY
>
>=C2=A0 =C2=A0 )
>
>=C2=A0 {
>
> -=C2=A0 UINT32=C2=A0 Current;
>
> +=C2=A0 UINT32=C2=A0 =C2=A0 =C2=A0 Current;
>
> +=C2=A0 EFI_STATUS=C2=A0 Status;
>
>
>
>=C2=A0 =C2=A0 if ((Instance =3D=3D NULL) || (Image =3D=3D NULL) ||
>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 (Attribute =3D=3D NULL) || (OffsetX =3D=3D = NULL) || (OffsetY =3D=3D NULL))
>
> @@ -69,6 +72,29 @@ GetImage (
>=C2=A0 =C2=A0 =C2=A0 return EFI_NOT_FOUND;
>
>=C2=A0 =C2=A0 }
>
>
>
> +=C2=A0 if (FixedPcdGetBool (PcdFollowMicrosoftRecommended)) {

Should be PcdGetBool().=C2=A0 The only time FixedPcdGetxxx() is required is=
if the PCD value is being used to initialize a struct where the value
is needed at build time.=C2=A0 This allows the PCD type to be flexible and<= br> can be set in platform scope in the DSC file.

>
> +=C2=A0 =C2=A0 //
>
> +=C2=A0 =C2=A0 // Get current video resolution and text mode
>
> +=C2=A0 =C2=A0 //
>
> +=C2=A0 =C2=A0 Status =3D gBS->HandleProtocol (
>
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= gST->ConsoleOutHandle,
>
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= &gEfiGraphicsOutputProtocolGuid,
>
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= (VOID **)&GraphicsOutput
>
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= );
>
> +=C2=A0 =C2=A0 if (!EFI_ERROR (Status)) {
>
> +=C2=A0 =C2=A0 =C2=A0 //
>
> +=C2=A0 =C2=A0 =C2=A0 // Center of LOGO is in the vertical position 38= .2% when PcdBootLogoOnlyEnable is TRUE
>
> +=C2=A0 =C2=A0 =C2=A0 // Y =3D (VerticalResolution - LogoHeight) / 2 >
> +=C2=A0 =C2=A0 =C2=A0 // Y' =3D VerticalResolution * 0.382 - LogoH= eight * 0.5
>
> +=C2=A0 =C2=A0 =C2=A0 // OffsetY + Y =3D Y'
>
> +=C2=A0 =C2=A0 =C2=A0 // OffsetY =3D Y' - Y =3D -0.118 * VerticalR= esolution
>
> +=C2=A0 =C2=A0 =C2=A0 //
>
> +=C2=A0 =C2=A0 =C2=A0 *Attribute =3D EdkiiPlatformLogoDisplayAttribute= Center;
>
> +=C2=A0 =C2=A0 =C2=A0 *OffsetX=C2=A0 =C2=A0=3D 0;
>
> +=C2=A0 =C2=A0 =C2=A0 *OffsetY=C2=A0 =C2=A0=3D -118 * (INTN)GraphicsOu= tput->Mode->Info->VerticalResolution / 1000;
>
> +=C2=A0 =C2=A0 }
>
> +=C2=A0 }
>
> +
>
>=C2=A0 =C2=A0 (*Instance)++;
>
>=C2=A0 =C2=A0 *Attribute =3D mLogos[Current].Attribute;
>
>=C2=A0 =C2=A0 *OffsetX=C2=A0 =C2=A0=3D mLogos[Current].OffsetX;
>
> diff --git a/MdeModulePkg/Logo/LogoDxe.inf b/MdeModulePkg/Logo/LogoDxe= .inf
> index 41215d25d8..ce29950089 100644
> --- a/MdeModulePkg/Logo/LogoDxe.inf
> +++ b/MdeModulePkg/Logo/LogoDxe.inf
> @@ -41,6 +41,7 @@
>=C2=A0 =C2=A0 UefiBootServicesTableLib
>
>=C2=A0 =C2=A0 UefiDriverEntryPoint
>
>=C2=A0 =C2=A0 DebugLib
>
> +=C2=A0 PcdLib
>
>
>
>=C2=A0 [Protocols]
>
>=C2=A0 =C2=A0 gEfiHiiDatabaseProtocolGuid=C2=A0 =C2=A0 =C2=A0 =C2=A0 ##= CONSUMES
>
> @@ -48,6 +49,9 @@
>=C2=A0 =C2=A0 gEfiHiiPackageListProtocolGuid=C2=A0 =C2=A0 =C2=A0## PROD= UCES CONSUMES
>
>=C2=A0 =C2=A0 gEdkiiPlatformLogoProtocolGuid=C2=A0 =C2=A0 =C2=A0## PROD= UCES
>
>
>
> +[Pcd]
>
> +=C2=A0 gEfiMdeModulePkgTokenSpaceGuid.PcdFollowMicrosoftRecommended #= # CONSUMES
>
> +
>
>=C2=A0 [Depex]
>
>=C2=A0 =C2=A0 gEfiHiiDatabaseProtocolGuid AND
>
>=C2=A0 =C2=A0 gEfiHiiImageExProtocolGuid
>
> diff --git a/MdeModulePkg/MdeModulePkg.dec b/MdeModulePkg/MdeModulePkg= .dec
> index be5e829ca9..c8bb51df3b 100644
> --- a/MdeModulePkg/MdeModulePkg.dec
> +++ b/MdeModulePkg/MdeModulePkg.dec
> @@ -2102,6 +2102,12 @@
>=C2=A0 =C2=A0 # @Prompt The shared bit mask when Intel Tdx is enabled.<= br> >
>=C2=A0 =C2=A0 gEfiMdeModulePkgTokenSpaceGuid.PcdTdxSharedBitMask|0x0|UI= NT64|0x10000025
>
>
>
> +=C2=A0 ## This PCD sets the position of the Boot Logo.
>
> +=C2=A0 #=C2=A0 =C2=A0TRUE=C2=A0 - The Logo is positioned following th= e recommendations from Microsoft.
>
> +=C2=A0 #=C2=A0 =C2=A0FALSE - The logo is positioned in the center of = the screen.
>
> +=C2=A0 # @ Prompt This position of the boot logo
>
> +=C2=A0 gEfiMdeModulePkgTokenSpaceGuid.PcdFollowMicrosoftRecommended|F= ALSE|BOOLEAN|0x10000026

Which PCD section is this in?=C2=A0 This PCD should support all PCD types s= o
it can allow Fixed or Patchable or Dynmaic PCD types.

>
> +
>
>=C2=A0 [PcdsPatchableInModule]
>
>=C2=A0 =C2=A0 ## Specify memory size with page number for PEI code when=
>
>=C2=A0 =C2=A0 #=C2=A0 Loading Module at Fixed Address feature is enable= d.
>
> diff --git a/MdeModulePkg/MdeModulePkg.uni b/MdeModulePkg/MdeModulePkg= .uni
> index 33ce9f6198..09c1ac1cc1 100644
> --- a/MdeModulePkg/MdeModulePkg.uni
> +++ b/MdeModulePkg/MdeModulePkg.uni
> @@ -1338,3 +1338,9 @@
>=C2=A0 #string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdPcieResizableBarSu= pport_HELP #language en-US "Indicates if the PCIe
> Resizable BAR Capability Supported.<BR><BR>\n"
>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 "TRUE=C2=A0 - PCIe Resizable BA= R
> Capability is supported.<BR>\n"
>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 "FALSE - PCIe Resizable BAR
> Capability is not supported.<BR>"
>
> +
>
> +#string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdFollowMicrosoftRecommen= ded_PROMPT #language en-US "The position of the Boot
> Logo"
>
> +
>
> +#string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdFollowMicrosoftRecommen= d_HELP=C2=A0 =C2=A0#language en-US "Sets the position of the
> Logo. When set to true, the Logo is positioned following the recommend= ations"
>
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0" from Microsoft, 38.2% from
> the top of the screen."
>
> +
>
> --
> 2.37.2
>
>
>
> -=3D-=3D-=3D-=3D-=3D-=3D
> Groups.io Links: You receive all messages sent to this group.
> View/Reply Online (#97479): https://edk2.groups.io/g/devel/message/97479
> Mute This Topic: https://groups.io/mt/95697776/1643496
> Group Owner: devel+owner@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub [michael.d.kinney@intel.com]<= br> > -=3D-=3D-=3D-=3D-=3D-=3D
>

=20

--0000000000009dadd205efee2ac0--