From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yb1-f174.google.com (mail-yb1-f174.google.com [209.85.219.174]) by mx.groups.io with SMTP id smtpd.web10.4331.1659682553324096724 for ; Thu, 04 Aug 2022 23:55:53 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@starlabs-systems.20210112.gappssmtp.com header.s=20210112 header.b=k+zRM7mR; spf=pass (domain: starlabs.systems, ip: 209.85.219.174, mailfrom: sean@starlabs.systems) Received: by mail-yb1-f174.google.com with SMTP id 123so2484544ybv.7 for ; Thu, 04 Aug 2022 23:55:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=starlabs-systems.20210112.gappssmtp.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=RZrwGeLKyqKTTPRNPNl/rYVs1ILSB7GX5nq0jqrEdoA=; b=k+zRM7mRJ14JGimP45CecQFn0uSntr8JqABIcta+cdJXW6D9lSyoGpBjiVATGcbi2k HmuyXiU3fsWYN+Xr2dZfLOj2TKn0O1ZMrbcGByJmd1WjVs8xVN7RPkCbMxY57Rop2hfL 4AlDTVKv5CglzWFsr2pGBkidQUwfTn6QVR08WI6F7Esa4t2R80fbvsYwV0+lc1Z40JKo Vqb4ENA+iNkvJ37f2w47HM3mHIG0Nh6tPPU3ojbnb/Zdgcyp3r5amfdX93IGl4yt6TMU BP7J/wT61bkDG91x3BGss+xjqtwfG0CEo9moVYz2cjoW78DRUa5M4Rg20tCGgU5Nna6d 9BIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=RZrwGeLKyqKTTPRNPNl/rYVs1ILSB7GX5nq0jqrEdoA=; b=hCZTniJYvHd7Xs3sB9r7uxm7wMEtPsfI7JidWkuDvmMCW2gKpkvslEIRRIEetU7i5a 7ljoehRzbETcPM+tDAKg+cx4OSpUQp8orIuD9sRPAFMf3NxoxSOC2fLAL271ItK6ot5u YP5LH1G4rk++kVzATtsX0ikmX/vkiHx8sv7s0a7FCIPR/fMM48qOt6x9+wNedEYlAvXS jkLjnrE68wbpC25aOikSa/XThUqHq4KcT7LduloPtDFL4FpSo92cDTKMfmWnfa8tO4OC y2UyRR9kuXvdjPJFi4VHFNub7pZ4BPstBQtZN+uW7ZPOTfsFSgGFyWIijYD+ri2FmG9a p2yw== X-Gm-Message-State: ACgBeo3WLXmUJUOD9CuhHdzmbfZ5kVOQpF9hpQ45M2fGxlwQnnxgBQUJ cflQw0oC9ZXntR//hwcSqYP5Lx6mgF+QeySBaPBWfqQpdM7T X-Google-Smtp-Source: AA6agR5s/IaY8UGtyuHbZTz3gfVT6fNKtHaXKcrvzo7LnlNzDaF6xuFTzJeu7P1G42z6aqzuGC/TTQW+jNVB+e9g4s8= X-Received: by 2002:a25:25d8:0:b0:671:80a8:2d73 with SMTP id l207-20020a2525d8000000b0067180a82d73mr4077679ybl.125.1659682551926; Thu, 04 Aug 2022 23:55:51 -0700 (PDT) MIME-Version: 1.0 References: <030701d8a890$97e31bb0$c7a95310$@byosoft.com.cn> In-Reply-To: <030701d8a890$97e31bb0$c7a95310$@byosoft.com.cn> From: "Sean Rhodes" Date: Fri, 5 Aug 2022 07:55:40 +0100 Message-ID: Subject: Re: [edk2-devel] [PATCH 1/3] MdeModulePkg/BootLogoLib: Add option to follow BGRT specification To: devel@edk2.groups.io, gaoliming@byosoft.com.cn Cc: Zhichao Gao , Ray Ni , Jian J Wang Content-Type: multipart/alternative; boundary="000000000000f2bbb105e578f45f" --000000000000f2bbb105e578f45f Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Liming Microsoft details about positioning can be found here: https://docs.microsoft.com/en-us/windows-hardware/drivers/bringup/boot-scre= en-components Thanks Sean On Fri, 5 Aug 2022 at 07:00, gaoliming via groups.io wrote: > Sean: > Can you give BGRT spec link? I want to check the spec description. > > Thanks > Liming > > -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- > > =E5=8F=91=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io =E4=BB=A3=E8=A1=A8 Sean Rhodes > > =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2022=E5=B9=B47=E6=9C=8826=E6=97= =A5 16:15 > > =E6=94=B6=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io > > =E6=8A=84=E9=80=81: Sean Rhodes ; Zhichao Gao > > ; Ray Ni ; Jian J Wang > > ; Liming Gao > > =E4=B8=BB=E9=A2=98: [edk2-devel] [PATCH 1/3] MdeModulePkg/BootLogoLib: = Add option to > > follow BGRT specification > > > > Add an option to position the logo 38.2% from the top of the screen, > > which follows the BGRT specification. > > > > Cc: Zhichao Gao > > Cc: Ray Ni > > Cc: Jian J Wang > > Cc: Liming Gao > > Signed-off-by: Sean Rhodes > > --- > > MdeModulePkg/Include/Protocol/PlatformLogo.h | 3 ++- > > MdeModulePkg/Library/BootLogoLib/BootLogoLib.c | 7 ++++--- > > 2 files changed, 6 insertions(+), 4 deletions(-) > > > > diff --git a/MdeModulePkg/Include/Protocol/PlatformLogo.h > > b/MdeModulePkg/Include/Protocol/PlatformLogo.h > > index 08e1dc35a4..7c9ef63c66 100644 > > --- a/MdeModulePkg/Include/Protocol/PlatformLogo.h > > +++ b/MdeModulePkg/Include/Protocol/PlatformLogo.h > > @@ -29,7 +29,8 @@ typedef enum { > > EdkiiPlatformLogoDisplayAttributeCenterBottom, > > > > EdkiiPlatformLogoDisplayAttributeLeftBottom, > > > > EdkiiPlatformLogoDisplayAttributeCenterLeft, > > > > - EdkiiPlatformLogoDisplayAttributeCenter > > > > + EdkiiPlatformLogoDisplayAttributeCenter, > > > > + EdkiiPlatformLogoDisplayAttributeBGRTSpecification > > > > } EDKII_PLATFORM_LOGO_DISPLAY_ATTRIBUTE; > > > > > > > > /** > > > > diff --git a/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c > > b/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c > > index 478ec2d40e..ac086f9c79 100644 > > --- a/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c > > +++ b/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c > > @@ -169,7 +169,6 @@ BootLogoEnableLogo ( > > DestX =3D SizeOfX - Image.Width; > > > > DestY =3D 0; > > > > break; > > > > - > > > > case EdkiiPlatformLogoDisplayAttributeCenterLeft: > > > > DestX =3D 0; > > > > DestY =3D (SizeOfY - Image.Height) / 2; > > > > @@ -182,7 +181,6 @@ BootLogoEnableLogo ( > > DestX =3D SizeOfX - Image.Width; > > > > DestY =3D (SizeOfY - Image.Height) / 2; > > > > break; > > > > - > > > > case EdkiiPlatformLogoDisplayAttributeLeftBottom: > > > > DestX =3D 0; > > > > DestY =3D SizeOfY - Image.Height; > > > > @@ -195,7 +193,10 @@ BootLogoEnableLogo ( > > DestX =3D SizeOfX - Image.Width; > > > > DestY =3D SizeOfY - Image.Height; > > > > break; > > > > - > > > > + case EdkiiPlatformLogoDisplayAttributeBGRTSpecification: > > > > + DestX =3D (SizeOfX - Image.Width) / 2; > > > > + DestY =3D (SizeOfY * 382) / 1000 - Image.Height / 2; > > > > + break; > > > > default: > > > > ASSERT (FALSE); > > > > continue; > > > > -- > > 2.34.1 > > > > > > > > -=3D-=3D-=3D-=3D-=3D-=3D > > Groups.io Links: You receive all messages sent to this group. > > View/Reply Online (#91842): https://edk2.groups.io/g/devel/message/9184= 2 > > Mute This Topic: https://groups.io/mt/92623125/4905953 > > Group Owner: devel+owner@edk2.groups.io > > Unsubscribe: https://edk2.groups.io/g/devel/unsub > > [gaoliming@byosoft.com.cn] > > -=3D-=3D-=3D-=3D-=3D-=3D > > > > > > > >=20 > > > --000000000000f2bbb105e578f45f Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Liming

Microsoft details about positioni= ng can be found here:=C2=A0https://docs.microsoft= .com/en-us/windows-hardware/drivers/bringup/boot-screen-components

Thanks

Sean

On Fri, 5 Aug 2022 at 07:00, gao= liming via groups.io <gaoliming=3Dbyosoft.com.cn@groups.io> wro= te:
Sean:
=C2=A0 Can you give BGRT spec link? I want to check the spec description. <= br>
Thanks
Liming
> -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6-----
> =E5=8F=91=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io <devel@edk2.groups.io> =E4=BB=A3=E8=A1= =A8 Sean Rhodes
> =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2022=E5=B9=B47=E6=9C=8826=E6=97= =A5 16:15
> =E6=94=B6=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io
> =E6=8A=84=E9=80=81: Sean Rhodes <sean@starlabs.systems>; Zhichao= Gao
> <zhichao= .gao@intel.com>; Ray Ni <ray.ni@intel.com>; Jian J Wang
> <jian.j.= wang@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>
> =E4=B8=BB=E9=A2=98: [edk2-devel] [PATCH 1/3] MdeModulePkg/BootLogoLib:= Add option to
> follow BGRT specification
>
> Add an option to position the logo 38.2% from the top of the screen, > which follows the BGRT specification.
>
> Cc: Zhichao Gao <zhichao.gao@intel.com>
> Cc: Ray Ni <r= ay.ni@intel.com>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Signed-off-by: Sean Rhodes <sean@starlabs.systems>
> ---
>=C2=A0 MdeModulePkg/Include/Protocol/PlatformLogo.h=C2=A0 =C2=A0| 3 ++-=
>=C2=A0 MdeModulePkg/Library/BootLogoLib/BootLogoLib.c | 7 ++++---
>=C2=A0 2 files changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/MdeModulePkg/Include/Protocol/PlatformLogo.h
> b/MdeModulePkg/Include/Protocol/PlatformLogo.h
> index 08e1dc35a4..7c9ef63c66 100644
> --- a/MdeModulePkg/Include/Protocol/PlatformLogo.h
> +++ b/MdeModulePkg/Include/Protocol/PlatformLogo.h
> @@ -29,7 +29,8 @@ typedef enum {
>=C2=A0 =C2=A0 EdkiiPlatformLogoDisplayAttributeCenterBottom,
>
>=C2=A0 =C2=A0 EdkiiPlatformLogoDisplayAttributeLeftBottom,
>
>=C2=A0 =C2=A0 EdkiiPlatformLogoDisplayAttributeCenterLeft,
>
> -=C2=A0 EdkiiPlatformLogoDisplayAttributeCenter
>
> +=C2=A0 EdkiiPlatformLogoDisplayAttributeCenter,
>
> +=C2=A0 EdkiiPlatformLogoDisplayAttributeBGRTSpecification
>
>=C2=A0 } EDKII_PLATFORM_LOGO_DISPLAY_ATTRIBUTE;
>
>
>
>=C2=A0 /**
>
> diff --git a/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c
> b/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c
> index 478ec2d40e..ac086f9c79 100644
> --- a/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c
> +++ b/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c
> @@ -169,7 +169,6 @@ BootLogoEnableLogo (
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 DestX =3D SizeOfX - Image.Width;
>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 DestY =3D 0;
>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 break;
>
> -
>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 case EdkiiPlatformLogoDisplayAttributeCente= rLeft:
>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 DestX =3D 0;
>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 DestY =3D (SizeOfY - Image.Height) /= 2;
>
> @@ -182,7 +181,6 @@ BootLogoEnableLogo (
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 DestX =3D SizeOfX - Image.Width;
>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 DestY =3D (SizeOfY - Image.Height) /= 2;
>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 break;
>
> -
>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 case EdkiiPlatformLogoDisplayAttributeLeftB= ottom:
>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 DestX =3D 0;
>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 DestY =3D SizeOfY - Image.Height; >
> @@ -195,7 +193,10 @@ BootLogoEnableLogo (
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 DestX =3D SizeOfX - Image.Width;
>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 DestY =3D SizeOfY - Image.Height; >
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 break;
>
> -
>
> +=C2=A0 =C2=A0 =C2=A0 case EdkiiPlatformLogoDisplayAttributeBGRTSpecif= ication:
>
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 DestX =3D (SizeOfX - Image.Width) / 2; >
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 DestY =3D (SizeOfY * 382) / 1000 - Image.= Height / 2;
>
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 break;
>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 default:
>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ASSERT (FALSE);
>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 continue;
>
> --
> 2.34.1
>
>
>
> -=3D-=3D-=3D-=3D-=3D-=3D
> Groups.io Links: You receive all messages sent to this group.
> View/Reply Online (#91842): https://edk2.groups.io/= g/devel/message/91842
> Mute This Topic: https://groups.io/mt/92623125/4905953=
> Group Owner: devel+owner@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub
> [gaolimi= ng@byosoft.com.cn]
> -=3D-=3D-=3D-=3D-=3D-=3D
>








--000000000000f2bbb105e578f45f--