From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f50.google.com (mail-ed1-f50.google.com [209.85.208.50]) by mx.groups.io with SMTP id smtpd.web11.1663.1632276936291046949 for ; Tue, 21 Sep 2021 19:15:36 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=Ik7OyE4t; spf=pass (domain: linaro.org, ip: 209.85.208.50, mailfrom: jun.nie@linaro.org) Received: by mail-ed1-f50.google.com with SMTP id eg28so3962907edb.1 for ; Tue, 21 Sep 2021 19:15:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=B9b41lM2owHiKCS7rY1T69wmVp5Z1Lp6veocnIJf0Yw=; b=Ik7OyE4txPm3cV1gvqjPOQ7MAEwPgXnZ3iU0GcuAJyg0pFgAKqdT9bBKCbbeHt+zl5 jXPFlspEstKjy8/rsK5l6cC9bZI44331t87suZ7l8r85QMtgKNGVWXSL/U5bqbHixj5s ZNjtXN9O33m8O3+RiMuvLjtP2JfDgD2DgxiB64aR1gQVOO40RzcAx478p0X7blJeSnOl y6G5nYzH3Sw224ZknIyrNLNx1AZrb9mFJ6tWQTnmLcyoFRFNMvUqEK8SxKRaPRvyv25/ wWcDnfQ9kkEYGwhY3JBgpNZ6PsZ1OUVYobCL35RNbSrXLpReIAhIn84Bt+x4js8/oLXN fWYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=B9b41lM2owHiKCS7rY1T69wmVp5Z1Lp6veocnIJf0Yw=; b=RZKIQbdzxsZsAp2JFxRx2Bbp5WbqdxCStbqpVzBhxURY3AFvPFbxrLPd7GYhcduDcZ mmpJWuxSKiIhmbCV8Nm/9ZD1vn2jurvU9z1O8Izy1Vp9ys25G7zQ+S8y5n3oE4D7BLwI 8++dKqWnnteR3m4q8ho+W9F04S7d/wkFPvrlNNS9SlkVlH49F166Xu1hLsQrkUR8p/w9 mMwSThDSIutH8Vo9x9gWrhTfJer6pbZ+NFw4H2hWccTmPazJK5G1cMiVmnRTM3Lo0RZQ O1jCBNhpSZ8G8ETdDMBYA8eyZcjhuPMi3d5e37TstrEOZf+LenHFFDqcR1uuQf2CApZ7 DiFQ== X-Gm-Message-State: AOAM531wzZIpX08FRLL3+nyyduZxbLpgQNatSO6LISMqhwK4o48z8TAl 1S5h6SJf4gUpSM3re7wqm9a9mVee5+NXRSqLvJYQZg== X-Google-Smtp-Source: ABdhPJwKM/uM3NhDvKc3bDGbj77JnZVCO+ZXYxQl6IwTWFXiQgxOMaINb7REhBaSmqxrZu+VTDgmlUFtwJslCiob0VA= X-Received: by 2002:a17:906:520b:: with SMTP id g11mr38609125ejm.502.1632276934682; Tue, 21 Sep 2021 19:15:34 -0700 (PDT) MIME-Version: 1.0 References: <20210914150058.nb5z4hz2a3e7ndts@leviathan> In-Reply-To: From: Jun Nie Date: Wed, 22 Sep 2021 10:15:23 +0800 Message-ID: Subject: Re: [PATCH v3 0/4] AndroidBootImgLib improvements To: Jeff Brasen Cc: Leif Lindholm , "devel@edk2.groups.io" , "daniel.schaefer@hpe.com" , "abner.chang@hpe.com" , "ardb+tianocore@kernel.org" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Jeff, I do not ever work on EDK soon after this patch set was merged. It is long time since then. I am sorry that I have no comments other than no objections on your patch. Regards, Jun Jeff Brasen =E4=BA=8E2021=E5=B9=B49=E6=9C=8822=E6=97= =A5=E5=91=A8=E4=B8=89 =E4=B8=8A=E5=8D=8812:33=E5=86=99=E9=81=93=EF=BC=9A > > Jun/Others, > > Any additional comments on this patch series? > > Thanks, > > Jeff > > ________________________________ > From: Jeff Brasen > Sent: Tuesday, September 14, 2021 10:57 AM > To: Leif Lindholm > Cc: devel@edk2.groups.io ; daniel.schaefer@hpe.com = ; abner.chang@hpe.com ; ardb+= tianocore@kernel.org ; Jun Nie > Subject: Re: [PATCH v3 0/4] AndroidBootImgLib improvements > > So for patch 3: This is only a change if mAndroidBootImg->UpdateDtb =3D= =3D NULL. > > This seemed like a bug as we would not add the initrd values nor would we= use the fdt from the BootImg if that is where the device tree was sourced = from. > > It seems like either we should require UpdateDtb to be implemented (which= seems to cause greater compatibility issues) or we install the device tree= we have if that function isn't implemented. > > As far as merging goes I am fine either way. Our particular flow won't hi= t this path as we don't have a device tree in the bootimg (use the system c= onfig table) and we will have the new pcd set, but this seemed like a bug w= hile I looking at this code. > > Thanks, > > Jeff > > ________________________________ > From: Leif Lindholm > Sent: Tuesday, September 14, 2021 9:00 AM > To: Jeff Brasen > Cc: devel@edk2.groups.io ; daniel.schaefer@hpe.com = ; abner.chang@hpe.com ; ardb+= tianocore@kernel.org ; Jun Nie > Subject: Re: [PATCH v3 0/4] AndroidBootImgLib improvements > > External email: Use caution opening links or attachments > > > Hi Jeff, > > Thanks for this. > This set looks good to me, with a slight question mark wrt behaviour > compatibility with previous versions for 3/4. > (I think it's fine, but I'm a bear of very little brain, and it's been > several years since I reviewed this code, and even longer since I > really interacted with Android. > ^ > | shameless plug for more EmbeddedPkg reviewer volunteers.) > > I've added Jun Nie, who wrote the original version of this code, to > see if he has any comments. > > 1-2/4 are obviously unproblematic, and I could merge those ahead of > time if preferred. You can add > Reviewed-by: Leif Lindholm > for those if there are any further revisions of the set. > > Best Regards, > > Leif > > On Mon, Sep 13, 2021 at 23:18:47 +0000, Jeff Brasen wrote: > > Added support for using loadfile2 approach for passing ramdisk to linux= . > > Created patch series for general error handling improvments based on > > review feedback. > > If ACPI tables are in system table or PCD is defined the LoadFile2 meth= od > > of passing initrd will be used. > > > > [v3] > > -Code review cleanup > > -Removed duplicate header file > > -Added change to allow FDT to install if UpdateDtb function is not defi= ned > > -Added specific ACPI check > > -Moved install functions to subfunctions > > > > [v2] > > -Added review feedback > > -General improvements to error handling > > > > [v1] > > - Intial revision > > > > > > Jeff Brasen (4): > > EmbeddedPkg: Remove duplicate libfdt.h include > > EmbeddedPkg: AndroidBootImgBoot error handling updates > > EmbeddedPkg: Install FDT if UpdateDtb is not present > > EmbeddedPkg: Add LoadFile2 for linux initrd > > > > EmbeddedPkg/EmbeddedPkg.dec | 1 + > > .../AndroidBootImgLib/AndroidBootImgLib.inf | 4 + > > .../AndroidBootImgLib/AndroidBootImgLib.c | 275 +++++++++++++++--- > > 3 files changed, 233 insertions(+), 47 deletions(-) > > > > -- > > 2.17.1 > >