From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt0-x231.google.com (mail-qt0-x231.google.com [IPv6:2607:f8b0:400d:c0d::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 6682421D491A5 for ; Wed, 2 Aug 2017 07:00:18 -0700 (PDT) Received: by mail-qt0-x231.google.com with SMTP id p3so27239569qtg.2 for ; Wed, 02 Aug 2017 07:02:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=lqOCeq6xtMUYw05F2KnLboi6TkkJ3N80lzTqHnEcML8=; b=KyGyb/iZrI4DZnfKjByB2Ion+qSKMowl6pMpqoy2W/bCCUkBWaq6/lWzXDXieLAinF smkULbL/Y9amrNhn+03asOtnewBdmX61yvH46JH8cZ4KsW8aM+I89Fwf2g4+yI68Q0jM 7Ztifov7TjJG2iNidxxqcJ2TLkN2jvrgSohL4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=lqOCeq6xtMUYw05F2KnLboi6TkkJ3N80lzTqHnEcML8=; b=d6jxkcZ1hwSFjdvvLZV9LhZQZMyvYoi/EabzQmhHFkwA3qrUxoE4GWbVsIg11nprgn xZxepn7or1T6KrJ1xIPJtU7Gr2CGBbxe55rtjQhR8OBjyOorIcwHDoxtasXqWEuAQ+My uET4EA28ffd49g5X198oxCgK2pEJGKo0IfQZsBVJayQrvyAx7dFtm4GPxM/Oh/6bAnKM l6DdrCqDfcctneUqPybeJh2V919Y+DG6CFzJpClXCWY7D5UTzFnZrxqEf8DLqlMd6eYL FeS7E+k2CyqhXKtDwaejfamxrbBuRFOz+i87mZUralaqKNPMGkUn6dL3ZF4EF0w/+RRU QkfA== X-Gm-Message-State: AIVw113sDo46B9Vec4LRx5QDk/Wq+xEtT7XjL5DXs2cTH+XvtPDQjy6D dJrVHDaDf4i5Nao4BaA7N67a2YN4AMOg X-Received: by 10.200.35.23 with SMTP id a23mr31330664qta.56.1501682547701; Wed, 02 Aug 2017 07:02:27 -0700 (PDT) MIME-Version: 1.0 Received: by 10.55.110.66 with HTTP; Wed, 2 Aug 2017 07:02:26 -0700 (PDT) In-Reply-To: <20170801161952.GE26462@bivouac.eciton.net> References: <1501579741-28866-1-git-send-email-jun.nie@linaro.org> <1501579741-28866-4-git-send-email-jun.nie@linaro.org> <20170801161952.GE26462@bivouac.eciton.net> From: Jun Nie Date: Wed, 2 Aug 2017 22:02:26 +0800 Message-ID: To: Leif Lindholm Cc: Haojian Zhuang , Ard Biesheuvel , edk2-devel@lists.01.org, linaro-uefi@lists.linaro.org, Shawn Guo , Jason Liu Subject: Re: [PATCH v4 4/4] EmbeddedPkg: add Android boot device path and guid X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Aug 2017 14:00:18 -0000 Content-Type: text/plain; charset="UTF-8" 2017-08-02 0:19 GMT+08:00 Leif Lindholm : > Right, so this one confused me a bit, since it looked like it was > breaking bisect again. It does, which caused me to take a closer > look. > > First of all, you need to add > EmbeddedPkg/Application/AndroidBoot/AndroidBootApp.inf to > EmbeddedPkg/EmbeddedPkg.dsc [Components.common]. > > Once done, you should be able to build the application standalone with > build -a AARCH64 -t GCC5 -p EmbeddedPkg/EmbeddedPkg.dsc -m EmbeddedPkg/Application/AndroidBoot/AndroidBootApp.inf > > For this to work, you also need to add a AndroidBootImgLib mapping to > [LibraryClasses.common]. > > Once that is done, the modifications here need to be squashed into > 3/4. This patch have to be the last one, later than AndroidBootImg patch. Otherwise build failure happens due to lack of AndroidBootImgLib. > > / > Leif > > On Tue, Aug 01, 2017 at 05:29:01PM +0800, Jun Nie wrote: >> The device path specifies where to load android boot image. >> >> Contributed-under: TianoCore Contribution Agreement 1.0 >> Signed-off-by: Jun Nie >> --- >> EmbeddedPkg/EmbeddedPkg.dec | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/EmbeddedPkg/EmbeddedPkg.dec b/EmbeddedPkg/EmbeddedPkg.dec >> index 4cd528a..8ad2a84 100644 >> --- a/EmbeddedPkg/EmbeddedPkg.dec >> +++ b/EmbeddedPkg/EmbeddedPkg.dec >> @@ -80,6 +80,7 @@ >> gAndroidFastbootPlatformProtocolGuid = { 0x524685a0, 0x89a0, 0x11e3, {0x9d, 0x4d, 0xbf, 0xa9, 0xf6, 0xa4, 0x03, 0x08}} >> gUsbDeviceProtocolGuid = { 0x021bd2ca, 0x51d2, 0x11e3, {0x8e, 0x56, 0xb7, 0x54, 0x17, 0xc7, 0x0b, 0x44 }} >> gPlatformGpioProtocolGuid = { 0x52ce9845, 0x5af4, 0x43e2, {0xba, 0xfd, 0x23, 0x08, 0x12, 0x54, 0x7a, 0xc2 }} >> + gAndroidBootImgProtocolGuid = { 0x9859bb19, 0x407c, 0x4f8b, {0xbc, 0xe1, 0xf8, 0xda, 0x65, 0x65, 0xf4, 0xa5 }} >> >> [PcdsFeatureFlag.common] >> gEmbeddedTokenSpaceGuid.PcdEmbeddedMacBoot|FALSE|BOOLEAN|0x00000001 >> @@ -181,6 +182,7 @@ >> gEmbeddedTokenSpaceGuid.PcdAndroidFastbootUsbProductId|0xbeef|UINT32|0x00000023 >> gEmbeddedTokenSpaceGuid.PcdAndroidFastbootTcpPort|1234|UINT32|0x00000024 >> >> + gEmbeddedTokenSpaceGuid.PcdAndroidBootDevicePath|L""|VOID*|0x00000057 >> >> [PcdsFixedAtBuild.ARM] >> gEmbeddedTokenSpaceGuid.PcdPrePiCpuMemorySize|32|UINT8|0x00000010 >> -- >> 1.9.1 >>