From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt0-x22e.google.com (mail-qt0-x22e.google.com [IPv6:2607:f8b0:400d:c0d::22e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 7DE4921A143DA for ; Thu, 8 Jun 2017 20:53:25 -0700 (PDT) Received: by mail-qt0-x22e.google.com with SMTP id w1so63333240qtg.2 for ; Thu, 08 Jun 2017 20:54:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=A8CeeMbTBoR1laSzOehJqS2t+oAUw+qg1YG2iX5WDRQ=; b=H2rMQLK6xKMD6WndTQ9DO20ODT6xcJkmubCtYHFfPNH5KV5UatFUmNLokUUQW/jtBs d89hbBrnpiXMJ2I0ztinx3kVJWI6sRF9iU6mptDkjc6qd/QxRhHjIDB7tge9+asAIer3 CX6c+C4URdYITFIEShIAumh6a5fnWGqCn4vy4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=A8CeeMbTBoR1laSzOehJqS2t+oAUw+qg1YG2iX5WDRQ=; b=aXAbMx7DzM5owoTFBwZllQY6/NIyIE9OzRFWEondW165PpdP+8T1pNPSb9x6FvzN4l avQ03c01BYGPZKMZ88WeilB0AJyzYV60qURM8RF2dfNGAiWbPvQUmZ1CeqGTxCtf4u14 XTSC4Reb8SuJ4CvuCYjSpEZn2SEt3RvnniYyjzSBb0z0iK/o0QZLpToxga3X+HNvlBw2 mLSUxVodCvLbfIydUoKJ0yj+J7J9UkW2R41ee7qmr8TmbuHksHEgK3xeE/KT6MtF4oSh wy3quKfdPfSHecFe238fYva5vWNDneNojLcR6mOR6KRfv/256t7RluaZfwreV+hZKk9n PBKg== X-Gm-Message-State: AKS2vOw2MUuChltLglcuQDuA458IXqaT5c/brfLxz5HFtNTRkoAl1UiW NJdcJ+0WOhGEXm6ASpi5wfugPXmbg/QQ X-Received: by 10.55.12.11 with SMTP id 11mr48378818qkm.135.1496980474154; Thu, 08 Jun 2017 20:54:34 -0700 (PDT) MIME-Version: 1.0 Received: by 10.55.0.69 with HTTP; Thu, 8 Jun 2017 20:54:33 -0700 (PDT) In-Reply-To: <20170608165512.GB26676@bivouac.eciton.net> References: <1496909547-16085-1-git-send-email-jun.nie@linaro.org> <20170608165512.GB26676@bivouac.eciton.net> From: Jun Nie Date: Fri, 9 Jun 2017 11:54:33 +0800 Message-ID: To: Leif Lindholm Cc: Haojian Zhuang , edk2-devel@lists.01.org, Jason Liu , Shawn Guo Subject: Re: [PATCH] EmbeddedPkg/MmcDxe: Add non-DDR timing mode support X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Jun 2017 03:53:25 -0000 Content-Type: text/plain; charset="UTF-8" 2017-06-09 0:55 GMT+08:00 Leif Lindholm : > On Thu, Jun 08, 2017 at 04:39:44PM +0800, Haojian Zhuang wrote: >> On 2017/6/8 16:12, Jun Nie wrote: >> >Only DDR mode is support for 8bit mode currently. Add >> >non-DDR case when configuring ECSD. >> > >> >Contributed-under: TianoCore Contribution Agreement 1.0 >> >Signed-off-by: Jun Nie >> >--- >> > EmbeddedPkg/Universal/MmcDxe/MmcIdentification.c | 5 ++++- >> > 1 file changed, 4 insertions(+), 1 deletion(-) >> > >> >diff --git a/EmbeddedPkg/Universal/MmcDxe/MmcIdentification.c b/EmbeddedPkg/Universal/MmcDxe/MmcIdentification.c >> >index 574a77e..5c0d7e7 100644 >> >--- a/EmbeddedPkg/Universal/MmcDxe/MmcIdentification.c >> >+++ b/EmbeddedPkg/Universal/MmcDxe/MmcIdentification.c >> >@@ -286,7 +286,10 @@ InitializeEmmcDevice ( >> > } >> > Status = Host->SetIos (Host, BusClockFreq, 8, TimingMode[Idx]); >> > if (!EFI_ERROR (Status)) { >> >- Status = EmmcSetEXTCSD (MmcHostInstance, EXTCSD_BUS_WIDTH, EMMC_BUS_WIDTH_DDR_8BIT); >> >+ if (Idx < 2) >> >> It's better to avoid hardcoded value at here. Maybe you can use switch & >> case on TimingMode array at here. > > Yes, that would also work. > > Indeed, if any other possible values than EMMC_BUS_WIDTH_DDR_8BIT or > EMMC_BUS_WIDTH_8BIT could be likely in the future, that would be the > preferable solution. > > Regards, > > Leif Yes, follow switch/case way is more extendable. Will add it and add maintainer in next version. Jun > >> >+ Status = EmmcSetEXTCSD (MmcHostInstance, EXTCSD_BUS_WIDTH, EMMC_BUS_WIDTH_DDR_8BIT); >> >+ else >> >+ Status = EmmcSetEXTCSD (MmcHostInstance, EXTCSD_BUS_WIDTH, EMMC_BUS_WIDTH_8BIT); >> > if (EFI_ERROR (Status)) { >> > DEBUG ((DEBUG_ERROR, "InitializeEmmcDevice(): Failed to set EXTCSD bus width, Status:%r\n", Status)); >> > } >> > >> >> Best Regards >> Haojian >> _______________________________________________ >> edk2-devel mailing list >> edk2-devel@lists.01.org >> https://lists.01.org/mailman/listinfo/edk2-devel