From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web08.1301.1605168610863509211 for ; Thu, 12 Nov 2020 00:10:11 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: vijayenthiran.subramaniam@arm.com) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id DDB9F1474 for ; Thu, 12 Nov 2020 00:10:09 -0800 (PST) Received: from mail-wm1-f53.google.com (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id BACE63FA32 for ; Thu, 12 Nov 2020 00:10:09 -0800 (PST) Received: by mail-wm1-f53.google.com with SMTP id d142so4409947wmd.4 for ; Thu, 12 Nov 2020 00:10:09 -0800 (PST) X-Gm-Message-State: AOAM53291aoHlKUp9+ouFs0zJiDSieqczTMF6BpShPrJ+TAT8oc6pZ66 jfan/OOkXQYu5L7Y6nJyC1nJ1554Qi7AbeDn4YU= X-Google-Smtp-Source: ABdhPJxI7Nm3lPcvqdNiLnDZZYBzEh93Bb/qmBBbdmRPBk0FoBnA5l8R6T5qkeQ4r1kmdgkbJB29bPbz1NUDBMpx2NE= X-Received: by 2002:a1c:750b:: with SMTP id o11mr8544251wmc.32.1605168600587; Thu, 12 Nov 2020 00:10:00 -0800 (PST) MIME-Version: 1.0 References: <1601991736-32039-1-git-send-email-vijayenthiran.subramaniam@arm.com> In-Reply-To: From: "Vijayenthiran Subramaniam" Date: Thu, 12 Nov 2020 08:09:49 +0000 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [edk2-platforms] [PATCH v3-resend] SgiPkg/RdN1EdgeX2: Add missing reference to PcdChipCount To: devel@edk2.groups.io, leif@nuviainc.com, Ard.Biesheuvel@arm.com Cc: michael.d.kinney@intel.com, thomas.abraham@arm.com, Sami.Mujawar@arm.com, Aditya.Angadi@arm.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi all, On Wed, Oct 14, 2020 at 7:33 AM Vijayenthiran Subramanian wrote: > > Hi all, > > On Tue, Oct 6, 2020 at 1:42 PM Vijayenthiran Subramaniam > wrote: > > > > Commit e8fe2026dd79 (=E2=80=9CPlatform/ARM/SgiPkg: Use chip count const= ant on > > rdn1edgex2 platform=E2=80=9D) used the PcdChipCount constant but did no= t declare > > its use in the ACPI table module. Fix this by listing it in the list of > > PCDs to be looked up. > > > > Signed-off-by: Vijayenthiran Subramaniam > > Reviewed-by: Thomas Abraham > > Reviewed-by: Sami Mujawar > > --- > > > > Resending PATCH-v3 [1] with Reviewed-bys added. > > > > [1]: https://edk2.groups.io/g/devel/topic/77339902 > > > > Changes since v2: > > - Rebased to latest master and repost. > > > > Changes since v1: > > - Add commit id in commit message for which this patch fixes the buil= d > > failure. > > > > Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf b/= Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf > > index 974d9db543..d44f02ab0c 100644 > > --- a/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf > > +++ b/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf > > @@ -45,6 +45,8 @@ > > gArmSgiTokenSpaceGuid.PcdDramBlock2Base > > gArmSgiTokenSpaceGuid.PcdDramBlock2Size > > > > + gArmSgiTokenSpaceGuid.PcdChipCount > > + > > gArmTokenSpaceGuid.PcdArmArchTimerSecIntrNum > > gArmTokenSpaceGuid.PcdArmArchTimerIntrNum > > gArmTokenSpaceGuid.PcdArmArchTimerHypIntrNum > > -- > > 2.17.1 > > A kindly reminder for this patch. > > Regards, > Vijayenthiran A gentle reminder to take a look at this patch. Regards, Vijayenthiran