From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by mx.groups.io with SMTP id smtpd.web08.6426.1605197032236880271
 for <devel@edk2.groups.io>;
 Thu, 12 Nov 2020 08:03:52 -0800
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: vijayenthiran.subramaniam@arm.com)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
	by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 18FD016A3
	for <devel@edk2.groups.io>; Thu, 12 Nov 2020 08:03:51 -0800 (PST)
Received: from mail-wm1-f51.google.com (unknown [172.31.20.19])
	by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id EA1D43FA45
	for <devel@edk2.groups.io>; Thu, 12 Nov 2020 08:03:50 -0800 (PST)
Received: by mail-wm1-f51.google.com with SMTP id d142so5722839wmd.4
        for <devel@edk2.groups.io>; Thu, 12 Nov 2020 08:03:50 -0800 (PST)
X-Gm-Message-State: AOAM533bC8q5sbO6jbFJZHc3Evr8QqkT5VVq1J1UCdV6w4zCTk+Mi5P7
	gId6a7bbDl8U6xdhdhKjKAQfMqNBW8FmoRt8KeQ=
X-Google-Smtp-Source: ABdhPJylDUeSjddgpIwErHJRJeY529LBsAN0Dw0JMV5whzzZNSAHUexoME1WROJkPAx0W50iPIeoQNDoxhR49bicSqI=
X-Received: by 2002:a1c:1f08:: with SMTP id f8mr395059wmf.30.1605197029761;
 Thu, 12 Nov 2020 08:03:49 -0800 (PST)
MIME-Version: 1.0
References: <1601991736-32039-1-git-send-email-vijayenthiran.subramaniam@arm.com>
 <CAC0BY-fOyYV1be52TSuyB=d0MLNCw6L0Q=k0BBWiPq_NiBC_yw@mail.gmail.com>
 <CAC0BY-czWk9UJNSN+E4+tcWiUUBNHWCD1UGHHPB04bMM9EGavw@mail.gmail.com> <6b63ff3c-99b5-f330-079e-34d87122465f@arm.com>
In-Reply-To: <6b63ff3c-99b5-f330-079e-34d87122465f@arm.com>
From: "Vijayenthiran Subramaniam" <vijayenthiran.subramaniam@arm.com>
Date: Thu, 12 Nov 2020 16:03:35 +0000
X-Gmail-Original-Message-ID: <CAC0BY-dDF=SmtmNoQTOOouOPNgzKz4fhbzjE3gLTQvOygVd-=Q@mail.gmail.com>
Message-ID: <CAC0BY-dDF=SmtmNoQTOOouOPNgzKz4fhbzjE3gLTQvOygVd-=Q@mail.gmail.com>
Subject: Re: [edk2-devel] [edk2-platforms] [PATCH v3-resend] SgiPkg/RdN1EdgeX2: Add missing reference to PcdChipCount
To: devel@edk2.groups.io, ard.biesheuvel@arm.com
Cc: leif@nuviainc.com, michael.d.kinney@intel.com, thomas.abraham@arm.com, 
	Sami.Mujawar@arm.com, Aditya.Angadi@arm.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, Nov 12, 2020 at 9:12 AM Ard Biesheuvel <ard.biesheuvel@arm.com> wro=
te:
>
> On 11/12/20 9:09 AM, Vijayenthiran Subramanian wrote:
> > Hi all,
> >
> > On Wed, Oct 14, 2020 at 7:33 AM Vijayenthiran Subramanian
> > <vijayenthiran.subramaniam@arm.com> wrote:
> >>
> >> Hi all,
> >>
> >> On Tue, Oct 6, 2020 at 1:42 PM Vijayenthiran Subramaniam
> >> <vijayenthiran.subramaniam@arm.com> wrote:
> >>>
> >>> Commit e8fe2026dd79 (=E2=80=9CPlatform/ARM/SgiPkg: Use chip count con=
stant on
> >>> rdn1edgex2 platform=E2=80=9D) used the PcdChipCount constant but did =
not declare
> >>> its use in the ACPI table module. Fix this by listing it in the list =
of
> >>> PCDs to be looked up.
> >>>
> >>> Signed-off-by: Vijayenthiran Subramaniam <vijayenthiran.subramaniam@a=
rm.com>
> >>> Reviewed-by: Thomas Abraham <thomas.abraham@arm.com>
> >>> Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
> >>> ---
> >>>
> >>> Resending PATCH-v3 [1] with Reviewed-bys added.
> >>>
> >>> [1]: https://edk2.groups.io/g/devel/topic/77339902
> >>>
> >>> Changes since v2:
> >>>    - Rebased to latest master and repost.
> >>>
> >>> Changes since v1:
> >>>    - Add commit id in commit message for which this patch fixes the b=
uild
> >>>      failure.
> >>>
> >>>   Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf | 2 ++
> >>>   1 file changed, 2 insertions(+)
> >>>
> >>> diff --git a/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf =
b/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf
> >>> index 974d9db543..d44f02ab0c 100644
> >>> --- a/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf
> >>> +++ b/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf
> >>> @@ -45,6 +45,8 @@
> >>>     gArmSgiTokenSpaceGuid.PcdDramBlock2Base
> >>>     gArmSgiTokenSpaceGuid.PcdDramBlock2Size
> >>>
> >>> +  gArmSgiTokenSpaceGuid.PcdChipCount
> >>> +
> >>>     gArmTokenSpaceGuid.PcdArmArchTimerSecIntrNum
> >>>     gArmTokenSpaceGuid.PcdArmArchTimerIntrNum
> >>>     gArmTokenSpaceGuid.PcdArmArchTimerHypIntrNum
> >>> --
> >>> 2.17.1
> >>
> >> A kindly reminder for this patch.
> >>
> >> Regards,
> >> Vijayenthiran
> >
> > A gentle reminder to take a look at this patch.
> >
>
> My apologies
>
> Pushed as 1a9cbd7fe9cc..867efd012b2f

Thanks Ard.