From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail-io1-f67.google.com (mail-io1-f67.google.com [209.85.166.67])
 by mx.groups.io with SMTP id smtpd.web10.138598.1598028603686820759
 for <devel@edk2.groups.io>;
 Fri, 21 Aug 2020 09:50:03 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@gmail.com header.s=20161025 header.b=NAAzInER;
 spf=pass (domain: gmail.com, ip: 209.85.166.67, mailfrom: mailinglistforreading@gmail.com)
Received: by mail-io1-f67.google.com with SMTP id h4so2361434ioe.5
        for <devel@edk2.groups.io>; Fri, 21 Aug 2020 09:50:03 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20161025;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=aaA4iHrpDy+eobfCozVQMyibHemp/XFzPgm6sIvPjc4=;
        b=NAAzInERWnPyeDTWH6Reyw4qOLZbm2o0PLuZqDZhVBkwW5WiCI/jvZxAtpTe2VaPRg
         dbuSjA+lf6Dk0kZhGi+yizEk/qXi3P0ZIskloa7flk7+jMIhXES6EedS1kgQMcspynft
         OmOp9c64uUvCZtD4Iz2Zt/yR5zwe+C3ZUvgwUBHkbBQcjIk5yRcPxuPpaVeU3nJs6B6l
         sZ9A6KEcxgJoTxk3bvGIQdXUUl8/DE3udmxtvlblUHG7csNcwhzXQJfKHCrYLx3Dhhbl
         lZAiiMixyFYJMM9g+ZfWTIP5QeZUU9iJja3AnWyKxzYDr2fjP6vDHzP+zycDaF9fPI4L
         BEFg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=aaA4iHrpDy+eobfCozVQMyibHemp/XFzPgm6sIvPjc4=;
        b=bhTAAoyrJno13pAfUlcScDGLaDYLCG9yuFOpV284hM/6c8hqbtMs/rr8/WGOnch/nh
         k/UeHhDvYSe/cXFa/ab4HYPgeC/20C8iMaam2V4LOt0As3AopBp4OIzEtMfT0x/mm0ae
         tD8fnU6L6CfUt6ucIYbKJ0tnyRJGhYcW/us6vqHRP9LrcC13APWLXOds7VKuYRx9RfUo
         zJFP8yztWX0K9N3lJZWPvqWCnm8UIIYUNgwd4duLCnPm9cr0AcAbDlRI9Vdqyn8dSVTt
         wgg3h49aJwi6BscZA1T5+fZc7wcNwozdeENpS87JNpTrcQmzos1PxEjSOVWYzqlr8gRy
         EbfQ==
X-Gm-Message-State: AOAM533TOMAMnPkxAtLUduGKRvD+gFfd2ZxC8SVRYmJEmS+zy6Q5bJkB
	c0bK7oO54C/nmh77fG6SwHmX1sB4r8v9ZdYoHBQNAPCAaWg=
X-Google-Smtp-Source: ABdhPJw9eNpdflT31ITHCSMGSEdQJDpXU/OtmvCgofdiWUbLaHswCxyPm2sSWhm1HE0zmnoBLLyjdjpjcMLdjuGTPdI=
X-Received: by 2002:a5e:8f06:: with SMTP id c6mr2920831iok.119.1598028602511;
 Fri, 21 Aug 2020 09:50:02 -0700 (PDT)
MIME-Version: 1.0
References: <1597848823-27171-1-git-send-email-vijayenthiran.subramaniam@arm.com>
 <20200820095956.GA1191@vanye>
In-Reply-To: <20200820095956.GA1191@vanye>
From: mailinglistforreading@gmail.com
Date: Fri, 21 Aug 2020 16:49:51 +0000
Message-ID: <CAC0BY-dYZiXxT9sJMsRbsmQacmKo+cxnUFGXmGXQVEg0u43upQ@mail.gmail.com>
Subject: Re: [edk2-devel] [PATCH] SgiPkg: Add chip count PCD to build information file for rdn1edgex2
To: devel@edk2.groups.io, leif@nuviainc.com
Cc: Ard.Biesheuvel@arm.com, thomas.abraham@arm.com, Aditya.Angadi@arm.com, 
	richard.storer@arm.com, sami.mujawar@arm.com
Content-Type: text/plain; charset="UTF-8"

Hi Leif

On Thu, Aug 20, 2020 at 10:00 AM Leif Lindholm <leif@nuviainc.com> wrote:
>
> On Wed, Aug 19, 2020 at 20:23:43 +0530, Vijayenthiran Subramaniam wrote:
> > PcdChipCount constant is used to define the maximum number chips
> > included in the multi-chip configuration. Add this constant to the
> > RDN1EdgeX2 ACPI tables build information (INF) file to allow this
> > constant to be used in the RDN1EdgeX2 ACPI tables.
>
> This patch fixes a build failure, the commit message should say so,
> and refer to which commit it fixes.
>

Okay, I will do that.

> Also, this fixes a build failure introduced 3.5 months ago, and no one
> noticed until now. Are we sure this platform belongs upstream?

This was noticed after the patch was merged upstream. This probably
slipped through during the patch rework and rebase. This was fixed
outside of the upstream code but missed to get this merged upstream.

Regards,
Vijayenthiran

>
> /
>     Leif
>
> > Signed-off-by: Vijayenthiran Subramaniam <vijayenthiran.subramaniam@arm.com>
> > ---
> >  Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf b/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf
> > index 974d9db543..d44f02ab0c 100644
> > --- a/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf
> > +++ b/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf
> > @@ -45,6 +45,8 @@
> >    gArmSgiTokenSpaceGuid.PcdDramBlock2Base
> >    gArmSgiTokenSpaceGuid.PcdDramBlock2Size
> >
> > +  gArmSgiTokenSpaceGuid.PcdChipCount
> > +
> >    gArmTokenSpaceGuid.PcdArmArchTimerSecIntrNum
> >    gArmTokenSpaceGuid.PcdArmArchTimerIntrNum
> >    gArmTokenSpaceGuid.PcdArmArchTimerHypIntrNum
> > --
> > 2.17.1
> >
>