From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by mx.groups.io with SMTP id smtpd.web10.6456.1602660829022996345
 for <devel@edk2.groups.io>;
 Wed, 14 Oct 2020 00:33:49 -0700
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: vijayenthiran.subramaniam@arm.com)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
	by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A1DEC113E
	for <devel@edk2.groups.io>; Wed, 14 Oct 2020 00:33:47 -0700 (PDT)
Received: from mail-wr1-f45.google.com (unknown [172.31.20.19])
	by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 7E1B33F99C
	for <devel@edk2.groups.io>; Wed, 14 Oct 2020 00:33:47 -0700 (PDT)
Received: by mail-wr1-f45.google.com with SMTP id b8so2546532wrn.0
        for <devel@edk2.groups.io>; Wed, 14 Oct 2020 00:33:47 -0700 (PDT)
X-Gm-Message-State: AOAM532X69Xr7ZaosLNtPrC/juRKE3UVE4XH4jBfaPNq3LpqWdtF3gSj
	dQihhuK8zkMeNXM6W2lmAphGxf8C7EoorCydW7w=
X-Google-Smtp-Source: ABdhPJyAuBlzPDAOBlB09ZdEoTQR1d71EU5HiRvFC1x+fdjpEvkNfBS3vAnv8MgA/K0yrIXKTeIPk/sXj2E0Ssd4yYg=
X-Received: by 2002:a5d:498a:: with SMTP id r10mr3942940wrq.106.1602660818345;
 Wed, 14 Oct 2020 00:33:38 -0700 (PDT)
MIME-Version: 1.0
References: <1601991736-32039-1-git-send-email-vijayenthiran.subramaniam@arm.com>
In-Reply-To: <1601991736-32039-1-git-send-email-vijayenthiran.subramaniam@arm.com>
From: "Vijayenthiran Subramaniam" <vijayenthiran.subramaniam@arm.com>
Date: Wed, 14 Oct 2020 07:33:26 +0000
X-Gmail-Original-Message-ID: <CAC0BY-fOyYV1be52TSuyB=d0MLNCw6L0Q=k0BBWiPq_NiBC_yw@mail.gmail.com>
Message-ID: <CAC0BY-fOyYV1be52TSuyB=d0MLNCw6L0Q=k0BBWiPq_NiBC_yw@mail.gmail.com>
Subject: Re: [edk2-devel] [edk2-platforms] [PATCH v3-resend] SgiPkg/RdN1EdgeX2: Add missing reference to PcdChipCount
To: devel@edk2.groups.io
Cc: leif@nuviainc.com, Ard.Biesheuvel@arm.com, thomas.abraham@arm.com, 
	Sami.Mujawar@arm.com, Aditya.Angadi@arm.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi all,

On Tue, Oct 6, 2020 at 1:42 PM Vijayenthiran Subramaniam
<vijayenthiran.subramaniam@arm.com> wrote:
>
> Commit e8fe2026dd79 (=E2=80=9CPlatform/ARM/SgiPkg: Use chip count constan=
t on
> rdn1edgex2 platform=E2=80=9D) used the PcdChipCount constant but did not =
declare
> its use in the ACPI table module. Fix this by listing it in the list of
> PCDs to be looked up.
>
> Signed-off-by: Vijayenthiran Subramaniam <vijayenthiran.subramaniam@arm.c=
om>
> Reviewed-by: Thomas Abraham <thomas.abraham@arm.com>
> Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
> ---
>
> Resending PATCH-v3 [1] with Reviewed-bys added.
>
> [1]: https://edk2.groups.io/g/devel/topic/77339902
>
> Changes since v2:
>   - Rebased to latest master and repost.
>
> Changes since v1:
>   - Add commit id in commit message for which this patch fixes the build
>     failure.
>
>  Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf b/Pl=
atform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf
> index 974d9db543..d44f02ab0c 100644
> --- a/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf
> +++ b/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf
> @@ -45,6 +45,8 @@
>    gArmSgiTokenSpaceGuid.PcdDramBlock2Base
>    gArmSgiTokenSpaceGuid.PcdDramBlock2Size
>
> +  gArmSgiTokenSpaceGuid.PcdChipCount
> +
>    gArmTokenSpaceGuid.PcdArmArchTimerSecIntrNum
>    gArmTokenSpaceGuid.PcdArmArchTimerIntrNum
>    gArmTokenSpaceGuid.PcdArmArchTimerHypIntrNum
> --
> 2.17.1

A kindly reminder for this patch.

Regards,
Vijayenthiran