From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-vs1-f46.google.com (mail-vs1-f46.google.com [209.85.217.46]) by mx.groups.io with SMTP id smtpd.web11.137722.1673780005362141818 for ; Sun, 15 Jan 2023 02:53:25 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20210112 header.b=UQmYRBkj; spf=pass (domain: gmail.com, ip: 209.85.217.46, mailfrom: aladyshev22@gmail.com) Received: by mail-vs1-f46.google.com with SMTP id p1so9674998vsr.5 for ; Sun, 15 Jan 2023 02:53:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=gllwDF6S1rAIV0xvPxnKriKvfwI8Q98gFyWOd7reohk=; b=UQmYRBkjLcYh+vPK/f0CSkTrJu+RhNaQWaLG3B/OHmqJ/tqvvIwBD5gCPtolOKaqq9 XXxEh3JUgDYlIYd1OGVDx6ZrB/ObUa3r2q85FifLcvCiSrJUacIjj7iPm5k8IgKhqBTw 9yI6IJhgXIxouV8NISSB6QRdd9vj8k6lhsC8zpn8JPVdJZ6HRv3PCz2jcJwfFCMDPrPQ Ran9x0tpQH6VnoN3iqIGhT8KIAfyw0Kn5ET17WqrwyFAaLxZ8btwSRrsAfx40DNMUqVD luzKxc0Z8O6jGYwRpkpvHPhX9JotckJ5dQdcCERYEuvBtC//vzQLKP0nLQEu4p6yATUF q50g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=gllwDF6S1rAIV0xvPxnKriKvfwI8Q98gFyWOd7reohk=; b=6w1y57YRcPPqRUpdYoYhhjgr+AIJUaeUtKSMQvVTu7gNhDtIcrdeLRYYr0ojsHEb/z n0fuEoeTJj9tP8W5RanlVWddAeUR4oBP4r6dtmwqThEKYKeg+8gyEgYlUtXEiiSj2Isq y/vLr6dfJtou+C0C8hzr/MRSvL+W5jqehz20JxMmiRlsdJU1e62ZZSP/Bg80KhIbLHe/ M+hPpSHqol//Xn+qGccDn3xRKJqeONxIpE3OKbpLkM1ZIx29Ssg/Sf1PsI3E2J1OM01p HZlfoEcCVaARlMJJNTn1b3w2omlXpMSInvvdM87OdjKCKMNpdR2EuDLBZA47vD9f1XbG 2DSg== X-Gm-Message-State: AFqh2kpKYY+CJpAD9fwwb4v2eAj3HgyNQ9WdfF96+dkqefCYTTh2fQc8 RLhFTZjTz5QcCmiOC+/kcMunAE5QRQpIuHHYz5k= X-Google-Smtp-Source: AMrXdXuFsR9zDNl2zNX9lP0RveLdJ1hZO+tx8axVP84Ve6up+JapRCPWtzkd4+mik4onRxFL5Uo3jOfCIhcYwF9oowk= X-Received: by 2002:a05:6102:412:b0:3d2:3550:65b3 with SMTP id d18-20020a056102041200b003d2355065b3mr603530vsq.52.1673780004270; Sun, 15 Jan 2023 02:53:24 -0800 (PST) MIME-Version: 1.0 References: <20221212130924.8156-1-aladyshev22@gmail.com> <20221213162222.590-1-aladyshev22@gmail.com> In-Reply-To: From: "Konstantin Aladyshev" Date: Sun, 15 Jan 2023 13:53:13 +0300 Message-ID: Subject: Re: [PATCH] Fix cyclic dependency error on OptionROM build To: Jake Garver Cc: "devel@edk2.groups.io" , "bob.c.feng@intel.com" , "gaoliming@byosoft.com.cn" , "yuwei.chen@intel.com" Content-Type: text/plain; charset="UTF-8" Hello! Sorry to bother everyone. It's been over a month. Can we merge this? Best regards, Konstantin Aladyshev On Tue, Dec 13, 2022 at 9:47 PM Jake Garver wrote: > > Thanks, Konstantin, > > I approve this version. > > Thanks, > Jake > ________________________________ > From: Konstantin Aladyshev > Sent: Tuesday, December 13, 2022 11:22 AM > To: devel@edk2.groups.io > Cc: bob.c.feng@intel.com ; gaoliming@byosoft.com.cn ; yuwei.chen@intel.com ; Jake Garver ; Konstantin Aladyshev > Subject: [PATCH] Fix cyclic dependency error on OptionROM build > > External email: Use caution opening links or attachments > > > EDKII build system supports OptionROM generation if particular PCI_* > defines are present in the module INF file: > ``` > [Defines] > ... > PCI_VENDOR_ID = <...> > PCI_DEVICE_ID = <...> > PCI_CLASS_CODE = <...> > PCI_REVISION = <...> > ``` > Although after the commit d372ab585a2cdc5348af5f701c56c631235fe698 > ("BaseTools/Conf: Fix Dynamic-Library-File template") it is no longer > possible. > The build system fails with the error: > ``` > Cyclic dependency detected while generating rule for > "<...>/DEBUG/<...>.efi" file > ``` > Remove "$(DEBUG_DIR)(+)$(MODULE_NAME).efi" from the 'dll' output files > to fix the cyclic dependency. > --- > BaseTools/Conf/build_rule.template | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/BaseTools/Conf/build_rule.template b/BaseTools/Conf/build_rule.template > index af4819de92..21ccd864fa 100755 > --- a/BaseTools/Conf/build_rule.template > +++ b/BaseTools/Conf/build_rule.template > @@ -342,7 +342,6 @@ > > > > > $(OUTPUT_DIR)(+)$(MODULE_NAME).efi > > - $(DEBUG_DIR)(+)$(MODULE_NAME).efi > > $(OUTPUT_DIR)(+)$(MODULE_NAME).map > > > > > > -- > 2.34.1 >