From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) by mx.groups.io with SMTP id smtpd.web10.47226.1670861269512222511 for ; Mon, 12 Dec 2022 08:07:49 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20210112 header.b=cRsdKTnK; spf=pass (domain: gmail.com, ip: 209.85.221.42, mailfrom: aladyshev22@gmail.com) Received: by mail-wr1-f42.google.com with SMTP id h16so3634506wrz.12 for ; Mon, 12 Dec 2022 08:07:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=mj8wwERHXUQkkHnl2UXmGLZpXS27marSYW3e21KKLTo=; b=cRsdKTnK3y1eOlMGPPuMdnBTtC30jDj1R2mckP9B06ZJMc1Z/Zrp3bsiwEdlJPoOnF 56R6mZo051suuX/Vfkmo/4eDDkHrujdBcnPpzpy1hNy+0Ds8hc5lpElAHQuRDFY+aDG9 oV95idoBiUSgx0WC0Qgw5PFnWIKjtFjpN6gLm4EjQuMLB0p5S6zn0agViPRREGp17+/v J4fpxmaHbDw8AewT+qOn8D4hOv1fDjOqTaV7Zh/iD94z3Bgl/Z2EtrMe6KWoUf1O6/Y7 fyELHBUungpfPgvBmcpO6HeiG4sdAy6ItjfLdoyMQ5PfOPxxHqH8DSyDU1MZeO7o1SLR PwAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=mj8wwERHXUQkkHnl2UXmGLZpXS27marSYW3e21KKLTo=; b=JlnCx2S+Mb29QbkIZMxq0hTBWh1c+dAgmOeOV/1o5JnPUO8r6sRmbvsmTd0Wil4dSp cWRN7DshiQPF+WKQXctH4ysTVcqZ+39HB3aFMhFZ3cQnT9AgIGpeD1dAHYgxmqRJJmGW IL7CyyXoe0OIGFunzpTNKH8Z6EAwe7uDRMyRgAYHPN0c4hYxXXBiSDyqanUu+ugSnpP0 1X6herMLRqSUpbVD0EhedHzshb+PgHH8o5WBOLoi1WM8yw4SQd3poY3T7YOIj7u7uV7d 6VOUDEojCXO1cUHcxutFIqyoFYhaf1w3VuGjJKAbrbdBI+QbXeP18L5NKCio8Qr3c4EM JDng== X-Gm-Message-State: ANoB5pmGVygd8v0J9J5UMYPRFrKjDHaC1lYq5ZGwCok4hYADIhUzHMk8 IgbRfoYSwaO8dLnwcm/9t1wbDV56yxe+rkvtii4= X-Google-Smtp-Source: AA0mqf5dj1KJYZX4QowMYzrltk7FROCsruwA6FQ5GmZwNDRl5tbrbRl+rtPBL0pUJO7rW2adI9M7YP3fPdYQSpcG3TE= X-Received: by 2002:a5d:63d1:0:b0:242:1d01:16fd with SMTP id c17-20020a5d63d1000000b002421d0116fdmr27002892wrw.682.1670861267726; Mon, 12 Dec 2022 08:07:47 -0800 (PST) MIME-Version: 1.0 References: <20221212130924.8156-1-aladyshev22@gmail.com> In-Reply-To: From: "Konstantin Aladyshev" Date: Mon, 12 Dec 2022 19:07:36 +0300 Message-ID: Subject: Re: [PATCH] Revert "BaseTools/Conf: Fix Dynamic-Library-File template" To: Jake Garver Cc: "devel@edk2.groups.io" , "bob.c.feng@intel.com" , "gaoliming@byosoft.com.cn" , "yuwei.chen@intel.com" Content-Type: text/plain; charset="UTF-8" Hi, Jake! No, unfortunately I don't have any way to fix this, besides the patch revert. To reproduce the issue you can add the mentioned PCI_* defines to some simple DXE_DRIVER. For example: SimpleDriver/SimpleDriver.inf ``` [Defines] INF_VERSION = 1.25 BASE_NAME = SimpleDriver FILE_GUID = 384aeb18-105d-4af1-bf17-5e349e8f4d4c MODULE_TYPE = UEFI_DRIVER VERSION_STRING = 1.0 ENTRY_POINT = SimpleDriverEntryPoint UNLOAD_IMAGE = SimpleDriverUnload PCI_VENDOR_ID = 0x1234 PCI_DEVICE_ID = 0x5678 PCI_CLASS_CODE = 0x0001 PCI_REVISION = 0x0002 [Sources] SimpleDriver.c [Packages] MdePkg/MdePkg.dec [LibraryClasses] UefiDriverEntryPoint UefiLib ``` SimpleDriver/SimpleDriver.c ``` #include #include EFI_STATUS EFIAPI SimpleDriverUnload ( EFI_HANDLE ImageHandle ) { return EFI_SUCCESS; } EFI_STATUS EFIAPI SimpleDriverEntryPoint ( IN EFI_HANDLE ImageHandle, IN EFI_SYSTEM_TABLE *SystemTable ) { return EFI_SUCCESS; } ``` It is enough to reproduce the issue. Normally the build system should compile the driver code fine and then call the EfiRom utility to produce the OptionROM image. But with the d372ab585a2cdc5348af5f701c56c631235fe698 in place the driver build fails. Best regards, Konstantin Aladyshev On Mon, Dec 12, 2022 at 6:35 PM Jake Garver wrote: > > Hi, Konstantin, > > Do you have a fix for the cyclic redundancy issue when building OptionROMs? If not, can you help me reproduce it? > > I'd hate to revert d372ab as it fixed dependency issues we frequently ran into during parallel builds. > > Thanks, > Jake > ________________________________ > From: Konstantin Aladyshev > Sent: Monday, December 12, 2022 8:09 AM > To: devel@edk2.groups.io > Cc: bob.c.feng@intel.com ; gaoliming@byosoft.com.cn ; yuwei.chen@intel.com ; Jake Garver ; Konstantin Aladyshev > Subject: [PATCH] Revert "BaseTools/Conf: Fix Dynamic-Library-File template" > > External email: Use caution opening links or attachments > > > Revert commit d372ab585a2cdc5348af5f701c56c631235fe698. > > EdkII build system supports OptionROM generation if particular PCI_* > defines are present in the module INF file: > ``` > [Defines] > ... > PCI_VENDOR_ID = <...> > PCI_DEVICE_ID = <...> > PCI_CLASS_CODE = <...> > PCI_REVISION = <...> > ``` > Although after the commit d372ab585a2cdc5348af5f701c56c631235fe698 > it is no longer possible. > The build system fails with the error: > ``` > Cyclic dependency detected while generating rule for > "<...>/DEBUG/<...>.efi" file > ``` > Revert d372ab585a2cdc5348af5f701c56c631235fe698 until the issue > is resolved. > --- > BaseTools/Conf/build_rule.template | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/BaseTools/Conf/build_rule.template b/BaseTools/Conf/build_rule.template > index af4819de92..32053f6353 100755 > --- a/BaseTools/Conf/build_rule.template > +++ b/BaseTools/Conf/build_rule.template > @@ -342,8 +342,6 @@ > > > > > $(OUTPUT_DIR)(+)$(MODULE_NAME).efi > > - $(DEBUG_DIR)(+)$(MODULE_NAME).efi > > - $(OUTPUT_DIR)(+)$(MODULE_NAME).map > > > > > > "$(GENFW)" -e $(MODULE_TYPE) -o ${dst} ${src} $(GENFW_FLAGS) > > -- > 2.34.1 >