From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f182.google.com (mail-yw1-f182.google.com [209.85.128.182]) by mx.groups.io with SMTP id smtpd.web09.4771.1663834992335493360 for ; Thu, 22 Sep 2022 01:23:12 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20210112 header.b=qbNuwNVc; spf=pass (domain: gmail.com, ip: 209.85.128.182, mailfrom: aladyshev22@gmail.com) Received: by mail-yw1-f182.google.com with SMTP id 00721157ae682-345528ceb87so90417087b3.11 for ; Thu, 22 Sep 2022 01:23:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date; bh=B9+XamVRkhyeR65Q3DCHoq4mPmxl+jD2ooOBKyY5eLo=; b=qbNuwNVcEtk48mIx03AsDA09fTpTxOEjNK/BXOJIJFSercRHCC47+Vh+vhwdbKGTMI nIpuSU7wGgH8zWu3T0OeYKcM3lHU74fo8ytXyRSNGfBX+6g4yHY2ph/Bz2Z6QImBcxyW 2q/PIczOzgSQjhNQDWZfMamnItBXD8nMogVvT2+f7hEwqcp3KhyI2A9qlXQFyI5+GP1X tNjHP8mzrA6/3cqkbhT6HVSaSKmFBjH03/0guf/Lxxs7Taa8LR1d8+JRAWTwNAtkrRBJ XpnEz8LCUfUR164jkRL5FvQebyfn7cA+ltwErZXXFQzXY8dOqnAgB8lE3TTw6W5Gvl6j AGlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date; bh=B9+XamVRkhyeR65Q3DCHoq4mPmxl+jD2ooOBKyY5eLo=; b=ZTSXkghOmkgr0LlLox1sFNLNHUckOaAEJnN1annEh2+PV25g4c+442YKiMuvain/jy Q2PscldDlzz0doIDiTeD+JkaMtT8ufC874izZ0WKIm/6LgVOY9XmuM/wjHDME7cvL5c3 0zp/pSrbUW8sbPebCfvcx3WO3/exsvn5TUmTZW8iMwyLZv3YovawIj0wEjyz3uFH438D VZPFwBFo0rjerz5mpmzp+VIRjKdjfqoWshoEdqYvx6/PAkHRkE9XMo0yiMxeVwtptwho uiFQjcyrRF7KJfIJf7qxv08qdXL6KvOoCIlMsEFZi0XeWS7ZTWnmb3j5wTtjpvkonAly DnVQ== X-Gm-Message-State: ACrzQf32jgsBXyOrmcKAUjs80DRUB7HnbaWUjhkSUkz/99ieEdYZ0jzb WvXAFa7ShP+wG06ueZb+oeP+ouXE+YxF7kwM+tT8NbzahgY= X-Google-Smtp-Source: AMsMyM7yITnfo5iFIdAKZQ4XaAztcCVwF78OPnk6UfXQ6R8TyDqE12SVy3Xz6XgENHBsglLgpFm2q5EpBqKBe2VLCx0= X-Received: by 2002:a81:48d5:0:b0:348:81c3:83c7 with SMTP id v204-20020a8148d5000000b0034881c383c7mr1866623ywa.301.1663834991443; Thu, 22 Sep 2022 01:23:11 -0700 (PDT) MIME-Version: 1.0 References: <20220919085633.27707-1-aladyshev22@gmail.com> <007e01d8cd59$0ff88bc0$2fe9a340$@byosoft.com.cn> In-Reply-To: From: "Konstantin Aladyshev" Date: Thu, 22 Sep 2022 11:23:00 +0300 Message-ID: Subject: Re: [edk2-devel] [PATCH] MdeModulePkg/TerminalDxe: add modes To: "Kinney, Michael D" Cc: "devel@edk2.groups.io" , "Gao, Liming" , "Wang, Jian J" , "Ni, Ray" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable > Is the issue that you are trying to solve supporting larger serial consol= e modes or just wanting to use the largest possible text mode at a given gr= aphics resolution? I spotted this issue when I wanted to use the largest possible text mode in UEFI shell at high graphics resolutions. Is it not enough reason for this commit? > The other way to get full screen text on the graphical console is to disa= ble the serial console in the Boot Maintenance Manager. Can you please elaborate this? I've tried to disable UART in "Boot Maintenance Manager -> Console Options" like this: ``` Console Input Device Select: PciRoot(0x0)/Pci(0x1,0x0)/Acpi(PNP0303,0x0) [X] PciRoot(0x0)/Pci(0x1,0x0)/Serial(0x0)/Uart(115200,8,N,1) [ ] Console Output Device Select: PciRoot(0x0)/Pci(0x2,0x0)/AcpiAdr(0x80010100) [X] PciRoot(0x0)/Pci(0x1,0x0)/Serial(0x0)/Uart(115200,8,N,1) [ ] Console Standard Error Device Select: PciRoot(0x0)/Pci(0x2,0x0)/AcpiAdr(0x80010100) [X] PciRoot(0x0)/Pci(0x1,0x0)/Serial(0x0)/Uart(115200,8,N,1) [ ] ``` But after reset, the console is 80x25 and all UART options are checked agai= n. Also there is a menu "Boot Maintenance Manager -> Console Options -> Console Output Mode Select" that has "Set Console Output Mode", and it is always "80x25" without any options for me. Best regards, Konstantin Aladyshev On Wed, Sep 21, 2022 at 7:28 PM Kinney, Michael D wrote: > > The other way to get full screen text on graphical console is to disable = the serial console > in the Boot Maintenance Manager. > > If the serial console is disabled then ConSplitterDxe will only see the t= ext modes supported > by GraphicsConsoleDxe which will include these higher text modes. > > Is the issue that you are trying to solve supporting larger serial consol= e modes or just > wanting to use the largest possible text mode at a given graphics resolut= ion? > > Mike > > > -----Original Message----- > > From: devel@edk2.groups.io On Behalf Of Konstant= in Aladyshev > > Sent: Wednesday, September 21, 2022 1:24 AM > > To: Kinney, Michael D > > Cc: devel@edk2.groups.io; Gao, Liming ; Wang,= Jian J ; Ni, Ray > > > > Subject: Re: [edk2-devel] [PATCH] MdeModulePkg/TerminalDxe: add modes > > > > I have tested it in the following way: > > - launch OVMF in Linux and connect with vnc > > - change resolution via the form browser (Device Manager -> OVMF > > Platform Configuration) from the default 640x480 to the 1920x1080 > > - "reset" > > - after the reset the system will boot to the 1920x1080 resolution and > > text mode 80x25 > > - check "mode" command output > > > > Before the commit this command displays only these modes: > > ``` > > Shell> mode > > Available modes for console output device. > > Col 80 Row 25 * > > Col 80 Row 50 > > Col 100 Row 31 > > ``` > > But with this commit the high resolution modes are present in the outpu= t: > > ``` > > Shell> mode > > Available modes for console output device. > > Col 80 Row 25 * > > Col 80 Row 50 > > Col 100 Row 31 > > Col 128 Row 40 > > Col 160 Row 42 > > Col 240 Row 56 > > ``` > > And in my case setting the appropriate "mode 240 56" at runtime works j= ust fine: > > ``` > > Shell> mode 240 56 > > ``` > > After that the text output starts using the full screen. > > > > Best regards, > > Konstantin Aladyshev > > > > On Wed, Sep 21, 2022 at 4:46 AM Kinney, Michael D > > wrote: > > > > > > Tera Term works. > > > > > > Mike > > > > > > > -----Original Message----- > > > > From: devel@edk2.groups.io On Behalf Of gaol= iming via groups.io > > > > Sent: Tuesday, September 20, 2022 6:26 PM > > > > To: Kinney, Michael D ; devel@edk2.grou= ps.io; aladyshev22@gmail.com > > > > Cc: Wang, Jian J ; Ni, Ray > > > > Subject: =E5=9B=9E=E5=A4=8D: [edk2-devel] [PATCH] MdeModulePkg/Term= inalDxe: add modes > > > > > > > > Konstantin: > > > > Do you try the terminal software (such as Putty) to display the t= ext mode 160, 42 or 240, 56? > > > > I try Putty in my desktop. It can't display 240 * 56 in one scree= n. > > > > > > > > Thanks > > > > Liming > > > > > -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- > > > > > =E5=8F=91=E4=BB=B6=E4=BA=BA: Kinney, Michael D > > > > > =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2022=E5=B9=B49=E6=9C=8820= =E6=97=A5 5:02 > > > > > =E6=94=B6=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io; aladyshev22@gm= ail.com; Kinney, Michael D > > > > > > > > > > =E6=8A=84=E9=80=81: Wang, Jian J ; Gao, Li= ming > > > > > ; Ni, Ray > > > > > =E4=B8=BB=E9=A2=98: RE: [edk2-devel] [PATCH] MdeModulePkg/Termina= lDxe: add modes > > > > > > > > > > This looks like a reasonable update to support platforms that hav= e both > > > > > graphical consoles and serial consoles. > > > > > > > > > > Reviewed-by: Michael D Kinney > > > > > > > > > > > > > > > > -----Original Message----- > > > > > > From: devel@edk2.groups.io On Behalf Of > > > > > Konstantin Aladyshev > > > > > > Sent: Monday, September 19, 2022 1:57 AM > > > > > > To: devel@edk2.groups.io > > > > > > Cc: Wang, Jian J ; Gao, Liming > > > > > ; Ni, Ray ; Konstanti= n > > > > > > Aladyshev > > > > > > Subject: [edk2-devel] [PATCH] MdeModulePkg/TerminalDxe: add mod= es > > > > > > > > > > > > The commit b807174fecacf4c9f8400cab4d6fb3f580284021 > > > > > > ("MdeModulePkg/GraphicsConsoleDxe: add modes") has added modes = for > > > > > the > > > > > > high display resolutions. Support these modes in the TerminalDx= e as > > > > > > well, so it would be possible to select the text mode that woul= d take > > > > > > all the available screen space. > > > > > > > > > > > > Signed-off-by: Konstantin Aladyshev > > > > > > --- > > > > > > MdeModulePkg/Universal/Console/TerminalDxe/Terminal.c | 3 +++ > > > > > > 1 file changed, 3 insertions(+) > > > > > > > > > > > > diff --git a/MdeModulePkg/Universal/Console/TerminalDxe/Termina= l.c > > > > > b/MdeModulePkg/Universal/Console/TerminalDxe/Terminal.c > > > > > > index e2d779c783..6b7b970516 100644 > > > > > > --- a/MdeModulePkg/Universal/Console/TerminalDxe/Terminal.c > > > > > > +++ b/MdeModulePkg/Universal/Console/TerminalDxe/Terminal.c > > > > > > @@ -115,6 +115,9 @@ TERMINAL_CONSOLE_MODE_DATA > > > > > mTerminalConsoleModeData[] =3D { > > > > > > { 80, 25 }, > > > > > > > > > > > > { 80, 50 }, > > > > > > > > > > > > { 100, 31 }, > > > > > > > > > > > > + { 128, 40 }, > > > > > > > > > > > > + { 160, 42 }, > > > > > > > > > > > > + { 240, 56 }, > > > > > > > > > > > > // > > > > > > > > > > > > // New modes can be added here. > > > > > > > > > > > > // > > > > > > > > > > > > -- > > > > > > 2.25.1 > > > > > > > > > > > > > > > > > > > > > > > > -=3D-=3D-=3D-=3D-=3D-=3D > > > > > > Groups.io Links: You receive all messages sent to this group. > > > > > > View/Reply Online (#93935): > > > > > https://edk2.groups.io/g/devel/message/93935 > > > > > > Mute This Topic: https://groups.io/mt/93777396/1643496 > > > > > > Group Owner: devel+owner@edk2.groups.io > > > > > > Unsubscribe: https://edk2.groups.io/g/devel/unsub > > > > > [michael.d.kinney@intel.com] > > > > > > -=3D-=3D-=3D-=3D-=3D-=3D > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > >=20 > > >