Re: [edk2-devel] [PATCH] MdeModulePkg/TerminalDxe: add modes

["Konstantin Aladyshev" <aladyshev22@gmail.com>]

I have tested it in the following way:
- launch OVMF in Linux and connect with vnc
- change resolution via the form browser (Device Manager -> OVMF
Platform Configuration) from the default 640x480 to the 1920x1080
- "reset"
- after the reset the system will boot to the 1920x1080 resolution and
text mode 80x25
- check "mode" command output

Before the commit this command displays only these modes:
```
Shell> mode
Available modes for console output device.
  Col    80 Row    25  *
  Col    80 Row    50
  Col   100 Row    31
```
But with this commit the high resolution modes are present in the output:
```
Shell> mode
Available modes for console output device.
  Col    80 Row    25  *
  Col    80 Row    50
  Col   100 Row    31
  Col   128 Row    40
  Col   160 Row    42
  Col   240 Row    56
```
And in my case setting the appropriate "mode 240 56" at runtime works just fine:
```
Shell> mode 240 56
```
After that the text output starts using the full screen.

Best regards,
Konstantin Aladyshev

On Wed, Sep 21, 2022 at 4:46 AM Kinney, Michael D
<michael.d.kinney@intel.com> wrote:
>
> Tera Term works.
>
> Mike
>
> > -----Original Message-----
> > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of gaoliming via groups.io
> > Sent: Tuesday, September 20, 2022 6:26 PM
> > To: Kinney, Michael D <michael.d.kinney@intel.com>; devel@edk2.groups.io; aladyshev22@gmail.com
> > Cc: Wang, Jian J <jian.j.wang@intel.com>; Ni, Ray <ray.ni@intel.com>
> > Subject: 回复: [edk2-devel] [PATCH] MdeModulePkg/TerminalDxe: add modes
> >
> > Konstantin:
> >   Do you try the terminal software (such as Putty) to display the text mode 160, 42 or 240, 56?
> >   I try Putty in my desktop. It can't display 240 * 56 in one screen.
> >
> > Thanks
> > Liming
> > > -----邮件原件-----
> > > 发件人: Kinney, Michael D <michael.d.kinney@intel.com>
> > > 发送时间: 2022年9月20日 5:02
> > > 收件人: devel@edk2.groups.io; aladyshev22@gmail.com; Kinney, Michael D
> > > <michael.d.kinney@intel.com>
> > > 抄送: Wang, Jian J <jian.j.wang@intel.com>; Gao, Liming
> > > <gaoliming@byosoft.com.cn>; Ni, Ray <ray.ni@intel.com>
> > > 主题: RE: [edk2-devel] [PATCH] MdeModulePkg/TerminalDxe: add modes
> > >
> > > This looks like a reasonable update to support platforms that have both
> > > graphical consoles and serial consoles.
> > >
> > > Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
> > >
> > >
> > > > -----Original Message-----
> > > > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> > > Konstantin Aladyshev
> > > > Sent: Monday, September 19, 2022 1:57 AM
> > > > To: devel@edk2.groups.io
> > > > Cc: Wang, Jian J <jian.j.wang@intel.com>; Gao, Liming
> > > <gaoliming@byosoft.com.cn>; Ni, Ray <ray.ni@intel.com>; Konstantin
> > > > Aladyshev <aladyshev22@gmail.com>
> > > > Subject: [edk2-devel] [PATCH] MdeModulePkg/TerminalDxe: add modes
> > > >
> > > > The commit b807174fecacf4c9f8400cab4d6fb3f580284021
> > > > ("MdeModulePkg/GraphicsConsoleDxe: add modes") has added modes for
> > > the
> > > > high display resolutions. Support these modes in the TerminalDxe as
> > > > well, so it would be possible to select the text mode that would take
> > > > all the available screen space.
> > > >
> > > > Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>
> > > > ---
> > > >  MdeModulePkg/Universal/Console/TerminalDxe/Terminal.c | 3 +++
> > > >  1 file changed, 3 insertions(+)
> > > >
> > > > diff --git a/MdeModulePkg/Universal/Console/TerminalDxe/Terminal.c
> > > b/MdeModulePkg/Universal/Console/TerminalDxe/Terminal.c
> > > > index e2d779c783..6b7b970516 100644
> > > > --- a/MdeModulePkg/Universal/Console/TerminalDxe/Terminal.c
> > > > +++ b/MdeModulePkg/Universal/Console/TerminalDxe/Terminal.c
> > > > @@ -115,6 +115,9 @@ TERMINAL_CONSOLE_MODE_DATA
> > > mTerminalConsoleModeData[] = {
> > > >    { 80,  25 },
> > > >
> > > >    { 80,  50 },
> > > >
> > > >    { 100, 31 },
> > > >
> > > > +  { 128, 40 },
> > > >
> > > > +  { 160, 42 },
> > > >
> > > > +  { 240, 56 },
> > > >
> > > >    //
> > > >
> > > >    // New modes can be added here.
> > > >
> > > >    //
> > > >
> > > > --
> > > > 2.25.1
> > > >
> > > >
> > > >
> > > > -=-=-=-=-=-=
> > > > Groups.io Links: You receive all messages sent to this group.
> > > > View/Reply Online (#93935):
> > > https://edk2.groups.io/g/devel/message/93935
> > > > Mute This Topic: https://groups.io/mt/93777396/1643496
> > > > Group Owner: devel+owner@edk2.groups.io
> > > > Unsubscribe: https://edk2.groups.io/g/devel/unsub
> > > [michael.d.kinney@intel.com]
> > > > -=-=-=-=-=-=
> > > >
> >
> >
> >
> >
> >
> > 
> >
>