From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-vk1-f171.google.com (mail-vk1-f171.google.com [209.85.221.171]) by mx.groups.io with SMTP id smtpd.web11.191869.1673943824463385688 for ; Tue, 17 Jan 2023 00:23:44 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20210112 header.b=iZETFH9A; spf=pass (domain: gmail.com, ip: 209.85.221.171, mailfrom: aladyshev22@gmail.com) Received: by mail-vk1-f171.google.com with SMTP id e132so4116161vke.11 for ; Tue, 17 Jan 2023 00:23:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=c3BdkQUXNVMQQzNkMNnFWMN44buQDqf+SIYJR6tYZqA=; b=iZETFH9As/DFc+8xLLfaO1yYfXaN149lEGFI9t4gWzSQiXZCMjqUma5BDe/irZQnqi vZGRoF67puoTyIzwn/4/xPHI2wykHFVuvgmyPf4ZxHFsA3dH2dv/AbnPs+SsDlEvZ8k1 XtkEvZ54nl27+TEIz7GnhyP0hrhfCW5qqkOrOiaxDM2qfG9YyxOK/vFqDkrHnB3kP8xu pofV10AfLxija0Byx8GT8AvVZ0JwaYapaP6twpVwJ7ChxFgEfq38v1oJO+xPDraa6m9/ mpGZb+hTf4OHDdyTIXJ5OY3VQSaxuAON7wiOdr+kxoxLA80cGnN5iJRNCDO2Dk07DVFq ctfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=c3BdkQUXNVMQQzNkMNnFWMN44buQDqf+SIYJR6tYZqA=; b=K8G3Wo1FTQdbHkITJF+QMD/9+zLD3OsXCl1eev1Ojw3vLL/I1HzBYfk5jMa4TcXf// FoneyofxAnI38WhST7SmLxsHBsoKbx1j4+SCrQJUXnpZ/3jxDCV+d8PdIkjbwZErBtlO fCImRs7p+DbbXEa67sQaOIt/IK5X/KVRgAU5zs9o7jYGKfNgXEtmrMvZ70m1yF0DJfue WK8elkhzfiiweNfIQt4YQgPAyukNrWar1T78hDRgsaATtrk76hRtLG1QFXiKWXZJZvxk rUAZSgqiz46ZShnTM/XvQ1Lvkpb6ZBTXhgHhGBMqdwti8nCMrwBp3olK6g4tvPwcbf3n IbTQ== X-Gm-Message-State: AFqh2kp1B05aZO/BmgpLsWpwGND9QQU6w55F9h+SN/aZvJruO6Idpi7i i1wKctWZQAavHVXkOMGx4RhQlJHGoZAMJ0/nTj0= X-Google-Smtp-Source: AMrXdXvmF8mKMRdSEbzD5FwrElGhaExfIxqTbPPOB74mFGhrYr78ytiw41GisTL9yaPKtsw/iEizGxRNDKd5KMxCSgo= X-Received: by 2002:a1f:2441:0:b0:3bc:cbd6:4778 with SMTP id k62-20020a1f2441000000b003bccbd64778mr294224vkk.18.1673943823397; Tue, 17 Jan 2023 00:23:43 -0800 (PST) MIME-Version: 1.0 References: <20221212130924.8156-1-aladyshev22@gmail.com> <20221213162222.590-1-aladyshev22@gmail.com> <173B00341150B4F6.23170@groups.io> In-Reply-To: From: "Konstantin Aladyshev" Date: Tue, 17 Jan 2023 11:23:32 +0300 Message-ID: Subject: Re: [edk2-devel] [PATCH] Fix cyclic dependency error on OptionROM build To: "Feng, Bob C" Cc: "devel@edk2.groups.io" , Jake Garver , "Gao, Liming" , "Chen, Christine" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Thanks, Bob! Sorry, somehow I've missed it. Has EDK2 moved to the GitHub PR system instead of a mailing list for patche= s? Do I need to open PR for my subsequent patches, or just send them to the mailing list like before? Best regards, Konstatin Aladyshev On Tue, Jan 17, 2023 at 8:17 AM Feng, Bob C wrote: > > Konstantin, > > > > The patch missed =E2=80=9CSigned-off-by:=E2=80=9D, I help you add it and = open a PR https://github.com/tianocore/edk2/pull/3909 for merge. > > > > Thanks, > > Bob > > From: devel@edk2.groups.io On Behalf Of Bob Feng > Sent: Tuesday, January 17, 2023 1:05 PM > To: Jake Garver ; Konstantin Aladyshev ; devel@edk2.groups.io > Cc: Gao, Liming ; Chen, Christine > Subject: Re: [edk2-devel] [PATCH] Fix cyclic dependency error on OptionRO= M build > > > > Reviewed-by: Bob Feng > > > > From: Jake Garver > Sent: Wednesday, December 14, 2022 2:48 AM > To: Konstantin Aladyshev ; devel@edk2.groups.io > Cc: Feng, Bob C ; Gao, Liming ; Chen, Christine > Subject: Re: [PATCH] Fix cyclic dependency error on OptionROM build > > > > Thanks, Konstantin, > > > > I approve this version. > > > > Thanks, > > Jake > > ________________________________ > > From: Konstantin Aladyshev > Sent: Tuesday, December 13, 2022 11:22 AM > To: devel@edk2.groups.io > Cc: bob.c.feng@intel.com ; gaoliming@byosoft.com.cn= ; yuwei.chen@intel.com ; J= ake Garver ; Konstantin Aladyshev > Subject: [PATCH] Fix cyclic dependency error on OptionROM build > > > > External email: Use caution opening links or attachments > > > EDKII build system supports OptionROM generation if particular PCI_* > defines are present in the module INF file: > ``` > [Defines] > ... > PCI_VENDOR_ID =3D <...> > PCI_DEVICE_ID =3D <...> > PCI_CLASS_CODE =3D <...> > PCI_REVISION =3D <...> > ``` > Although after the commit d372ab585a2cdc5348af5f701c56c631235fe698 > ("BaseTools/Conf: Fix Dynamic-Library-File template") it is no longer > possible. > The build system fails with the error: > ``` > Cyclic dependency detected while generating rule for > "<...>/DEBUG/<...>.efi" file > ``` > Remove "$(DEBUG_DIR)(+)$(MODULE_NAME).efi" from the 'dll' output files > to fix the cyclic dependency. > --- > BaseTools/Conf/build_rule.template | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/BaseTools/Conf/build_rule.template b/BaseTools/Conf/build_ru= le.template > index af4819de92..21ccd864fa 100755 > --- a/BaseTools/Conf/build_rule.template > +++ b/BaseTools/Conf/build_rule.template > @@ -342,7 +342,6 @@ > > > > > $(OUTPUT_DIR)(+)$(MODULE_NAME).efi > > - $(DEBUG_DIR)(+)$(MODULE_NAME).efi > > $(OUTPUT_DIR)(+)$(MODULE_NAME).map > > > > > > -- > 2.34.1 > >=20