From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yb1-f171.google.com (mail-yb1-f171.google.com [209.85.219.171]) by mx.groups.io with SMTP id smtpd.web09.1287.1663865392198378584 for ; Thu, 22 Sep 2022 09:49:52 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20210112 header.b=BNe94vJD; spf=pass (domain: gmail.com, ip: 209.85.219.171, mailfrom: aladyshev22@gmail.com) Received: by mail-yb1-f171.google.com with SMTP id 63so13670394ybq.4 for ; Thu, 22 Sep 2022 09:49:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date; bh=csPoPQI/eqx3qImMaS0Tlpk+4eKWRQ4NBaqz20fUC+4=; b=BNe94vJDmFc+/sM81sk00uOOhB1NBSXdBPB7xxdAO22CKNFINSqxbNhmm2GNMWimYU KzjY+bmCjN0DLEKfR5p+DjodGSM/maFdivIQtBkCE1kAAq7sF846W72C/FBog5NIzeKx jGHPQ/eOk1MNEqRWwaXF3kI+xfU9H24+504TuZ8WQeciarIPKv0uH50SYsyIFm4pK118 bMgfua4aytNjlkRsDNua4QnJso18tL1VcZvZp5yTDNkD/4jVb9KluStMnI1mwARmjd5p AWRE9DURPpx8maYPrnWSOOmjUGJy52t5MGIHGEZ+3nDtRHkm7F4ZmveSlCRDYUIRW2RE wzUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date; bh=csPoPQI/eqx3qImMaS0Tlpk+4eKWRQ4NBaqz20fUC+4=; b=HJsI2EiaRhaOAwRHNeqylLm/ZD2crxAjOU7NXmL+uGnsv/GiXA5aMgPypShHcmNaMc lO4UH3JBkZCK8iAyRn9Qhjuf9FVnGDEta8TCIxiDsSN5zv7Sa89nIMZqPwLevlUoMVrF YGzUIVHBtGLLz/NRvuJWJiljTOBdXedaNoUsG3HDC1AgrSGFZdYLxKzGsKVHiganUFYn olGm8jt8F3Z1EIgH7J/ssVWgFH/P/1ad88ONW7uSdiib6KpKsrvH6SiCCbKuLRM2a7pw RwTQyQ8e+/hmJX4+F6Axsw6+SwymjDX7ZA4yktVgnJ087uEftp+nKqP6+KgnuvzmIjci e2ug== X-Gm-Message-State: ACrzQf3Wei9H67JnZn2EEr58DVD3uTCmAFjVG8g24Yq9pahk5Yts81o8 KhmumrPPwadeViW0s0IydAS5EJU06LA9J3V77ns= X-Google-Smtp-Source: AMsMyM6GWdbJfdOUkG9curO4vHk1O3cUwXZJhGI/MEuBR+p3RVVrYPtPkN6BC/9jVWz64N+aPCihR1qdDmxps5DZ1Hc= X-Received: by 2002:a25:d4e:0:b0:6ae:a4d0:4c8f with SMTP id 75-20020a250d4e000000b006aea4d04c8fmr5122704ybn.336.1663865391314; Thu, 22 Sep 2022 09:49:51 -0700 (PDT) MIME-Version: 1.0 References: <20220919085633.27707-1-aladyshev22@gmail.com> <007e01d8cd59$0ff88bc0$2fe9a340$@byosoft.com.cn> In-Reply-To: From: "Konstantin Aladyshev" Date: Thu, 22 Sep 2022 19:49:39 +0300 Message-ID: Subject: Re: [edk2-devel] [PATCH] MdeModulePkg/TerminalDxe: add modes To: "Kinney, Michael D" Cc: "devel@edk2.groups.io" , "Gao, Liming" , "Wang, Jian J" , "Ni, Ray" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Yes, I use QEMU to run OVMF in Linux (actually in WSL). Here is a command that I use for launch: ``` qemu-system-x86_64 \ -drive if=3Dpflash,format=3Draw,file=3DBuild/OvmfX64/RELEASE_GCC5/FV/OVMF= .fd \ -drive format=3Draw,file=3Dfat:rw:~/UEFI_disk -vnc :1 ``` So nothing explicit about the UARTs. Best regards, Konstantin Aladyshev On Thu, Sep 22, 2022 at 7:12 PM Kinney, Michael D wrote: > > If the goal is to support a mix of graphical and serial consoles both wit= h high text resolutions, then your patch is appropriate. > > It looks like you are observing some unexpected limitations in the OVMF c= onsole management. > > Perhaps the OVMF maintainers can provide some advice on how to configure = OVMF with serial consoles disabled. > > Are you using QEMU to run OVMF? Are you including UARTs in QEMU launch? > > Mike > > > -----Original Message----- > > From: Konstantin Aladyshev > > Sent: Thursday, September 22, 2022 1:23 AM > > To: Kinney, Michael D > > Cc: devel@edk2.groups.io; Gao, Liming ; Wang,= Jian J ; Ni, Ray > > > > Subject: Re: [edk2-devel] [PATCH] MdeModulePkg/TerminalDxe: add modes > > > > > Is the issue that you are trying to solve supporting larger serial co= nsole modes or just wanting to use the largest possible > > text mode at a given graphics resolution? > > > > I spotted this issue when I wanted to use the largest possible text > > mode in UEFI shell at high graphics resolutions. Is it not enough > > reason for this commit? > > > > > The other way to get full screen text on the graphical console is to = disable the serial console in the Boot Maintenance > > Manager. > > > > Can you please elaborate this? I've tried to disable UART in "Boot > > Maintenance Manager -> Console Options" like this: > > ``` > > Console Input Device Select: > > PciRoot(0x0)/Pci(0x1,0x0)/Acpi(PNP0303,0x0) [X] > > PciRoot(0x0)/Pci(0x1,0x0)/Serial(0x0)/Uart(115200,8,N,1) [ ] > > > > Console Output Device Select: > > PciRoot(0x0)/Pci(0x2,0x0)/AcpiAdr(0x80010100) [X] > > PciRoot(0x0)/Pci(0x1,0x0)/Serial(0x0)/Uart(115200,8,N,1) [ ] > > > > Console Standard Error Device Select: > > PciRoot(0x0)/Pci(0x2,0x0)/AcpiAdr(0x80010100) [X] > > PciRoot(0x0)/Pci(0x1,0x0)/Serial(0x0)/Uart(115200,8,N,1) [ ] > > ``` > > But after reset, the console is 80x25 and all UART options are checked = again. > > > > Also there is a menu "Boot Maintenance Manager -> Console Options -> > > Console Output Mode Select" that has "Set Console Output Mode", and it > > is always "80x25" without any options for me. > > > > Best regards, > > Konstantin Aladyshev > > > > On Wed, Sep 21, 2022 at 7:28 PM Kinney, Michael D > > wrote: > > > > > > The other way to get full screen text on graphical console is to disa= ble the serial console > > > in the Boot Maintenance Manager. > > > > > > If the serial console is disabled then ConSplitterDxe will only see t= he text modes supported > > > by GraphicsConsoleDxe which will include these higher text modes. > > > > > > Is the issue that you are trying to solve supporting larger serial co= nsole modes or just > > > wanting to use the largest possible text mode at a given graphics res= olution? > > > > > > Mike > > > > > > > -----Original Message----- > > > > From: devel@edk2.groups.io On Behalf Of Kons= tantin Aladyshev > > > > Sent: Wednesday, September 21, 2022 1:24 AM > > > > To: Kinney, Michael D > > > > Cc: devel@edk2.groups.io; Gao, Liming ; W= ang, Jian J ; Ni, Ray > > > > > > > > Subject: Re: [edk2-devel] [PATCH] MdeModulePkg/TerminalDxe: add mod= es > > > > > > > > I have tested it in the following way: > > > > - launch OVMF in Linux and connect with vnc > > > > - change resolution via the form browser (Device Manager -> OVMF > > > > Platform Configuration) from the default 640x480 to the 1920x1080 > > > > - "reset" > > > > - after the reset the system will boot to the 1920x1080 resolution = and > > > > text mode 80x25 > > > > - check "mode" command output > > > > > > > > Before the commit this command displays only these modes: > > > > ``` > > > > Shell> mode > > > > Available modes for console output device. > > > > Col 80 Row 25 * > > > > Col 80 Row 50 > > > > Col 100 Row 31 > > > > ``` > > > > But with this commit the high resolution modes are present in the o= utput: > > > > ``` > > > > Shell> mode > > > > Available modes for console output device. > > > > Col 80 Row 25 * > > > > Col 80 Row 50 > > > > Col 100 Row 31 > > > > Col 128 Row 40 > > > > Col 160 Row 42 > > > > Col 240 Row 56 > > > > ``` > > > > And in my case setting the appropriate "mode 240 56" at runtime wor= ks just fine: > > > > ``` > > > > Shell> mode 240 56 > > > > ``` > > > > After that the text output starts using the full screen. > > > > > > > > Best regards, > > > > Konstantin Aladyshev > > > > > > > > On Wed, Sep 21, 2022 at 4:46 AM Kinney, Michael D > > > > wrote: > > > > > > > > > > Tera Term works. > > > > > > > > > > Mike > > > > > > > > > > > -----Original Message----- > > > > > > From: devel@edk2.groups.io On Behalf Of = gaoliming via groups.io > > > > > > Sent: Tuesday, September 20, 2022 6:26 PM > > > > > > To: Kinney, Michael D ; devel@edk2.= groups.io; aladyshev22@gmail.com > > > > > > Cc: Wang, Jian J ; Ni, Ray > > > > > > Subject: =E5=9B=9E=E5=A4=8D: [edk2-devel] [PATCH] MdeModulePkg/= TerminalDxe: add modes > > > > > > > > > > > > Konstantin: > > > > > > Do you try the terminal software (such as Putty) to display t= he text mode 160, 42 or 240, 56? > > > > > > I try Putty in my desktop. It can't display 240 * 56 in one s= creen. > > > > > > > > > > > > Thanks > > > > > > Liming > > > > > > > -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- > > > > > > > =E5=8F=91=E4=BB=B6=E4=BA=BA: Kinney, Michael D > > > > > > > =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2022=E5=B9=B49=E6=9C=88= 20=E6=97=A5 5:02 > > > > > > > =E6=94=B6=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io; aladyshev2= 2@gmail.com; Kinney, Michael D > > > > > > > > > > > > > > =E6=8A=84=E9=80=81: Wang, Jian J ; Gao= , Liming > > > > > > > ; Ni, Ray > > > > > > > =E4=B8=BB=E9=A2=98: RE: [edk2-devel] [PATCH] MdeModulePkg/Ter= minalDxe: add modes > > > > > > > > > > > > > > This looks like a reasonable update to support platforms that= have both > > > > > > > graphical consoles and serial consoles. > > > > > > > > > > > > > > Reviewed-by: Michael D Kinney > > > > > > > > > > > > > > > > > > > > > > -----Original Message----- > > > > > > > > From: devel@edk2.groups.io On Behalf= Of > > > > > > > Konstantin Aladyshev > > > > > > > > Sent: Monday, September 19, 2022 1:57 AM > > > > > > > > To: devel@edk2.groups.io > > > > > > > > Cc: Wang, Jian J ; Gao, Liming > > > > > > > ; Ni, Ray ; Konst= antin > > > > > > > > Aladyshev > > > > > > > > Subject: [edk2-devel] [PATCH] MdeModulePkg/TerminalDxe: add= modes > > > > > > > > > > > > > > > > The commit b807174fecacf4c9f8400cab4d6fb3f580284021 > > > > > > > > ("MdeModulePkg/GraphicsConsoleDxe: add modes") has added mo= des for > > > > > > > the > > > > > > > > high display resolutions. Support these modes in the Termin= alDxe as > > > > > > > > well, so it would be possible to select the text mode that = would take > > > > > > > > all the available screen space. > > > > > > > > > > > > > > > > Signed-off-by: Konstantin Aladyshev > > > > > > > > --- > > > > > > > > MdeModulePkg/Universal/Console/TerminalDxe/Terminal.c | 3 = +++ > > > > > > > > 1 file changed, 3 insertions(+) > > > > > > > > > > > > > > > > diff --git a/MdeModulePkg/Universal/Console/TerminalDxe/Ter= minal.c > > > > > > > b/MdeModulePkg/Universal/Console/TerminalDxe/Terminal.c > > > > > > > > index e2d779c783..6b7b970516 100644 > > > > > > > > --- a/MdeModulePkg/Universal/Console/TerminalDxe/Terminal.c > > > > > > > > +++ b/MdeModulePkg/Universal/Console/TerminalDxe/Terminal.c > > > > > > > > @@ -115,6 +115,9 @@ TERMINAL_CONSOLE_MODE_DATA > > > > > > > mTerminalConsoleModeData[] =3D { > > > > > > > > { 80, 25 }, > > > > > > > > > > > > > > > > { 80, 50 }, > > > > > > > > > > > > > > > > { 100, 31 }, > > > > > > > > > > > > > > > > + { 128, 40 }, > > > > > > > > > > > > > > > > + { 160, 42 }, > > > > > > > > > > > > > > > > + { 240, 56 }, > > > > > > > > > > > > > > > > // > > > > > > > > > > > > > > > > // New modes can be added here. > > > > > > > > > > > > > > > > // > > > > > > > > > > > > > > > > -- > > > > > > > > 2.25.1 > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -=3D-=3D-=3D-=3D-=3D-=3D > > > > > > > > Groups.io Links: You receive all messages sent to this grou= p. > > > > > > > > View/Reply Online (#93935): > > > > > > > https://edk2.groups.io/g/devel/message/93935 > > > > > > > > Mute This Topic: https://groups.io/mt/93777396/1643496 > > > > > > > > Group Owner: devel+owner@edk2.groups.io > > > > > > > > Unsubscribe: https://edk2.groups.io/g/devel/unsub > > > > > > > [michael.d.kinney@intel.com] > > > > > > > > -=3D-=3D-=3D-=3D-=3D-=3D > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > >=20 > > > > > > >