public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Ilias Apalodimas" <ilias.apalodimas@linaro.org>
To: Sami Mujawar <Sami.Mujawar@arm.com>
Cc: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	 "ardb+tianocore@kernel.org" <ardb+tianocore@kernel.org>,
	"leif@nuviainc.com" <leif@nuviainc.com>
Subject: Re: [PATCH] Silicon/StMMRpmb: Consume MdeLibs.dsc.inc for RegisterFilterLib
Date: Mon, 24 May 2021 11:38:18 +0300	[thread overview]
Message-ID: <CAC_iWj+qT3OiUr-Sway9q48VK0PeC5Xr40wvgkWO+U3dbJov0g@mail.gmail.com> (raw)
In-Reply-To: <AS8PR08MB6806806FB2A3FA3C569E651A84269@AS8PR08MB6806.eurprd08.prod.outlook.com>

Hi Sami,

Indeed I forgot about that patchset!
Since Etienne's patches are reviewed already, feel free to ignore this
so he won't need to rebase his code.

Thanks
/Ilias

On Mon, 24 May 2021 at 11:12, Sami Mujawar <Sami.Mujawar@arm.com> wrote:
>
> Hi Ilias,
>
>
>
> Thank you for this patch.
>
>
>
> I think this change may have been covered in https://edk2.groups.io/g/devel/topic/82880299#75180. However, this is an independent fix that is needed to the current code (before the 32-bit support is merged).
>
>
>
> Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
>
>
>
> Regards,
>
>
>
> Sami Mujawar
>
>
>
> From: Ilias Apalodimas <ilias.apalodimas@linaro.org>
> Date: Sunday, 23 May 2021 at 21:16
> To: devel@edk2.groups.io <devel@edk2.groups.io>, Sami Mujawar <Sami.Mujawar@arm.com>
> Cc: ardb+tianocore@kernel.org <ardb+tianocore@kernel.org>, leif@nuviainc.com <leif@nuviainc.com>, Ilias Apalodimas <ilias.apalodimas@linaro.org>
> Subject: [PATCH] Silicon/StMMRpmb: Consume MdeLibs.dsc.inc for RegisterFilterLib
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246
>
> MdeLibs.dsc.inc was added for some basic/default library
> instances provided by MdePkg and RegisterFilterLibNull Library
> was also added into it as the first version of MdeLibs.dsc.inc.
>
> So update platform dsc to consume MdeLibs.dsc.inc for
> RegisterFilterLibNull which will be consumed by IoLib and BaseLib.
>
> Signed-off-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
> ---
>  .../PlatformStandaloneMmPkg/PlatformStandaloneMmRpmb.dsc        | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/Platform/StandaloneMm/PlatformStandaloneMmPkg/PlatformStandaloneMmRpmb.dsc b/Platform/StandaloneMm/PlatformStandaloneMmPkg/PlatformStandaloneMmRpmb.dsc
> index f99a47ebf605..266e2297dd09 100644
> --- a/Platform/StandaloneMm/PlatformStandaloneMmPkg/PlatformStandaloneMmRpmb.dsc
> +++ b/Platform/StandaloneMm/PlatformStandaloneMmPkg/PlatformStandaloneMmRpmb.dsc
> @@ -22,6 +22,8 @@
>    FLASH_DEFINITION               = Platform/StandaloneMm/PlatformStandaloneMmPkg/PlatformStandaloneMmRpmb.fdf
>
>    DEFINE DEBUG_MESSAGE           = TRUE
>
>
>
> +  !include MdePkg/MdeLibs.dsc.inc
>
> +
>
>  ################################################################################
>
>  #
>
>  # Library Class section - list of all Library Classes needed by this Platform.
>
> --
> 2.31.1
>
> IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

      reply	other threads:[~2021-05-24  8:38 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-23 20:16 [PATCH] Silicon/StMMRpmb: Consume MdeLibs.dsc.inc for RegisterFilterLib Ilias Apalodimas
2021-05-24  8:12 ` Sami Mujawar
2021-05-24  8:38   ` Ilias Apalodimas [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAC_iWj+qT3OiUr-Sway9q48VK0PeC5Xr40wvgkWO+U3dbJov0g@mail.gmail.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox