Re: [edk2-devel] [PATCH edk2-platforms 2/2] Platform/StMmRpmb: Switch to MbedTls for crypto

["Ilias Apalodimas" <ilias.apalodimas@linaro.org>]

On Thu, 29 Aug 2024 at 22:29, Ard Biesheuvel <ardb+git@google.com> wrote:
>
> From: Ard Biesheuvel <ardb@kernel.org>
>
> MbedTls is much smaller than OpenSSL, and does not require a softfloat
> library on 32-bit ARM. So use that instead.
>
> Note that we still need to resolve OpensslLib, given that MbedTlsLib has
> a dependency on it (but only for SM3 digital signatures, which are not
> used here)
>
> Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
> ---
>  Platform/StandaloneMm/PlatformStandaloneMmPkg/PlatformStandaloneMmRpmb.dsc | 8 +++-----
>  1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/Platform/StandaloneMm/PlatformStandaloneMmPkg/PlatformStandaloneMmRpmb.dsc b/Platform/StandaloneMm/PlatformStandaloneMmPkg/PlatformStandaloneMmRpmb.dsc
> index 54c7a63b4157..c54b235d4ac3 100644
> --- a/Platform/StandaloneMm/PlatformStandaloneMmPkg/PlatformStandaloneMmRpmb.dsc
> +++ b/Platform/StandaloneMm/PlatformStandaloneMmPkg/PlatformStandaloneMmRpmb.dsc
> @@ -75,16 +75,14 @@ [LibraryClasses]
>    #
>    NULL|ArmPkg/Library/CompilerIntrinsicsLib/CompilerIntrinsicsLib.inf
>
> -[LibraryClasses.ARM]
> -  ArmSoftFloatLib|ArmPkg/Library/ArmSoftFloatLib/ArmSoftFloatLib.inf
> -
>  [LibraryClasses.common.MM_STANDALONE]
>    HobLib|StandaloneMmPkg/Library/StandaloneMmHobLib/StandaloneMmHobLib.inf
>    MmServicesTableLib|MdePkg/Library/StandaloneMmServicesTableLib/StandaloneMmServicesTableLib.inf
>    MemoryAllocationLib|StandaloneMmPkg/Library/StandaloneMmMemoryAllocationLib/StandaloneMmMemoryAllocationLib.inf
>
>    IntrinsicLib|CryptoPkg/Library/IntrinsicLib/IntrinsicLib.inf
> -  OpensslLib|CryptoPkg/Library/OpensslLib/OpensslLib.inf
> +  MbedTlsLib|CryptoPkg/Library/MbedTlsLib/MbedTlsLib.inf
> +  OpensslLib|CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf
>    PlatformSecureLib|SecurityPkg/Library/PlatformSecureLibNull/PlatformSecureLibNull.inf
>    SynchronizationLib|MdePkg/Library/BaseSynchronizationLib/BaseSynchronizationLib.inf
>    TimerLib|MdePkg/Library/BaseTimerLibNullTemplate/BaseTimerLibNullTemplate.inf
> @@ -151,7 +149,7 @@ [Components.common]
>    MdeModulePkg/Universal/Variable/RuntimeDxe/VariableStandaloneMm.inf {
>      <LibraryClasses>
>        AuthVariableLib|SecurityPkg/Library/AuthVariableLib/AuthVariableLib.inf
> -      BaseCryptLib|CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf
> +      BaseCryptLib|CryptoPkg/Library/BaseCryptLibMbedTls/SmmCryptLib.inf
>        DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf
>        VarCheckLib|MdeModulePkg/Library/VarCheckLib/VarCheckLib.inf
>        NULL|MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLib.inf
> --
> 2.46.0.469.g59c65b2a67-goog
>

Reviewed-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120442): https://edk2.groups.io/g/devel/message/120442
Mute This Topic: https://groups.io/mt/108176226/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-