public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Ilias Apalodimas" <ilias.apalodimas@linaro.org>
To: Thomas Abraham <thomas.abraham@arm.com>
Cc: Pierre.Gondois@arm.com, devel@edk2.groups.io,
	 Ard Biesheuvel <ardb+tianocore@kernel.org>,
	Sami Mujawar <sami.mujawar@arm.com>,
	 Leif Lindholm <quic_llindhol@quicinc.com>,
	Wenyi Xie <xiewenyi2@huawei.com>,
	 Omkar Anand Kulkarni <omkar.kulkarni@arm.com>,
	Pranav Madhu <pranav.madhu@arm.com>,
	 Sayanta Pattanayak <Sayanta.Pattanayak@arm.com>
Subject: Re: [PATCH edk2-platforms 2/5] Platform/StandaloneMm: Remove '-march=armv8-a+nofp' flag
Date: Thu, 26 Jan 2023 11:52:00 +0200	[thread overview]
Message-ID: <CAC_iWjJyw-qn+rTJztuEH-BwF_21LWhrbmqHSF0CqB6W1=R2pQ@mail.gmail.com> (raw)
In-Reply-To: <696defbc-0cc9-f16b-aee8-f92b79bdff85@arm.com>

On Thu, 26 Jan 2023 at 11:35, Thomas Abraham <thomas.abraham@arm.com> wrote:
>
>
>
> On 25/01/2023 10:27, Pierre.Gondois@arm.com wrote:
> > From: Pierre Gondois <pierre.gondois@arm.com>
> >
> > The '-march=armv8-a+nofp' flag used for PlatformStandaloneMm.dsc
> > was removed in the previous patch. The same flag was probably copied
> > from this first configuration in:
> > commit bd5071cfbde01 ("StMMRpmb: Add support for building StandaloneMm
> > image for OP-TEE")
> >
> > As the flag is removed for PlatformStandaloneMm.dsc in the previous
> > patch, also remove the flag for PlatformStandaloneMmRpmb.dsc.
> >
> > CC: Ilias Apalodimas <ilias.apalodimas@linaro.org>
> > CC: Omkar Anand Kulkarni <omkar.kulkarni@arm.com>
> > CC: Pranav Madhu <pranav.madhu@arm.com>
> > CC: Sayanta Pattanayak <Sayanta.Pattanayak@arm.com>
> > Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
> > ---
> >   .../PlatformStandaloneMmPkg/PlatformStandaloneMmRpmb.dsc        | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/Platform/StandaloneMm/PlatformStandaloneMmPkg/PlatformStandaloneMmRpmb.dsc b/Platform/StandaloneMm/PlatformStandaloneMmPkg/PlatformStandaloneMmRpmb.dsc
> > index 653029c52fdb..611d76e62117 100644
> > --- a/Platform/StandaloneMm/PlatformStandaloneMmPkg/PlatformStandaloneMmRpmb.dsc
> > +++ b/Platform/StandaloneMm/PlatformStandaloneMmPkg/PlatformStandaloneMmRpmb.dsc
> > @@ -165,7 +165,7 @@ [Components.common]
> >   #
> >   ###################################################################################################
> >   [BuildOptions.AARCH64]
> > -GCC:*_*_*_DLINK_FLAGS = -z common-page-size=0x1000 -march=armv8-a+nofp
> > +GCC:*_*_*_DLINK_FLAGS = -z common-page-size=0x1000
> >   GCC:*_*_*_CC_FLAGS = -mstrict-align
> >
> >   [BuildOptions.ARM]
>
>
> Reviewed-by: Thomas Abraham <thomas.abraham@arm.com>

Thanks for the fix,

Acked-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>

  reply	other threads:[~2023-01-26  9:52 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-25 10:27 [PATCH edk2-platforms 0/5] Build fixes for Arm/Hisilicon platforms PierreGondois
2023-01-25 10:27 ` [PATCH edk2-platforms 1/5] Platform/ARM/SgiPkg: Remove '-march=armv8-a+nofp' flag PierreGondois
2023-01-26  9:34   ` Thomas Abraham
2023-01-27  9:01   ` [edk2-devel] " Sami Mujawar
2023-01-25 10:27 ` [PATCH edk2-platforms 2/5] Platform/StandaloneMm: " PierreGondois
2023-01-26  9:35   ` Thomas Abraham
2023-01-26  9:52     ` Ilias Apalodimas [this message]
2023-01-27  9:02   ` [edk2-devel] " Sami Mujawar
2023-01-25 10:28 ` [PATCH edk2-platforms 3/5] Silicon/Hisilicon/FlashFvbDxe: Update TokenSpace of PcdNorFlashCheckBlockLocked PierreGondois
2023-01-26 11:19   ` [edk2-devel] " Sami Mujawar
2023-01-25 10:28 ` [PATCH edk2-platforms 4/5] Platform/Hisilicon: Add VariableFlashInfoLib to Hisilicon.dsc.inc PierreGondois
2023-01-26 11:31   ` [edk2-devel] " Sami Mujawar
2023-01-26 11:59     ` Sami Mujawar
2023-01-25 10:28 ` [PATCH edk2-platforms 5/5] Platform/ARM/Sgi: Add VariableFlashInfoLib to SgiPlatformMm.dsc.inc PierreGondois
2023-01-26  9:36   ` Thomas Abraham
2023-01-27  9:03   ` [edk2-devel] " Sami Mujawar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAC_iWjJyw-qn+rTJztuEH-BwF_21LWhrbmqHSF0CqB6W1=R2pQ@mail.gmail.com' \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox