From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f54.google.com (mail-lf1-f54.google.com [209.85.167.54]) by mx.groups.io with SMTP id smtpd.web10.70180.1674726767645386311 for ; Thu, 26 Jan 2023 01:52:48 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=WYw/RsaH; spf=pass (domain: linaro.org, ip: 209.85.167.54, mailfrom: ilias.apalodimas@linaro.org) Received: by mail-lf1-f54.google.com with SMTP id b3so2267086lfv.2 for ; Thu, 26 Jan 2023 01:52:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=X98cKtX33Ix+X+hvaFctgpzikkKfIThFO3V7zyPALdg=; b=WYw/RsaHLNQ5a0ZZqQVEDYFAQDFEzcs11/+fqhBcKzNo0g5vLTGxsWW3cYtP1r18mu WNHWQZG0enn0zGNzgvY9h1TSKnCfy2reLmYRhfq29oVIp07enYifD6Lht9VHVw3jTMn1 8TwYe8d9gTsWqL4Yz91q4VHPmDtZI2aKchR8YM80VLQUqmuVVN8aOSOHPRL2YT4FDzuD JAiGJ/PKiiy0HaycEI6DwSZgPvs32Ik/1imV5gvEWs4wXYDx5hYa0cWCgO39US1c4Iyy 5Hb62wAruz3qIuuE9TfmJP68kz5bASNdMkftRLnqczLfVrBb+ehUB9Ozp7b+BhAgRkBw siKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=X98cKtX33Ix+X+hvaFctgpzikkKfIThFO3V7zyPALdg=; b=zrIi91DFogvfXwHPbAPkWIiEuh30JSbf1ec6ee1vV84/bV7rG+JXHmV0/TM9COerEG HHN6kd/iRrP9LapkyoSmTCzT3NDSL388LwdgjzI51ODKfbqkajFVvCQZjqYtJOsYg+Ee otxpgY0Kt3dyKBy/uy5vRwLYDmCJd0AGRJ0EUUTdHKHA0/0IuQCeSgYLUuM1XnieOMIc Y678PjeZJDFO8Jq29zhWiP2eEQ0LHIW1mVNdsjDYj6QS8LtCOehC6nrFLUYVJzrBw6Ed cq3XhhBzddMhsORRGYwoU9NGe4i6AUK2mLzv7yC4xw3hd+mmQNXt/kfPP5Zet8i5Gp0V lzAA== X-Gm-Message-State: AFqh2krGFOobARfE8GUf5CnjJgrxOIFnsaVkSEdxCA3Oof5ulDEuabvS f5QHlRk3AQWkftwMk8W3+9yiaatn3x5MYvMjNwYMoQ== X-Google-Smtp-Source: AMrXdXuqdXIc+0qDP2xwWV2/Q8cMM/ohtkSZ1IBD9I4wZmJKqbgT0TTmn1w4Nifk931+01XbBskgoSZnCEzsI4eM1eg= X-Received: by 2002:a19:f602:0:b0:4ca:f757:6c91 with SMTP id x2-20020a19f602000000b004caf7576c91mr1639501lfe.92.1674726756767; Thu, 26 Jan 2023 01:52:36 -0800 (PST) MIME-Version: 1.0 References: <20230125102802.663790-1-Pierre.Gondois@arm.com> <20230125102802.663790-3-Pierre.Gondois@arm.com> <696defbc-0cc9-f16b-aee8-f92b79bdff85@arm.com> In-Reply-To: <696defbc-0cc9-f16b-aee8-f92b79bdff85@arm.com> From: "Ilias Apalodimas" Date: Thu, 26 Jan 2023 11:52:00 +0200 Message-ID: Subject: Re: [PATCH edk2-platforms 2/5] Platform/StandaloneMm: Remove '-march=armv8-a+nofp' flag To: Thomas Abraham Cc: Pierre.Gondois@arm.com, devel@edk2.groups.io, Ard Biesheuvel , Sami Mujawar , Leif Lindholm , Wenyi Xie , Omkar Anand Kulkarni , Pranav Madhu , Sayanta Pattanayak Content-Type: text/plain; charset="UTF-8" On Thu, 26 Jan 2023 at 11:35, Thomas Abraham wrote: > > > > On 25/01/2023 10:27, Pierre.Gondois@arm.com wrote: > > From: Pierre Gondois > > > > The '-march=armv8-a+nofp' flag used for PlatformStandaloneMm.dsc > > was removed in the previous patch. The same flag was probably copied > > from this first configuration in: > > commit bd5071cfbde01 ("StMMRpmb: Add support for building StandaloneMm > > image for OP-TEE") > > > > As the flag is removed for PlatformStandaloneMm.dsc in the previous > > patch, also remove the flag for PlatformStandaloneMmRpmb.dsc. > > > > CC: Ilias Apalodimas > > CC: Omkar Anand Kulkarni > > CC: Pranav Madhu > > CC: Sayanta Pattanayak > > Signed-off-by: Pierre Gondois > > --- > > .../PlatformStandaloneMmPkg/PlatformStandaloneMmRpmb.dsc | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/Platform/StandaloneMm/PlatformStandaloneMmPkg/PlatformStandaloneMmRpmb.dsc b/Platform/StandaloneMm/PlatformStandaloneMmPkg/PlatformStandaloneMmRpmb.dsc > > index 653029c52fdb..611d76e62117 100644 > > --- a/Platform/StandaloneMm/PlatformStandaloneMmPkg/PlatformStandaloneMmRpmb.dsc > > +++ b/Platform/StandaloneMm/PlatformStandaloneMmPkg/PlatformStandaloneMmRpmb.dsc > > @@ -165,7 +165,7 @@ [Components.common] > > # > > ################################################################################################### > > [BuildOptions.AARCH64] > > -GCC:*_*_*_DLINK_FLAGS = -z common-page-size=0x1000 -march=armv8-a+nofp > > +GCC:*_*_*_DLINK_FLAGS = -z common-page-size=0x1000 > > GCC:*_*_*_CC_FLAGS = -mstrict-align > > > > [BuildOptions.ARM] > > > Reviewed-by: Thomas Abraham Thanks for the fix, Acked-by: Ilias Apalodimas