From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail-yb1-f171.google.com (mail-yb1-f171.google.com [209.85.219.171])
 by mx.groups.io with SMTP id smtpd.web10.14234.1651258562610001749
 for <devel@edk2.groups.io>;
 Fri, 29 Apr 2022 11:56:02 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@linaro.org header.s=google header.b=FO7E6UEJ;
 spf=pass (domain: linaro.org, ip: 209.85.219.171, mailfrom: ilias.apalodimas@linaro.org)
Received: by mail-yb1-f171.google.com with SMTP id j2so16133927ybu.0
        for <devel@edk2.groups.io>; Fri, 29 Apr 2022 11:56:02 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linaro.org; s=google;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=oNAXN9XivZSEcIYkojUU/YcBaEsExmaMtGTDGz2pK5g=;
        b=FO7E6UEJoUq93BtjrviRdEvxX6q/PAmmpTW5dm+BWKD0PHbW4liDqiCVFCIvHHjni2
         N2wdQjxVx0BJgEWLSaey5I7lYQSV0ATbmJX++rfwpgYvNJcdlxSpdZ/XQGopsEua0/dy
         hOMqiQTu6qDGB4yXv5X446KOtllSO60cJXuDiI/7v7ODjW/2KF/3oq5BAV8JwWYD4j3W
         eD1rBP3N7vcP23Rnfu3JK6gbZx+L0MefqelR1btbG7uRkT4+c8/7Q30sL7HJjH9s50mB
         A3mJ0D2tm7hQWZlqRhTCrQzPwjECxCk8xLqfsBTIxsJLQfQL13hn0B32PCnCtM5Ie9nO
         YSxw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=oNAXN9XivZSEcIYkojUU/YcBaEsExmaMtGTDGz2pK5g=;
        b=Gki980BESnD4f9eSOx76hcXb3FBJ91+ApUKBcGp/2xTUyJB3nXKfqhuK+B91DqHlX8
         Z3dDUH3pXEO16FnIwfFRoin4yXSaYjMs+6HEJvKV73NsbBPaQq4e0vtWkQYNVoTjehmV
         R5/kY7+M9/EXEFri0LiwsDYkInI2bxJ638QDyVJHEY76j10tN8DDRbWcMMogtNgeGIvE
         QNW1okbAS/37vVOKtxZOd6FbtVjkJaKuxeC1R+uOUzGYuTe+wIwYJlBehZ3jLfGkmcsc
         IBmoTZqHBxTni69Mq8L5oZsAXXllMEJuSwXD6tpkTu132A4u/luF9xf5H4OXitKbM+LX
         7PuA==
X-Gm-Message-State: AOAM532jnRuUUjVn1XvLuRNDiDXQhvTCqU9iaSKt3Fhq8ANQViIUZPoK
	Z5fMd3QyBhDphmklOBEye9oT1DlW7fgLvyTlm1qSoQ==
X-Google-Smtp-Source: ABdhPJyaTnApYF3SM6sT+TLWxqVj42vKwFsxpB9Prqzu79uMSyRtutGOn/SnLrrJMt30fS2C1U6/ldUZBwvilQE56h0=
X-Received: by 2002:a25:764d:0:b0:648:dc27:e870 with SMTP id
 r74-20020a25764d000000b00648dc27e870mr894660ybc.150.1651258561735; Fri, 29
 Apr 2022 11:56:01 -0700 (PDT)
MIME-Version: 1.0
References: <20220420204420.1132-1-mikuback@linux.microsoft.com>
 <20220420204420.1132-11-mikuback@linux.microsoft.com> <8fa4f1bb-1ebe-d903-af4f-b9c5d476b5c4@arm.com>
In-Reply-To: <8fa4f1bb-1ebe-d903-af4f-b9c5d476b5c4@arm.com>
From: "Ilias Apalodimas" <ilias.apalodimas@linaro.org>
Date: Fri, 29 Apr 2022 21:55:25 +0300
Message-ID: <CAC_iWjL_LjZZYNYudRfUxse2Y1aiB-dWU9LxKjGAX=ZMZ_npjg@mail.gmail.com>
Subject: Re: [edk2-platforms][PATCH v1 10/10] PlatformStandaloneMmPkg: Add VariableFlashInfoLib
To: Sami Mujawar <sami.mujawar@arm.com>
Cc: mikuback@linux.microsoft.com, devel@edk2.groups.io, nd@arm.com
Content-Type: text/plain; charset="UTF-8"

Thanks for the patches

On Mon, 25 Apr 2022 at 19:06, Sami Mujawar <sami.mujawar@arm.com> wrote:
>
> Hi Michael,
>
> Thank you for this patch.
>
> These changes look good to me.
>
> Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
>
> Regards,
>
> Sami Mujawar
>
> On 20/04/2022 09:44 pm, mikuback@linux.microsoft.com wrote:
> > From: Michael Kubacki <michael.kubacki@microsoft.com>
> >
> > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479
> >
> > Adds an instance for the library class VariableFlashInfoLib that
> > was recently introduced in MdeModulePkg. This change is made to
> > allow the new variable driver to build that has a dependency on
> > this library class and does not require any further platform
> > changes.
> >
> > Cc: Sami Mujawar <sami.mujawar@arm.com>
> > Cc: Ilias Apalodimas <ilias.apalodimas@linaro.org>
> > Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
> > ---
> >   Platform/StandaloneMm/PlatformStandaloneMmPkg/PlatformStandaloneMmRpmb.dsc | 1 +
> >   1 file changed, 1 insertion(+)
> >
> > diff --git a/Platform/StandaloneMm/PlatformStandaloneMmPkg/PlatformStandaloneMmRpmb.dsc b/Platform/StandaloneMm/PlatformStandaloneMmPkg/PlatformStandaloneMmRpmb.dsc
> > index 33364deb1ef0..653029c52fdb 100644
> > --- a/Platform/StandaloneMm/PlatformStandaloneMmPkg/PlatformStandaloneMmRpmb.dsc
> > +++ b/Platform/StandaloneMm/PlatformStandaloneMmPkg/PlatformStandaloneMmRpmb.dsc
> > @@ -34,6 +34,7 @@ [LibraryClasses]
> >     ArmLib|ArmPkg/Library/ArmLib/ArmBaseLib.inf
> >     BaseLib|MdePkg/Library/BaseLib/BaseLib.inf
> >     SafeIntLib|MdePkg/Library/BaseSafeIntLib/BaseSafeIntLib.inf
> > +  VariableFlashInfoLib|MdeModulePkg/Library/BaseVariableFlashInfoLib/BaseVariableFlashInfoLib.inf
> >     VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf
> >     BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf
> >     DebugPrintErrorLevelLib|MdePkg/Library/BaseDebugPrintErrorLevelLib/BaseDebugPrintErrorLevelLib.inf

Reviewed-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>