From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yb0-x233.google.com (mail-yb0-x233.google.com [IPv6:2607:f8b0:4002:c09::233]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 5896A1A1E29 for ; Sun, 16 Oct 2016 23:49:46 -0700 (PDT) Received: by mail-yb0-x233.google.com with SMTP id 191so61817712ybv.3 for ; Sun, 16 Oct 2016 23:49:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=56IE+/uUDmjwsdPNGDzCT34yQ/25nV4piFAd7xJMU6Y=; b=R3msC2KhHSVCf6yOOi1J9oARUysMRK2E5QWhtPfb54Z2Vm7s44toPEYXnmJ4A1tGop sIToKAI0Y1pUwRJ+c6K9oIyZQjqlpgY8UZ/P5mUWVtcKpZgkiOm3mtifvxlcqe7YiA7k pc+o3RuBIPD3TXX+3MRJ2+ya9+4E5jm/SCHl4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=56IE+/uUDmjwsdPNGDzCT34yQ/25nV4piFAd7xJMU6Y=; b=lzRAyc+MX7Xhwr+6u4LEd4Kk1sNplqUuDt9FtB6yss+CQ4gdUYdXJsduJ1L0nH8DGJ H5t59fZls/WFHOLWRz4muhT4EiL2LWzL+GZkH58p6pyoPNQRL9mdZdiU9ZWTd3cjt347 lh4dGrMAKMAExLFYBYpmQhW/2Rz5IeD9+dvsadTQ8yYnnnoQaEQATONJs1VD6Jr5+MF2 d0dNTjg8yN5S6xUylCVh97wF3o1B/LscMUD1yg7NzQ3/lvMNmjHe08+7uwlF/NeCtwnB OIt2lfTKPqzDA0PO7VSBx8XRTuSnM/ejALZSLjZDkfqI6sEQXfyiV3AIvR+TLJwIELmO Lctg== X-Gm-Message-State: AA6/9Rn/f1EFQ9ri7p0xuWZB3LKNggzfdMw52dRMHRg5cCm09G5LDK1l3hTgywE4GLMpigcjV6YEIdTAN+SIqVmV X-Received: by 10.37.217.204 with SMTP id q195mr22426319ybg.97.1476686985313; Sun, 16 Oct 2016 23:49:45 -0700 (PDT) MIME-Version: 1.0 Received: by 10.13.210.193 with HTTP; Sun, 16 Oct 2016 23:49:44 -0700 (PDT) Received: by 10.13.210.193 with HTTP; Sun, 16 Oct 2016 23:49:44 -0700 (PDT) In-Reply-To: References: <1476595420-12566-1-git-send-email-vladimir.olovyannikov@broadcom.com> <40b80588-1bb4-e5f2-439c-97a405c873d3@redhat.com> From: Vladimir Olovyannikov Date: Sun, 16 Oct 2016 23:49:44 -0700 Message-ID: To: Laszlo Ersek Cc: "edk2-devel@lists.01.org" , Jaben Carsey , ruiyu.ni@intel.com X-Content-Filtered-By: Mailman/MimeDel 2.1.21 Subject: Re: [PATCH] GPT Shell Application/Library X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Oct 2016 06:49:46 -0000 Content-Type: text/plain; charset=UTF-8 Thank you Laszlo, Sorry, I missed the fields; it is my first contribution, I will add the required lines, review the source according to your comments and will resubmit the patch. So do you think the command should be _gpt instead of gpt? I was following TFTP and SF commands as a template. Thank you, Vladimir On Oct 16, 2016 1:05 PM, "Laszlo Ersek" wrote: > > On 10/16/16 07:23, Vladimir Olovyannikov wrote: > > This allows managing (create, delete, modify, fat format) of GPT > > partitions from within UEFI Shell. > > Syntax: > > gpt [device_mapped_name] [parameters...] > > See usage examples in the .uni file > > --- > > .../Library/UefiShellGptCommandLib/FatFormat.c | 611 +++++++ > > .../Library/UefiShellGptCommandLib/FatFormat.h | 111 ++ > > .../Library/UefiShellGptCommandLib/GptWorker.c | 1902 ++++++++++++++++++++ > > .../Library/UefiShellGptCommandLib/GptWorker.h | 186 ++ > > .../UefiShellGptCommandLib.c | 1135 ++++++++++++ > > .../UefiShellGptCommandLib.inf | 79 + > > .../UefiShellGptCommandLib.uni | 117 ++ > > ShellPkg/ShellPkg.dec | 1 + > > ShellPkg/ShellPkg.dsc | 4 + > > 9 files changed, 4146 insertions(+) > > create mode 100644 ShellPkg/Library/UefiShellGptCommandLib/FatFormat.c > > create mode 100644 ShellPkg/Library/UefiShellGptCommandLib/FatFormat.h > > create mode 100644 ShellPkg/Library/UefiShellGptCommandLib/GptWorker.c > > create mode 100644 ShellPkg/Library/UefiShellGptCommandLib/GptWorker.h > > create mode 100644 ShellPkg/Library/UefiShellGptCommandLib/UefiShellGptCommandLib.c > > create mode 100644 ShellPkg/Library/UefiShellGptCommandLib/UefiShellGptCommandLib.inf > > create mode 100644 ShellPkg/Library/UefiShellGptCommandLib/UefiShellGptCommandLib.uni > > This looks like a supremely welcome, long-awaited addition (latest > request: > ), > but it really needs your Signed-off-by, and the Contributed-under line > above it: > > ShellPkg/Contributions.txt > > I would also suggest (simply based on what I've seen elsewhere in edk2) > to keep the copyright notices tightly collected in the file headings. > > Someone will have to go over all the licenses too -- does the "Marvell > BSD License Option" for example correspond to the 3-clause BSDL? > > On the technical side, I believe that as long as a shell command (or a > command option) is not standardized (in the shell spec), it usually > starts with an underscore (_), so as to prevent future name collisions. > (I could be wrong about this -- I now recall the TFTP command, which is > also not in the 2.2 spec.) > > Just my two cents. > > Thanks > Laszlo