From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=209.85.208.193; helo=mail-lj1-f193.google.com; envelope-from=stbenjam@redhat.com; receiver=edk2-devel@lists.01.org Received: from mail-lj1-f193.google.com (mail-lj1-f193.google.com [209.85.208.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B84F521A07A92 for ; Tue, 4 Sep 2018 06:43:54 -0700 (PDT) Received: by mail-lj1-f193.google.com with SMTP id y17-v6so3192980ljy.8 for ; Tue, 04 Sep 2018 06:43:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:reply-to :from:date:message-id:subject:to:cc; bh=UakCtEeLq0dEQKMhWXDQxwi1n2jzRjSeDPQyZKrQ2r4=; b=SmwahsBHft+r/L6C4vwXbg2yb/JWZyGRkBzymis+yHB+/yWP3vN2ywu/wSBKACG/r3 FpPp9WKy936odrvU7MKbVdOvZAbrY7UrteX+atyivw6e4iZOi72OJVcPU/qnVtvePXnW +e/8ky4eRDnG7XuXSs3RZy0GRFKa7JvueEdPURUNraRg9WCeVHlCxvWcQki0Hf2d7CuJ HBhq0I1u1qpkDGhizsu4hrnq+7F+cgbF9A+8c2XTjwoU69Vv3fmkg6SZ1L/16cTHLd56 FmQqTH55H7TvUC0Rf7Npr6H9oASZUEzTTR2JCG4FgnY2aS8sB17FOF7RNPqdlao3+iaZ kIcQ== X-Gm-Message-State: APzg51CI+eBi9Doxet3IUCzHLuJdFqtPkRFmCYR0H5kIeBspMhO+AaY8 EsWu/NmezMp4yA9r2e5ioMVysjOM7c2uVh1rZifo/g== X-Google-Smtp-Source: ANB0VdZ22CR3aaERxnUl0j+6JKTpZQSIM8cy1lYW36KDfQtb0MQYcasQLhmvIt78/tH4e+pdIQZx2IdtYHNklrQOuDQ= X-Received: by 2002:a2e:4782:: with SMTP id u124-v6mr21847277lja.40.1536068632293; Tue, 04 Sep 2018 06:43:52 -0700 (PDT) MIME-Version: 1.0 References: <20180904071722.7728-1-Jiaxin.wu@intel.com> In-Reply-To: Reply-To: stephen@redhat.com From: Stephen Benjamin Date: Tue, 4 Sep 2018 09:43:40 -0400 Message-ID: To: Laszlo Ersek Cc: Jiaxin.wu@intel.com, edk2-devel@lists.01.org, ting.ye@intel.com, siyuan.fu@intel.com Subject: Re: [Patch] MdeModulePkg/Library/DxeHttpLib: Handle the blank value in HTTP header. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Sep 2018 13:43:56 -0000 Content-Type: text/plain; charset="UTF-8" On Tue, Sep 4, 2018 at 7:02 AM Laszlo Ersek wrote: > > On 09/04/18 09:17, Jiaxin Wu wrote: > > This patch is to resolve the lock-up issue if the value of HTTP header > > is blank. The issue is recorded @ > > https://bugzilla.tianocore.org/show_bug.cgi?id=1102. > > > > Cc: Stephen Benjamin > > Cc: Laszlo Ersek > > Cc: Ye Ting > > Cc: Fu Siyuan > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Wu Jiaxin > > --- > > MdeModulePkg/Library/DxeHttpLib/DxeHttpLib.c | 57 +++++++++++++++----- > > 1 file changed, 44 insertions(+), 13 deletions(-) > > Thank you, Jiaxin, I'll let Stephen test this :) > > Stephen, can you please respond with your Tested-by, if the patch solves > the problem for you? > > Also, would you prefer a remote repo+branch that you could pull (over > applying this patch with "git-am") for testing? The edk2 project uses > CRLF source files, so "git-am" is a bit quirky. No need, the patch applied fine. Thanks for the quick turnaround! It resolved my issue. Tested-by: Stephen Benjamin > Thanks, > Laszlo