From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf0-x235.google.com (mail-lf0-x235.google.com [IPv6:2a00:1450:4010:c07::235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id EDCE71A1E92 for ; Tue, 11 Oct 2016 10:44:06 -0700 (PDT) Received: by mail-lf0-x235.google.com with SMTP id b81so51582820lfe.1 for ; Tue, 11 Oct 2016 10:44:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:from:date:message-id:subject:to:cc; bh=tLUkFN92sWEaoNravcdBXwRay0Z3yjG3RO2oxme8BzQ=; b=Q8hxCIjCKpE6pxqFqoMsMh0dmNaqslP3Tf9hPCO0lLtgPRkPu7J74zD8H/1DoZIr37 SJaof7+xAqkwqaNnQNYvr13ily97gDnBc+bwCf1tJNgNLgVeP0l6tKjyLaydIR34MLMx fCvwVgLlCREN6gE1MF9IdZ+sRWPP7QCG741/I= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc; bh=tLUkFN92sWEaoNravcdBXwRay0Z3yjG3RO2oxme8BzQ=; b=CiZEX5lHsxsbaNHYYcdcozJTQExT+9H78V7TKqTjya+dzDHT2HjwQobObhhhz/+iAD HIFXCs889VnkL+Ah2O6O77Ghgdslk7n7ewJxbmn2bliNCC8nxX34ICP6QYEedeEqIP6q 2qMdrfYVx+5JIzS098L/29+f9pCTNchJFJE+PqZu/HdTDolp/48c5SYdGlMQ301CLOFS oNU7t3wGZtLEF79lm+ZTQIDymnPX/P0hHZrCg8utTRW4VCtdUZr7WI7ls3vS9/qnjyyt 8oMP3WrFc4x8tIGX2z769YY5HrZkriRdPrBelf5ZhqiOxdOkP0kwW1DDqod0OUogCcvK 7Dbg== X-Gm-Message-State: AA6/9RnQYwtasP/uHDo+IUXF0V1Mre56A+E6NoMVCkPs9XRQJqThV7dt2r+8oKsm1Eb90RDeiLyqx6h4ntW3y2aC X-Received: by 10.25.166.145 with SMTP id p139mr4179109lfe.132.1476207844782; Tue, 11 Oct 2016 10:44:04 -0700 (PDT) MIME-Version: 1.0 Received: by 10.25.190.83 with HTTP; Tue, 11 Oct 2016 10:44:04 -0700 (PDT) From: Ryan Harkin Date: Tue, 11 Oct 2016 18:44:04 +0100 Message-ID: To: Evan Lloyd Cc: "edk2-devel@lists.01.org" , Leif Lindholm Subject: Re: ArmPlatformPkg: Allocate VRAM as RuntimeServicesData X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Oct 2016 17:44:07 -0000 Content-Type: text/plain; charset=UTF-8 Hi Evan, This was sent to the list with no subject line and I wasn't on CC, so I didn't see it. Are you still using this patch and want it in, i.e. does it need review and test? Cheers, Ryan. On 4 March 2016 at 15:57, wrote: > Code at: https://github.com/EvanLloyd/tianocore/commit/ > From: Sami Mujawar > Date: Thu, 25 Feb 2016 15:07:40 +0000 > Subject: [PATCH] ArmPlatformPkg: Allocate VRAM as RuntimeServicesData > > The UEFI specification allows the operating system (OS) to use the > Graphics Output Protocol (GOP) in the following scenarios: > a. as part of the startup process and > b. prior to loading of a high performance OS graphics driver > > If the VRAM is allocated as BootServicesData, then it is unmapped on > exit boot services. This prevents GOP usage by the OS post exit boot > services (the second scenario); as it results in a crash when the VRAM > is accessed. > > This patch fixes the issue by allocating VRAM as RuntimeServicesData. > > Code at: https://github.com/EvanLloyd/tianocore/commit/18fab16a63c59c84c71cd81089a55a4081ebe253 > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Alexei Fedorov > Signed-off-by: Girish Pathak > Signed-off-by: Sami Mujawar > Signed-off-by: Evan Lloyd > --- > ArmPlatformPkg/ArmVExpressPkg/Library/HdLcdArmVExpressLib/HdLcdArmVExpress.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/ArmPlatformPkg/ArmVExpressPkg/Library/HdLcdArmVExpressLib/HdLcdArmVExpress.c b/ArmPlatformPkg/ArmVExpressPkg/Library/HdLcdArmVExpressLib/HdLcdArmVExpress.c > index a578467..4ab8862 100644 > --- a/ArmPlatformPkg/ArmVExpressPkg/Library/HdLcdArmVExpressLib/HdLcdArmVExpress.c > +++ b/ArmPlatformPkg/ArmVExpressPkg/Library/HdLcdArmVExpressLib/HdLcdArmVExpress.c > @@ -133,7 +133,7 @@ LcdPlatformGetVram ( > } else { > AllocationType = AllocateAddress; > } > - Status = gBS->AllocatePages (AllocationType, EfiBootServicesData, EFI_SIZE_TO_PAGES(((UINTN)LCD_VRAM_SIZE)), VramBaseAddress); > + Status = gBS->AllocatePages (AllocationType, EfiRuntimeServicesData, EFI_SIZE_TO_PAGES(((UINTN)LCD_VRAM_SIZE)), VramBaseAddress); > if (EFI_ERROR(Status)) { > return Status; > } > -- > 2.7.0 > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel