From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf0-x22d.google.com (mail-lf0-x22d.google.com [IPv6:2a00:1450:4010:c07::22d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id A0F9E81C51 for ; Tue, 8 Nov 2016 09:32:00 -0800 (PST) Received: by mail-lf0-x22d.google.com with SMTP id o141so73078072lff.1 for ; Tue, 08 Nov 2016 09:32:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=2Ol2KOLGFu6IQFrepwM/DVSwjNpcBz9heGwcLE+WxXs=; b=UcB0QQWSmgZl71U+dS5NjadDfUFuhTFAg+0hyXhrX58nDSKJddIyu8pOFsJika41+X 1pDGr8UwvFJlvGCdm4MvXEg6fxGjQLqW+OgsEU4WNIHp+icSC4dtAjxaxgTVIQK9leH0 EVdV/WnKI7mN0uwyEAof3vsN+DQP3GV86tc7s= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=2Ol2KOLGFu6IQFrepwM/DVSwjNpcBz9heGwcLE+WxXs=; b=htvmjEx1TD+Ccal+KuC/RMB17zphRVV/dj7vTBRYCbTnvLRJpPe5QRBkAp/AAdOfkV mfo7vkGJbluSmaC5SABU0utKQJXZBhB4Xc64xatsyYtomsjd+5jziCa/7P4BPqBUxbY3 rNwv8H5LEZNe/lMuXIZ1HsXa0XECj7xP+uB1JLmDOM/QSZP/2ipkNq4QHCrfmLSe40Qr yKgiTXPJQtEzhwkClXCsZ88kZG0JiOVKNqVPaqEYD50bwOoDcCwlxYCvLl2g0L5sSov3 wFshXB3lWcxXq9cdFkq8sg9z1KVxywG0qbzVZXWeLigJ3S3K7/CLs48TGhIVM+DjdeIt 4J5w== X-Gm-Message-State: ABUngvchwYXQv9VRV7BoNrk5oKigpODdLzLjP6aZybycV+f4YddyBuGln4hHO6Do1zH3QdRyAQ5GGXkvJiUHf4N5 X-Received: by 10.25.200.197 with SMTP id y188mr8048970lff.132.1478626321382; Tue, 08 Nov 2016 09:32:01 -0800 (PST) MIME-Version: 1.0 Received: by 10.25.27.68 with HTTP; Tue, 8 Nov 2016 09:32:00 -0800 (PST) In-Reply-To: <1478618476-12608-1-git-send-email-haojian.zhuang@linaro.org> References: <1478618476-12608-1-git-send-email-haojian.zhuang@linaro.org> From: Ryan Harkin Date: Tue, 8 Nov 2016 17:32:00 +0000 Message-ID: To: Haojian Zhuang Cc: edk2-devel-01 , Leif Lindholm , Ard Biesheuvel Subject: Re: [PATCH v4 00/11] enhance MMC X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Nov 2016 17:32:01 -0000 Content-Type: text/plain; charset=UTF-8 Hi Haojian, I've tested your v4 series. On 8 November 2016 at 15:21, Haojian Zhuang wrote: > v4: > * Fix PL180 hang in some cases. Since the proper variable length > isn't set for CMD6 & ACMD51. > > v3: > * Fix PL180 hang because of CMD6 & ACMD51 not supported. > > v2: > * Fix print error with missing parameter. > * Change CMD51 to ACMD51. > * Add the protection after CMD55 for SD. If there's no > response of CMD55, skip to send ACMD51. > > v1: > * Wait OCR busy bit free according to eMMC spec. > * Define ECSD structure. > * Add interface to set IO bus width and speed. > * Support to access multiple blocks. > > Haojian Zhuang (11): > MmcDxe: wait OCR busy bit free > MmcDxe: move ECSD into CardInfo structure > MmcDxe: add SPEC_VERS field in CSD structure > MmcDxe: add interface to change io width and speed > MmcDxe: declare ECSD structure > MmcDxe: set io bus width before reading EXTCSD > MmcDxe: Fix uninitialized mediaid for SD > MmcDxe: set iospeed and bus width in SD stack After this patch is applied, TC2 no longer boots. I can see this patch add support for MMC_ACMD51 > MmcDxe: expand to support multiple blocks > PL180: update for indentifying SD > PL180: set variable length for CMD6 and ACMD51 I can see this patch is fixing the data size for ACMD51. And it is only when this patch is applied that it starts to boot again. So I think they still need to be stacked or squashed differently so they are bisect-able, sorry. > > ArmPlatformPkg/Drivers/PL180MciDxe/PL180Mci.c | 29 +- > EmbeddedPkg/Include/Protocol/MmcHost.h | 29 ++ > EmbeddedPkg/Universal/MmcDxe/Mmc.h | 176 ++++++++++- > EmbeddedPkg/Universal/MmcDxe/MmcBlockIo.c | 175 +++++++---- > EmbeddedPkg/Universal/MmcDxe/MmcIdentification.c | 354 +++++++++++++++++++++-- > 5 files changed, 669 insertions(+), 94 deletions(-) > > -- > 2.7.4 >