From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ryan.harkin@linaro.org>
Received: from mail-lf0-x22f.google.com (mail-lf0-x22f.google.com
 [IPv6:2a00:1450:4010:c07::22f])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by ml01.01.org (Postfix) with ESMTPS id 3785B1A1E91
 for <edk2-devel@lists.01.org>; Tue, 11 Oct 2016 09:27:36 -0700 (PDT)
Received: by mail-lf0-x22f.google.com with SMTP id x79so50471092lff.0
 for <edk2-devel@lists.01.org>; Tue, 11 Oct 2016 09:27:36 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;
 h=mime-version:in-reply-to:references:from:date:message-id:subject:to
 :cc; bh=HMT7GEkm8klOCeB3gpUWZISPSi8jJWbU8VCOjit49Qw=;
 b=bcl8V0L/LalEc+ZV7yLLPtupPN9QOSEkbuZudnx0mDp56l+lGWzoCUCgNGUoNoxP/A
 YfgWeqZHjDxSlNEcgNwTt8qIjQ0o0LJOTWkqYOJiMqJvKVAUYwRbug6CCCs8ZwDE8e0V
 fszyVJaqJi4z76xQaSuMBO+uqlcero1DiZMRo=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:mime-version:in-reply-to:references:from:date
 :message-id:subject:to:cc;
 bh=HMT7GEkm8klOCeB3gpUWZISPSi8jJWbU8VCOjit49Qw=;
 b=flSiWHdm2/Ox21hcGiJj3UbHPQ1dRla/+e5GPkGBMF/2+jwTA5pWg4KJISLjMxsZNH
 ICU/nHrA0Yc/vMTR1WRCsyLN8bwKWbKR47FRqqngowjN1N3JPohx3mohEhrxYoAuF+9I
 Twm7jB/Xa+W9z9C95fPS070SZLsks0DswiPZAr3ef+jgeCXl/SJ9M69hJzBZXFwFdeUJ
 KneKs+wR9T9fdD3K5BU3e9pglrfQjsRBqZyNVBrjZwiFx7ip1bE2Cdla4K8uVkODdXWI
 5omA9c+7aXlLssD1qLx7k5skBu3NSlR1XYiAycH3z4BrLTPFLyrrH/770DXbZkPM1M1Z
 VlWg==
X-Gm-Message-State: AA6/9RkzSXY4qp2lnXGdwAqZ+5UXA5NlD3+pA/xusuJ1ao+6+1P+uNWzDGlD2odKpxieIUrla/VQfKVSe8BfQ5cs
X-Received: by 10.25.139.86 with SMTP id n83mr3769422lfd.72.1476203252928;
 Tue, 11 Oct 2016 09:27:32 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.25.190.83 with HTTP; Tue, 11 Oct 2016 09:27:32 -0700 (PDT)
In-Reply-To: <CAKv+Gu-Mhu0fAe+np1OXdPm5DZG1mN-jB6oTLWNO19i-dUHJnA@mail.gmail.com>
References: <1474470147-23156-1-git-send-email-haojian.zhuang@linaro.org>
 <CAD0U-hJT=HBNbsgiDye03FCoMUAtOaNQ58x=DJ67g61RZpJ5Bw@mail.gmail.com>
 <CAKv+Gu-Mhu0fAe+np1OXdPm5DZG1mN-jB6oTLWNO19i-dUHJnA@mail.gmail.com>
From: Ryan Harkin <ryan.harkin@linaro.org>
Date: Tue, 11 Oct 2016 17:27:32 +0100
Message-ID: <CAD0U-h+GxMnZ1WkG+R=wb=uUYrD1Zz3uLiYy2V5=2ObYzxED9w@mail.gmail.com>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Haojian Zhuang <haojian.zhuang@linaro.org>,
 edk2-devel-01 <edk2-devel@lists.01.org>, 
 Leif Lindholm <leif.lindholm@linaro.org>
Subject: Re: [PATCH v3 00/10] enhance mmc
X-BeenThere: edk2-devel@lists.01.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: EDK II Development  <edk2-devel.lists.01.org>
List-Unsubscribe: <https://lists.01.org/mailman/options/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=unsubscribe>
List-Archive: <http://lists.01.org/pipermail/edk2-devel/>
List-Post: <mailto:edk2-devel@lists.01.org>
List-Help: <mailto:edk2-devel-request@lists.01.org?subject=help>
List-Subscribe: <https://lists.01.org/mailman/listinfo/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=subscribe>
X-List-Received-Date: Tue, 11 Oct 2016 16:27:36 -0000
Content-Type: text/plain; charset=UTF-8

On 11 October 2016 at 17:24, Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote:
> Hi Ryan,
>
> On 11 October 2016 at 17:22, Ryan Harkin <ryan.harkin@linaro.org> wrote:
> [...]
>> And OpenPlatformPkg was taken from my repo, which only carries one
>> patch essential for TC2 booting:
>>   c22a665  2016-01-29  HACK: Platforms/ARM: TC2: set
>> gArmTokenSpaceGuid.PcdNormalMemoryNonshareableOverride TRUE  [Ryan
>> Harkin]
>
> Shouldn't we simply merge that patch?

I think Leif said no, back when TC2 broken in mainline.

The commit that broke it was 0c9a522f28772049ae37c85b8ae589a98d2d3b81
"ArmPkg/ArmLib: mark all cached mappings as (inner) shareable".  IIRC
Leif said there is something wrong with the TC2 setup code meaning
that we need to set the PCD, even though we shouldn't need to.

And I've never had time to work it out, so I've just carried the patch.