From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf0-x230.google.com (mail-lf0-x230.google.com [IPv6:2a00:1450:4010:c07::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 114F81A1E6F for ; Wed, 12 Oct 2016 01:37:52 -0700 (PDT) Received: by mail-lf0-x230.google.com with SMTP id l131so33371118lfl.2 for ; Wed, 12 Oct 2016 01:37:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=a+vnrSopga/oY6OtEkeLjaol1ee4c5SFoxje4tVPz3I=; b=XS6HW1brODpZlBNYcMufgVDuteTC0mg1WdHbNhY5VQdc3MWfkPcEwcbEipSVbqt1Ub 2b2SMOrpAadyPEU3aaaqNums2ixDRrUFnMFMQkMaZyERSKrkkn8fhN+eEos98qEQGpd/ 0P22XmeiYWMY8d4pZN7K14xKDsgeKKW6/6Xbk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=a+vnrSopga/oY6OtEkeLjaol1ee4c5SFoxje4tVPz3I=; b=gFmRQ5XxhzomlF1qFHfGufam3cRupDoBRbbpK+OE3iECyiQhFwMgsltrUgu6J70LSJ Py2ENY0XnHa9gqrv6QExBXl6ePw1c70IK67GgK44c2gKgHMy1W78h+hLF9qq1fdM36fJ YB04MWA2OHEWyWZ3OXYo3X0Ig5QjR8PjQXbiKbO2iVEMT8gpRnDvWWLf70lso7tMAHrV /czP+5g6aD9+WPXrEXVcyIgd+XMH4SMj8aJjwmRCzhDcFdhUpSkIposSwVQgvgCOGBH8 r3BAnD9YgIAA6zk8XrvKBVE6e+9YN5pAOIxKt7G8k41x6tWKavM8cnQJIz+dVNPitG5G 3FDg== X-Gm-Message-State: AA6/9Rl7r/kc0l+E4IPeZw5eDi4LV2qT+IibQYalTsy77mJzQVnQ3FV9X/j3QfmQ6t8J7/X+Yuv7HgdWtHeAARM6 X-Received: by 10.25.7.201 with SMTP id 192mr6495387lfh.170.1476261470272; Wed, 12 Oct 2016 01:37:50 -0700 (PDT) MIME-Version: 1.0 Received: by 10.25.190.83 with HTTP; Wed, 12 Oct 2016 01:37:49 -0700 (PDT) In-Reply-To: References: <1474583581-41663-1-git-send-email-daniil.egranov@arm.com> <1474583581-41663-3-git-send-email-daniil.egranov@arm.com> From: Ryan Harkin Date: Wed, 12 Oct 2016 09:37:49 +0100 Message-ID: To: Ard Biesheuvel Cc: Daniil Egranov , "edk2-devel@lists.01.org" , Leif Lindholm Subject: Re: [PATCH 2/2] ArmPlatformPkg/ArmJunoPkg/Drivers/PciHostBridgeDxe: Fix for PCI Dual Address Cycle X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Oct 2016 08:37:52 -0000 Content-Type: text/plain; charset=UTF-8 On 23 September 2016 at 08:58, Ard Biesheuvel wrote: > On 22 September 2016 at 23:33, Daniil Egranov wrote: >> The fix handles the PCI Dual Address Cycle Attribute case. It allows >> drivers using PCI DAC run on Juno. >> >> Contributed-under: TianoCore Contribution Agreement 1.0 >> Signed-off-by: Daniil Egranov > > Reviewed-by: Ard Biesheuvel > Tested on Juno R0/1/2, where R0 doesn't use the Marvell ethernet controller, but the SMC ethernet still works. Tested-by: Ryan Harkin >> --- >> .../ArmJunoPkg/Drivers/PciHostBridgeDxe/PciRootBridge.c | 9 ++++++--- >> 1 file changed, 6 insertions(+), 3 deletions(-) >> >> diff --git a/ArmPlatformPkg/ArmJunoPkg/Drivers/PciHostBridgeDxe/PciRootBridge.c b/ArmPlatformPkg/ArmJunoPkg/Drivers/PciHostBridgeDxe/PciRootBridge.c >> index 10a4575..72d0915 100644 >> --- a/ArmPlatformPkg/ArmJunoPkg/Drivers/PciHostBridgeDxe/PciRootBridge.c >> +++ b/ArmPlatformPkg/ArmJunoPkg/Drivers/PciHostBridgeDxe/PciRootBridge.c >> @@ -518,11 +518,14 @@ PciRbMap ( >> >> PCI_TRACE ("PciRbMap()"); >> >> - if (Operation == EfiPciOperationBusMasterRead) { >> + if (Operation == EfiPciOperationBusMasterRead || >> + Operation == EfiPciOperationBusMasterRead64) { >> DmaOperation = MapOperationBusMasterRead; >> - } else if (Operation == EfiPciOperationBusMasterWrite) { >> + } else if (Operation == EfiPciOperationBusMasterWrite || >> + Operation == EfiPciOperationBusMasterWrite64) { >> DmaOperation = MapOperationBusMasterWrite; >> - } else if (Operation == EfiPciOperationBusMasterCommonBuffer) { >> + } else if (Operation == EfiPciOperationBusMasterCommonBuffer || >> + Operation == EfiPciOperationBusMasterCommonBuffer64) { >> DmaOperation = MapOperationBusMasterCommonBuffer; >> } else { >> return EFI_INVALID_PARAMETER; >> -- >> 2.7.4 >> >> _______________________________________________ >> edk2-devel mailing list >> edk2-devel@lists.01.org >> https://lists.01.org/mailman/listinfo/edk2-devel > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel