From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt0-x234.google.com (mail-qt0-x234.google.com [IPv6:2607:f8b0:400d:c0d::234]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 7B70421942335 for ; Thu, 6 Apr 2017 04:14:11 -0700 (PDT) Received: by mail-qt0-x234.google.com with SMTP id i34so32926313qtc.0 for ; Thu, 06 Apr 2017 04:14:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=Z5Wom66/yXWS2qlsYvEAhCTwIa1Qbhh2qdDlHz9Nmbs=; b=ffyFiYAGgQMRWZ0dMbU+3ileiB3tIE9tlsPJo/PYGa0FIsY7SkhYstjRpLcwxKPN7B Tmdumeo2UhMNeQ90DqxVFHzUpHJfb6tgRhjgisJsxb8W6VxfjDoZr0lvhx+NlUX5k6ND C9uTSVqslzmJDkXBL4MygBLMh18uUds67cS/0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=Z5Wom66/yXWS2qlsYvEAhCTwIa1Qbhh2qdDlHz9Nmbs=; b=Jamy5U8z1tvfwmEVilBzlhvBn5YbzlfnjMRzovKTM43VItsBL+JqvIHt+W1Ht35pi1 zkHLwIRFNsrHSlzG9H8XaX0fH16umC/ILkIWFzohmjlNDCVfBWrOe/I0P5rMAg+eVLtG p6gvlQ07k5fCzdJV+miO8JYU4V2DfwEFwe9yWMjWO8k0EgykbE0mr2zx7F8ORf9FeFgP V3H/MzaXkV+DEYYZLAj7mBBbSCxjgvHYrT1DTylLT67yVYiNT1ojb0g2HQLoTJYX8rVR FrMovU3nZNHs5DZu8Q25n98NtsUXagTJ+TB3TAH8xWgq+mCqNb010NZWYmacpQOv/JMv Fnag== X-Gm-Message-State: AFeK/H0ZkgdZChtA6j69eDz4/UajZ38aQUlN3FBi1SU0n3QXik+r4wxQQanp8oxV1ntGk9+1HpaFvDICAK0ZDma2 X-Received: by 10.237.63.39 with SMTP id p36mr32315690qtf.187.1491477250546; Thu, 06 Apr 2017 04:14:10 -0700 (PDT) MIME-Version: 1.0 Received: by 10.140.36.138 with HTTP; Thu, 6 Apr 2017 04:14:09 -0700 (PDT) In-Reply-To: <1491424713-5203-2-git-send-email-ard.biesheuvel@linaro.org> References: <1491424713-5203-1-git-send-email-ard.biesheuvel@linaro.org> <1491424713-5203-2-git-send-email-ard.biesheuvel@linaro.org> From: Ryan Harkin Date: Thu, 6 Apr 2017 12:14:09 +0100 Message-ID: To: Ard Biesheuvel Cc: "edk2-devel@lists.01.org" , Leif Lindholm , Jeremy Linton Subject: Re: [PATCH 2/2] ArmPlatformPkg/PL111LcdArmVExpressLib: use write-combine mapping for VRAM X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Apr 2017 11:14:11 -0000 Content-Type: text/plain; charset=UTF-8 On 5 April 2017 at 21:38, Ard Biesheuvel wrote: > Replace the uncached memory mapping of the framebuffer with a write- > combining one. This improves performance, and avoids issues with > unaligned accesses and DC ZVA instructions performed by the accelerated > memcpy/memset routines. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ard Biesheuvel Well, ... PL111 isn't usually enabled for me. And if I enable it, neither Foundation nor AEMv8 models boot with or without this patch. So it's no worse than before.... > --- > ArmPlatformPkg/ArmVExpressPkg/Library/PL111LcdArmVExpressLib/PL111LcdArmVExpress.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/ArmPlatformPkg/ArmVExpressPkg/Library/PL111LcdArmVExpressLib/PL111LcdArmVExpress.c b/ArmPlatformPkg/ArmVExpressPkg/Library/PL111LcdArmVExpressLib/PL111LcdArmVExpress.c > index 2000c9bdf436..d18d6b3e1665 100644 > --- a/ArmPlatformPkg/ArmVExpressPkg/Library/PL111LcdArmVExpressLib/PL111LcdArmVExpress.c > +++ b/ArmPlatformPkg/ArmVExpressPkg/Library/PL111LcdArmVExpressLib/PL111LcdArmVExpress.c > @@ -192,7 +192,7 @@ LcdPlatformGetVram ( > ASSERT_EFI_ERROR(Status); > > // Mark the VRAM as un-cachable. The VRAM is inside the DRAM, which is cachable. > - Status = Cpu->SetMemoryAttributes(Cpu, *VramBaseAddress, *VramSize, EFI_MEMORY_UC); > + Status = Cpu->SetMemoryAttributes(Cpu, *VramBaseAddress, *VramSize, EFI_MEMORY_WC); > ASSERT_EFI_ERROR(Status); > if (EFI_ERROR(Status)) { > gBS->FreePool(VramBaseAddress); > -- > 2.7.4 > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel