From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf0-x231.google.com (mail-lf0-x231.google.com [IPv6:2a00:1450:4010:c07::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id E6C0A1A1E30 for ; Tue, 11 Oct 2016 10:03:54 -0700 (PDT) Received: by mail-lf0-x231.google.com with SMTP id x79so52391586lff.0 for ; Tue, 11 Oct 2016 10:03:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=upMIPjKYfWuTTeiRgMDQor2L+XDJpTBvD5aSriU6MMo=; b=I8xblFHGi24dAT1A9kmWCdzBz0F07sw8YYqCucGoDTcsurPR53O2mqfHzWwTBboMgo MCDrcM6Jbhu/9rw6tizqKbOKrPcO7NajTp5lTmRNP9eSVGxYCUqt3Zb9xR1/+FX7smP7 tzt8Fd9Yi85GptoRd9tZjmJRYtkK8rz9L1NCs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=upMIPjKYfWuTTeiRgMDQor2L+XDJpTBvD5aSriU6MMo=; b=M5Op36bQk7RpIcu0pZrMDh0+eMNhpPCK2z1RvBSLr021kWbR7zBHAZwbMtXl8+YGnI +g3uwkU3CFAwXA/huvIIGt8YzHmNU1lXxaTxr+30YWkuQowW29l2MZwX6eRwV3BfEsAl nH+YwpaVE+iCagDlh36ZZLhuGZrOHsl3/813u/KprJiM3tODcibLyiBtSDNdM41VUukE oJ/SEYlKW82PhwtEmnjDbg5tYzr13ks6wL3kd9pc5SHI1edPKD0Cukk8vceXBQFpoNrR XQ4fNoXBSV1H6GrjFvUIdh65Mv46ijLpLpi2JyyoTlJNSpl7viF5FCup3wtx7I44/9bb dWlw== X-Gm-Message-State: AA6/9RlHm7AhANV2jk29LS7PccFyw7sJ7mtyxqUY434tBHHc+zY5wE9LmFri7kEctE676Miwrzlt/Rj9qhskNsig X-Received: by 10.25.221.20 with SMTP id u20mr3930231lfg.1.1476205432325; Tue, 11 Oct 2016 10:03:52 -0700 (PDT) MIME-Version: 1.0 Received: by 10.25.190.83 with HTTP; Tue, 11 Oct 2016 10:03:51 -0700 (PDT) In-Reply-To: References: <1474470147-23156-1-git-send-email-haojian.zhuang@linaro.org> From: Ryan Harkin Date: Tue, 11 Oct 2016 18:03:51 +0100 Message-ID: To: Ard Biesheuvel Cc: Haojian Zhuang , edk2-devel-01 , Leif Lindholm Subject: Re: [PATCH v3 00/10] enhance mmc X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Oct 2016 17:03:55 -0000 Content-Type: text/plain; charset=UTF-8 On 11 October 2016 at 17:28, Ard Biesheuvel wrote: > On 11 October 2016 at 17:27, Ryan Harkin wrote: >> On 11 October 2016 at 17:24, Ard Biesheuvel wrote: >>> Hi Ryan, >>> >>> On 11 October 2016 at 17:22, Ryan Harkin wrote: >>> [...] >>>> And OpenPlatformPkg was taken from my repo, which only carries one >>>> patch essential for TC2 booting: >>>> c22a665 2016-01-29 HACK: Platforms/ARM: TC2: set >>>> gArmTokenSpaceGuid.PcdNormalMemoryNonshareableOverride TRUE [Ryan >>>> Harkin] >>> >>> Shouldn't we simply merge that patch? >> >> I think Leif said no, back when TC2 broken in mainline. >> >> The commit that broke it was 0c9a522f28772049ae37c85b8ae589a98d2d3b81 >> "ArmPkg/ArmLib: mark all cached mappings as (inner) shareable". IIRC >> Leif said there is something wrong with the TC2 setup code meaning >> that we need to set the PCD, even though we shouldn't need to. >> >> And I've never had time to work it out, so I've just carried the patch. > > Ah right, I remember now. And if I'd looked further down my HACK commit, I'd have seen this text explaining what happened: However, the topic was discussed on the mailing list: https://www.mail-archive.com/edk2-devel@lists.01.org/msg03974.html The correct solution for platforms that wish to revert this behaviour is to set the following PCD to TRUE: gArmTokenSpaceGuid.PcdNormalMemoryNonshareableOverride However, for TC2 should not need to do this. Work continues to ascertain why TC2 breaks with shareable mappings. Current thinking is that CCI-400 needs configuring before shareable mappings will work. :-)