From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf0-x22d.google.com (mail-lf0-x22d.google.com [IPv6:2a00:1450:4010:c07::22d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id ECACC1A1E30 for ; Tue, 11 Oct 2016 22:32:39 -0700 (PDT) Received: by mail-lf0-x22d.google.com with SMTP id x79so64947632lff.0 for ; Tue, 11 Oct 2016 22:32:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=/TGdHV5Fk6zRoAMsh3rw6liTmE8C+h6aCMA9Jro9DqI=; b=ddBWo3bay8qM5JxKGmV09b4kvwGYDo1OS6nrnyV64/i0hBuU0vf7T8f8Hhbl4+YW7x o9UBMWH3EkpD65EtdBTqD4A7dJoQ9nSyE7UnjBDD98mFSBMlV2RzjhhFttq7FT1nMcRn BzqAY/2/Wo3ylqwmIcLwwwpUPtDeMObsnvy6s= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=/TGdHV5Fk6zRoAMsh3rw6liTmE8C+h6aCMA9Jro9DqI=; b=OSKq2gfNPY5PZPbuARiGlpXivwHtemdXOxqTFJDRoSNvz3u2N+Z/f306JEjC4iBGWO FgDlX9z7ds9Rl7/v8JgnNLX5ouo7KwdtGfCtRpV5bENGhnw/H8/68ABXq+zMdo8F6BNn yfcCLnKTZtmeY7im+ce/5D+Sgz567FoQs8VqObQoK+Rfwt109gU9AwwXlnkPTvhPeD9A /OYt9A0CLkgot5UbwtZhrwNEoQO3xm1hpSdRfwuG9KDiGRa2R60bVWRaL3LpUc8X5g0R ZLOI/tFtX0dbncxsjpKVvD81ZBmIKRLlWNc3mT+0wwZBrVt280rndXMvRoKkn8tfMcLp GZ+Q== X-Gm-Message-State: AA6/9RlLR7zF0nOZ7on0cVnvfJUdou4TrK3uvJUQ0YeEssnE2N8U7d/Ueo49AfYJ5Y0vOdlgcCLAobBUuCEtebem X-Received: by 10.25.166.145 with SMTP id p139mr5790110lfe.132.1476250357655; Tue, 11 Oct 2016 22:32:37 -0700 (PDT) MIME-Version: 1.0 Received: by 10.25.190.83 with HTTP; Tue, 11 Oct 2016 22:32:36 -0700 (PDT) Received: by 10.25.190.83 with HTTP; Tue, 11 Oct 2016 22:32:36 -0700 (PDT) In-Reply-To: References: <1474470147-23156-1-git-send-email-haojian.zhuang@linaro.org> From: Ryan Harkin Date: Wed, 12 Oct 2016 06:32:36 +0100 Message-ID: To: Haojian Zhuang Cc: Leif Lindholm , edk2-devel-01 , Ard Biesheuvel X-Content-Filtered-By: Mailman/MimeDel 2.1.21 Subject: Re: [PATCH v3 00/10] enhance mmc X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Oct 2016 05:32:40 -0000 Content-Type: text/plain; charset=UTF-8 On 12 Oct 2016 00:33, "Haojian Zhuang" wrote: > > On 12 October 2016 at 01:03, Ryan Harkin wrote: > > On 11 October 2016 at 17:28, Ard Biesheuvel wrote: > >> On 11 October 2016 at 17:27, Ryan Harkin wrote: > >>> On 11 October 2016 at 17:24, Ard Biesheuvel wrote: > >>>> Hi Ryan, > >>>> > >>>> On 11 October 2016 at 17:22, Ryan Harkin wrote: > >>>> [...] > >>>>> And OpenPlatformPkg was taken from my repo, which only carries one > >>>>> patch essential for TC2 booting: > >>>>> c22a665 2016-01-29 HACK: Platforms/ARM: TC2: set > >>>>> gArmTokenSpaceGuid.PcdNormalMemoryNonshareableOverride TRUE [Ryan > >>>>> Harkin] > >>>> > >>>> Shouldn't we simply merge that patch? > >>> > >>> I think Leif said no, back when TC2 broken in mainline. > >>> > >>> The commit that broke it was 0c9a522f28772049ae37c85b8ae589a98d2d3b81 > >>> "ArmPkg/ArmLib: mark all cached mappings as (inner) shareable". IIRC > >>> Leif said there is something wrong with the TC2 setup code meaning > >>> that we need to set the PCD, even though we shouldn't need to. > >>> > >>> And I've never had time to work it out, so I've just carried the patch. > >> > >> Ah right, I remember now. > > > > And if I'd looked further down my HACK commit, I'd have seen this text > > explaining what happened: > > > > However, the topic was discussed on the mailing list: > > > > https://www.mail-archive.com/edk2-devel@lists.01.org/msg03974.html > > > > The correct solution for platforms that wish to revert this behaviour > > is to set the following PCD to TRUE: > > > > gArmTokenSpaceGuid.PcdNormalMemoryNonshareableOverride > > > > However, for TC2 should not need to do this. Work continues to > > ascertain why TC2 breaks with shareable mappings. Current thinking is > > that CCI-400 needs configuring before shareable mappings will work. > > > > :-) > > Hi Ryan, > > Does it mean that you'll give the fix configuration of CCI-400 on TC2 > in upstream? > It means I *should* configure it, but I've not looked at it at all and have no plans to look at it in the near future. > Best Regards > Haojian