From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf0-x22f.google.com (mail-lf0-x22f.google.com [IPv6:2a00:1450:4010:c07::22f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 386451A1EDD for ; Wed, 7 Sep 2016 07:00:20 -0700 (PDT) Received: by mail-lf0-x22f.google.com with SMTP id h127so11626248lfh.0 for ; Wed, 07 Sep 2016 07:00:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=SAiiZD6YS7kTSvQO3dFiRYR8gMQrrFLUdDJjcETdv/k=; b=g5QDNtH49jN2HZBGhm9QAcCheZs2EdTyI4GadZQ0j321WB8KYlYHbsLSPlpuSZqbEa xs/xqohxrkqPX4Qbp67uNE/SCJGuHbJMqwmuDDgCPwXr1+zEh/iGt+exolMzgQhc7kbN KRL+aHE5/dP7ifRYQVY+4HWJgQ43cKPnX7PRo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=SAiiZD6YS7kTSvQO3dFiRYR8gMQrrFLUdDJjcETdv/k=; b=gPyml7zDEK4Kfwwt8oeK1k5YErjqPaCMgdXaHBfi5nmyhLxFVtXRHjCyfCp8AQb7dp vCZqQslAYfOAHAnHGmxZyKHuvXsibMqqvCdcDAtEre+86ucFqhxQfQJd+KeznU6Is2h6 mPfNC55MkRC9d2l4t7W0/JPwdhk12XcHqdHU6Mgn0Ar8NR+lNOosA7zaQGI8Fri/Bah3 ZqmPazuaZyxKeq/BV8kCeqRrKX7fPNE8PBd3tg7uKkuig4LV59zDc/vuTeSjrw7LvDEN Dkxfb7dB/qXNPfLwWgugWUzNeHR/WbBDxTqPk2lAju83QvVUqsPliyHVBEB9km+2KIiC lTNg== X-Gm-Message-State: AE9vXwOJ0rk5GjdDUMigXh8L8uYGvAtA4/T7lA9BQh78cKUmffQCkLXDeFXPL+tsBdy/eUorSrWG1RLcbspsliiw X-Received: by 10.46.33.151 with SMTP id h23mr12660482lji.38.1473256817987; Wed, 07 Sep 2016 07:00:17 -0700 (PDT) MIME-Version: 1.0 Received: by 10.25.19.106 with HTTP; Wed, 7 Sep 2016 07:00:17 -0700 (PDT) In-Reply-To: References: From: Ryan Harkin Date: Wed, 7 Sep 2016 15:00:17 +0100 Message-ID: To: Ard Biesheuvel Cc: Michael Zimmermann , "edk2-devel@lists.01.org" , Leif Lindholm Subject: Re: [PATCH] ArmPlatformPkg/PrePi: fix secondary stack base X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Sep 2016 14:00:20 -0000 Content-Type: text/plain; charset=UTF-8 On 7 September 2016 at 13:17, Ard Biesheuvel wrote: > On 7 September 2016 at 13:06, Michael Zimmermann > wrote: >> this bug was introduced by: >> d2fa09a ArmPlatformPkg/PrePi: switch to ASM_FUNC() asm macro >> >> Contributed-under: TianoCore Contribution Agreement 1.0 >> Signed-off-by: M1cha >> --- >> ArmPlatformPkg/PrePi/Arm/ModuleEntryPoint.S | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/ArmPlatformPkg/PrePi/Arm/ModuleEntryPoint.S >> b/ArmPlatformPkg/PrePi/Arm/ModuleEntryPoint.S >> index b7127ce..39030da 100644 >> --- a/ArmPlatformPkg/PrePi/Arm/ModuleEntryPoint.S >> +++ b/ArmPlatformPkg/PrePi/Arm/ModuleEntryPoint.S >> @@ -101,7 +101,7 @@ _GetStackBase: >> sub r10, r1, r2 >> >> // Stack for the secondary core = Number of Cores - 1 >> - MOV32 (r0, (FixedPcdGet32(PcdCoreCount) - 1) * >> FixedPcdGet32(PcdCPUCoreSecondaryStackSize)) >> + MOV32 (r1, (FixedPcdGet32(PcdCoreCount) - 1) * >> FixedPcdGet32(PcdCPUCoreSecondaryStackSize)) >> sub r10, r10, r1 >> >> // r10 = The base of the MpCore Stacks (primary stack & secondary stacks) >> -- >> 2.9.3 >> > > Pushed, thanks Excellent! Thanks both :-)