* [PATCH] ArmPlatformPkg/PrePi: fix secondary stack base
@ 2016-09-07 12:06 Michael Zimmermann
2016-09-07 12:17 ` Ard Biesheuvel
0 siblings, 1 reply; 3+ messages in thread
From: Michael Zimmermann @ 2016-09-07 12:06 UTC (permalink / raw)
To: edk2-devel@lists.01.org, Ard Biesheuvel, Leif Lindholm,
Ryan Harkin
this bug was introduced by:
d2fa09a ArmPlatformPkg/PrePi: switch to ASM_FUNC() asm macro
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: M1cha <sigmaepsilon92@gmail.com>
---
ArmPlatformPkg/PrePi/Arm/ModuleEntryPoint.S | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ArmPlatformPkg/PrePi/Arm/ModuleEntryPoint.S
b/ArmPlatformPkg/PrePi/Arm/ModuleEntryPoint.S
index b7127ce..39030da 100644
--- a/ArmPlatformPkg/PrePi/Arm/ModuleEntryPoint.S
+++ b/ArmPlatformPkg/PrePi/Arm/ModuleEntryPoint.S
@@ -101,7 +101,7 @@ _GetStackBase:
sub r10, r1, r2
// Stack for the secondary core = Number of Cores - 1
- MOV32 (r0, (FixedPcdGet32(PcdCoreCount) - 1) *
FixedPcdGet32(PcdCPUCoreSecondaryStackSize))
+ MOV32 (r1, (FixedPcdGet32(PcdCoreCount) - 1) *
FixedPcdGet32(PcdCPUCoreSecondaryStackSize))
sub r10, r10, r1
// r10 = The base of the MpCore Stacks (primary stack & secondary stacks)
--
2.9.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ArmPlatformPkg/PrePi: fix secondary stack base
2016-09-07 12:06 [PATCH] ArmPlatformPkg/PrePi: fix secondary stack base Michael Zimmermann
@ 2016-09-07 12:17 ` Ard Biesheuvel
2016-09-07 14:00 ` Ryan Harkin
0 siblings, 1 reply; 3+ messages in thread
From: Ard Biesheuvel @ 2016-09-07 12:17 UTC (permalink / raw)
To: Michael Zimmermann; +Cc: edk2-devel@lists.01.org, Leif Lindholm, Ryan Harkin
On 7 September 2016 at 13:06, Michael Zimmermann
<sigmaepsilon92@gmail.com> wrote:
> this bug was introduced by:
> d2fa09a ArmPlatformPkg/PrePi: switch to ASM_FUNC() asm macro
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: M1cha <sigmaepsilon92@gmail.com>
> ---
> ArmPlatformPkg/PrePi/Arm/ModuleEntryPoint.S | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/ArmPlatformPkg/PrePi/Arm/ModuleEntryPoint.S
> b/ArmPlatformPkg/PrePi/Arm/ModuleEntryPoint.S
> index b7127ce..39030da 100644
> --- a/ArmPlatformPkg/PrePi/Arm/ModuleEntryPoint.S
> +++ b/ArmPlatformPkg/PrePi/Arm/ModuleEntryPoint.S
> @@ -101,7 +101,7 @@ _GetStackBase:
> sub r10, r1, r2
>
> // Stack for the secondary core = Number of Cores - 1
> - MOV32 (r0, (FixedPcdGet32(PcdCoreCount) - 1) *
> FixedPcdGet32(PcdCPUCoreSecondaryStackSize))
> + MOV32 (r1, (FixedPcdGet32(PcdCoreCount) - 1) *
> FixedPcdGet32(PcdCPUCoreSecondaryStackSize))
> sub r10, r10, r1
>
> // r10 = The base of the MpCore Stacks (primary stack & secondary stacks)
> --
> 2.9.3
>
Pushed, thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ArmPlatformPkg/PrePi: fix secondary stack base
2016-09-07 12:17 ` Ard Biesheuvel
@ 2016-09-07 14:00 ` Ryan Harkin
0 siblings, 0 replies; 3+ messages in thread
From: Ryan Harkin @ 2016-09-07 14:00 UTC (permalink / raw)
To: Ard Biesheuvel; +Cc: Michael Zimmermann, edk2-devel@lists.01.org, Leif Lindholm
On 7 September 2016 at 13:17, Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote:
> On 7 September 2016 at 13:06, Michael Zimmermann
> <sigmaepsilon92@gmail.com> wrote:
>> this bug was introduced by:
>> d2fa09a ArmPlatformPkg/PrePi: switch to ASM_FUNC() asm macro
>>
>> Contributed-under: TianoCore Contribution Agreement 1.0
>> Signed-off-by: M1cha <sigmaepsilon92@gmail.com>
>> ---
>> ArmPlatformPkg/PrePi/Arm/ModuleEntryPoint.S | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/ArmPlatformPkg/PrePi/Arm/ModuleEntryPoint.S
>> b/ArmPlatformPkg/PrePi/Arm/ModuleEntryPoint.S
>> index b7127ce..39030da 100644
>> --- a/ArmPlatformPkg/PrePi/Arm/ModuleEntryPoint.S
>> +++ b/ArmPlatformPkg/PrePi/Arm/ModuleEntryPoint.S
>> @@ -101,7 +101,7 @@ _GetStackBase:
>> sub r10, r1, r2
>>
>> // Stack for the secondary core = Number of Cores - 1
>> - MOV32 (r0, (FixedPcdGet32(PcdCoreCount) - 1) *
>> FixedPcdGet32(PcdCPUCoreSecondaryStackSize))
>> + MOV32 (r1, (FixedPcdGet32(PcdCoreCount) - 1) *
>> FixedPcdGet32(PcdCPUCoreSecondaryStackSize))
>> sub r10, r10, r1
>>
>> // r10 = The base of the MpCore Stacks (primary stack & secondary stacks)
>> --
>> 2.9.3
>>
>
> Pushed, thanks
Excellent! Thanks both :-)
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-09-07 14:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-07 12:06 [PATCH] ArmPlatformPkg/PrePi: fix secondary stack base Michael Zimmermann
2016-09-07 12:17 ` Ard Biesheuvel
2016-09-07 14:00 ` Ryan Harkin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox