From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf0-x22e.google.com (mail-lf0-x22e.google.com [IPv6:2a00:1450:4010:c07::22e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 438E71A1E30 for ; Wed, 12 Oct 2016 01:17:59 -0700 (PDT) Received: by mail-lf0-x22e.google.com with SMTP id x79so67620468lff.0 for ; Wed, 12 Oct 2016 01:17:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=UKO3GP+KrLZGWSX4W1FJN0ZQN/TIOra2uyi1/+0WsSM=; b=SI50K8pY+oHW2PnaiqNqXE/klS/iMQcfmnHTsI7JaT4vZ6FA6YOqA/TFjBPwz6u6lL 5V6O2FZiXZ6fRu7wDkQY6EqWquttTVqYQ7j+Ulg7wep15wQigN2X/HZf2y397XVx0ULZ yfd5UE6kNWVfzDoUJmG2FBl0MwgVgjHRfgdYU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=UKO3GP+KrLZGWSX4W1FJN0ZQN/TIOra2uyi1/+0WsSM=; b=EUpC5CYP8zPJn/9iShrJwEZX4YoRWBgflQFjF0pYhVphPvCDoXdb/YOLZEYlvOI89a oOva/Tem5riFi8E1WTFJL0Pk1V0xuLPlIYhCbLrFuby091T4/W6D0orVvDGAOr6bXTt9 hrySzRtgqSuBRgXi5BIgY957adqZJjIXr4Cg5xS5QXmowSCGZwhutrQOMlGiypRLNV/B IdZwOJ3qnNvux3W54bjbmiLyvDaDWpxhMuJPyND+n5IVQhXFIv8+tF6S3H0PkeA1Fbw+ hfATY+IP0cI7XntP50T48TByKhr0lVIdTRuMsbGaU95G0neJ+/Eh19C7zt1Sy2o7bsFp R8KQ== X-Gm-Message-State: AA6/9RnLECk/srrRNNSITXxdjb47wJwPMgI2oIc58gg2OyrRqhayS+4o9kaKsLIuaAdULq6FMR8ht26CWGoHGQ6i X-Received: by 10.25.37.18 with SMTP id l18mr6553754lfl.88.1476260277412; Wed, 12 Oct 2016 01:17:57 -0700 (PDT) MIME-Version: 1.0 Received: by 10.25.190.83 with HTTP; Wed, 12 Oct 2016 01:17:56 -0700 (PDT) In-Reply-To: <20161007155942.GD3471@bivouac.eciton.net> References: <20161007155942.GD3471@bivouac.eciton.net> From: Ryan Harkin Date: Wed, 12 Oct 2016 09:17:56 +0100 Message-ID: To: Leif Lindholm Cc: Laszlo Ersek , Roy Franz , "Brian J. Johnson" , "edk2-devel@lists.01.org" , Feng Tian , Star Zeng Subject: Re: [PATCH 0/3] MdeModulePkg/TerminalDxe: TtyTerm improvements X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Oct 2016 08:17:59 -0000 Content-Type: text/plain; charset=UTF-8 On 7 October 2016 at 16:59, Leif Lindholm wrote: > Roy can now be found at Roy Franz (cc:d). > > On Fri, Oct 07, 2016 at 05:56:26PM +0200, Laszlo Ersek wrote: >> Roy, Ryan, >> >> On 10/07/16 16:53, Brian J. Johnson wrote: >> > This patch series implements some improvements to the TtyTerm terminal >> > type in the TerminalDxe driver. It fixes an end case with cursor >> > position tracking, and uses that to optimize cursor motion escape >> > sequences. It also adds support for the page up, page down, insert, >> > home, and end keys on some additional common terminal emulators. >> > >> > The result is improved performance, especially at the shell prompt, >> > and better compatibility with common terminal emulators. In >> > particular, as a side effect of the optimized cursor motion, terminal >> > windows which are taller than the current mode setting (eg. 25 lines) >> > work much better than before. >> > >> > Most of these fixes have been in production in some form on SGI's >> > servers for years. >> > >> > Contributed-under: TianoCore Contribution Agreement 1.0 >> > Signed-off-by: Brian Johnson >> > Cc: Feng Tian >> > Cc: Star Zeng >> > >> > Brian J. Johnson (3): >> > MdeModulePkg/TerminalDxe: Improve TtyTerm cursor position tracking >> > MdeModulePkg/TerminalDxe: Optimize TtyTerm cursor motion >> > MdeModulePkg/TerminalDxe: Handle more keys with TtyTerm >> > >> > .../Universal/Console/TerminalDxe/Terminal.h | 2 + >> > .../Universal/Console/TerminalDxe/TerminalConIn.c | 24 +++++++-- >> > .../Universal/Console/TerminalDxe/TerminalConOut.c | 61 ++++++++++++++++++++-- >> > 3 files changed, 79 insertions(+), 8 deletions(-) >> > >> >> can you please provide feedback (testing or otherwise) on this series? >> Well, they "work" for me and I'd be happy with them being submitted. Tested-by: Ryan Harkin The only curious effect I can see is the Print(L"xxx"); lines that expect the \n to be missing will no longer "work". For example, I carry a patch by Daniil Egranov titled "IntelFrameworkModulePkg/BdsDxe: Show boot timeout message" and it no longer displays the countdown on the same line each time, it prints each message on a new line. However, I don't see that as a blocking point, Daniil's patch could be changed easily and there are other advantages to this series that make it worthwhile, IMO, eg, Shell commands with lots of output (like "help" or "dir fs0:") no longer create an awful mess on the serial console. >> Thanks >> Laszlo >> _______________________________________________ >> edk2-devel mailing list >> edk2-devel@lists.01.org >> https://lists.01.org/mailman/listinfo/edk2-devel