Re: [PATCH v4] ArmPlatformPkg/ArmJunoPkg/Drivers/ArmJunoDxe: Set Marvell Yukon MAC address

[Ryan Harkin <ryan.harkin@linaro.org>]

On 11 January 2017 at 11:45, Ryan Harkin <ryan.harkin@linaro.org> wrote:
> On 10 January 2017 at 22:36, Leif Lindholm <leif.lindholm@linaro.org> wrote:
>> On Mon, Jan 09, 2017 at 03:20:51PM -0600, Daniil Egranov wrote:
>>> From: Daniil Egranov <daniil.egranov@linaro.org>
>>>
>>> The patch reads a valid MAC address form the Juno IOFPGA registers
>>> and pushes it into onboard Marvell Yukon NIC.
>>>
>>> Contributed-under: TianoCore Contribution Agreement 1.0
>>> Signed-off-by: Daniil Egranov <daniil.egranov@linaro.org>
>>
>> Thanks for sticking with it.
>>
>> I fixed a typo in commit message an shortened the subject line
>> slightly, but:
>> Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
>> Pushed as a8675a1
>>
>
> Excellent, another patch in my fork that can go.
>

Unfortunately, while this works on Juno R1 and R2, it hangs R0 every time:

ASSERT [ArmJunoDxe]
/linaro/platforms/uefi/edk2/ArmPlatformPkg/ArmJunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.c(397):
!EFI_ERROR (Status)

I guess that before the refactor, it would return EFI_SUCCESS on R0
when the MAC configuration failed...

> Daniil,
>
> When you originally posted this, you posted it along with
> "EmbeddedPkg: Added device configuration protocol". As Leif is happy
> with this patch as-is, I assume it isn't needed any more. You haven't
> chased it, you didn't respond to my ping about it and it's currently
> in my tree.
>
> Unless you get back to me about it, I'll drop it next time I rebase.
>

And I tested with this patch removed and everything still seemed to
work, so I'm assuming it's not needed and leaving it out unless you
explain otherwise.

> Cheers,
> Ryan.