From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf0-x230.google.com (mail-lf0-x230.google.com [IPv6:2a00:1450:4010:c07::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id AD58F818FA for ; Wed, 11 Jan 2017 04:24:40 -0800 (PST) Received: by mail-lf0-x230.google.com with SMTP id v186so81405802lfa.1 for ; Wed, 11 Jan 2017 04:24:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=HTSQX6C2lMumIU5ARDENJJGXfyW5a8hdbfi0snPclKI=; b=E4ovaY3HUhr9YpQs/HpB05pVmayQgGSo+atupeFNgbxFTGr8ZqM4txy6SEv4237Fy3 mAgjphIqY+vzGgmNBv/Nmrr+ZHXr4+0WtbVUuxujmVK+8mShEH7CsRHPinzTFP5j+cAX SrZ6seqYjyNYsyBZfy0MzbLz8Ih1RnqlKRy1w= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=HTSQX6C2lMumIU5ARDENJJGXfyW5a8hdbfi0snPclKI=; b=mONwYGJLIPY+/4mS0+hPvHumlCtYpFpforMwN0VdeQ5QzTbyB1zrFMw2sTV7h0Ayxu oIeetgzvysQC1Tsu12McXms1ygkuzbnfMPP9P/PXw/OxWU0+dqqM7CDvbA+BwVo1D148 +KIb2QUuKLOb9GA9DhYipLLHt2KICY8rkGKrz4AQg8m94Ta8VBtYsfeb210DwF9Ash0G VM+jQBUq8ovS6iRHoyj9PZYOt1pXJZpiSFD6zyz0NvtzPOSA8aongPCFTOMnT7ryJy7x zW87sRI/2ujjYIdTnLSPhmRYNlrQd7DFvI3ycfWaPbsQfSO54tiqk+E1FfPwpa4UHvr8 Sz+w== X-Gm-Message-State: AIkVDXJS/57Ad1lNtFefA6Jtkuvd38UG3X0H5XA3teWpC/7iZTslp2N7M4acvfObkaXrqpfVFRO/9kJSSsrPO8kt X-Received: by 10.25.40.212 with SMTP id o203mr3230908lfo.1.1484137478985; Wed, 11 Jan 2017 04:24:38 -0800 (PST) MIME-Version: 1.0 Received: by 10.25.33.132 with HTTP; Wed, 11 Jan 2017 04:24:38 -0800 (PST) In-Reply-To: References: <1483996851-37828-1-git-send-email-daniil.egranov@arm.com> <20170110223609.GC24544@bivouac.eciton.net> From: Ryan Harkin Date: Wed, 11 Jan 2017 12:24:38 +0000 Message-ID: To: Leif Lindholm Cc: Daniil Egranov , "edk2-devel@lists.01.org" , Daniil Egranov Subject: Re: [PATCH v4] ArmPlatformPkg/ArmJunoPkg/Drivers/ArmJunoDxe: Set Marvell Yukon MAC address X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Jan 2017 12:24:41 -0000 Content-Type: text/plain; charset=UTF-8 On 11 January 2017 at 11:45, Ryan Harkin wrote: > On 10 January 2017 at 22:36, Leif Lindholm wrote: >> On Mon, Jan 09, 2017 at 03:20:51PM -0600, Daniil Egranov wrote: >>> From: Daniil Egranov >>> >>> The patch reads a valid MAC address form the Juno IOFPGA registers >>> and pushes it into onboard Marvell Yukon NIC. >>> >>> Contributed-under: TianoCore Contribution Agreement 1.0 >>> Signed-off-by: Daniil Egranov >> >> Thanks for sticking with it. >> >> I fixed a typo in commit message an shortened the subject line >> slightly, but: >> Reviewed-by: Leif Lindholm >> Pushed as a8675a1 >> > > Excellent, another patch in my fork that can go. > Unfortunately, while this works on Juno R1 and R2, it hangs R0 every time: ASSERT [ArmJunoDxe] /linaro/platforms/uefi/edk2/ArmPlatformPkg/ArmJunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.c(397): !EFI_ERROR (Status) I guess that before the refactor, it would return EFI_SUCCESS on R0 when the MAC configuration failed... > Daniil, > > When you originally posted this, you posted it along with > "EmbeddedPkg: Added device configuration protocol". As Leif is happy > with this patch as-is, I assume it isn't needed any more. You haven't > chased it, you didn't respond to my ping about it and it's currently > in my tree. > > Unless you get back to me about it, I'll drop it next time I rebase. > And I tested with this patch removed and everything still seemed to work, so I'm assuming it's not needed and leaving it out unless you explain otherwise. > Cheers, > Ryan.