From: Ryan Harkin <ryan.harkin@linaro.org>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Leif Lindholm <leif.lindholm@linaro.org>,
edk2-devel-01 <edk2-devel@lists.01.org>,
Haojian Zhuang <haojian.zhuang@linaro.org>
Subject: Re: [PATCH v8 0/4] enhance MMC
Date: Thu, 24 Nov 2016 18:47:44 +0000 [thread overview]
Message-ID: <CAD0U-hLv__arJfa8HEtk8dPj4di7ky1z4nAu4Zbbch3o4yDw8A@mail.gmail.com> (raw)
In-Reply-To: <CAKv+Gu-vncOQsZr8K698GKuPQ1+N9-v-dV54pKDcH4QrvkjHwA@mail.gmail.com>
On 24 Nov 2016 16:31, "Ard Biesheuvel" <ard.biesheuvel@linaro.org> wrote:
>
> On 23 November 2016 at 13:36, Haojian Zhuang <haojian.zhuang@linaro.org>
wrote:
> > v8:
> > * Avoid to update revision number twice.
> > * Move IsMultiBlock() interface from patch #4 to #1.
> > * Replace 24MHz with 26MHz since 26MHz is specified by spec.
> >
>
> Hi all,
>
> I have pushed this series as follows:
>
> a28b9aef6769 EmbeddedPkg/Protocol/MmcHost: add new methods for I/O
> width and multiblock
> 1df2fe1433b2 ArmPlatformPkg/PL180MciDxe: update for identifying SD
> 752ae80514cc EmbeddedPkg/MmcDxe: invoke SetIos() protocol method to
> set speed and width
> e06253ba80d9 EmbeddedPkg/MmcDxe: set I/O speed and bus width in SD stack
> 339c6e905a15 EmbeddedPkg/MmcDxe: expand to support multiple blocks
>
> where the first patch contains all changes to the protocol
> definitions, and the second patch was pulled forward to maintain
> bisectability.
>
> Thanks a lot to Haojian for the hard work!
>
I just wanted to say "YAY"! :-)
> Regards,
> Ard.
>
>
> > v7:
> > * Add revision checking.
> >
> > v6:
> > * Reformat the last 5 patches after 4 MMC patches of this series
merged.
> > * Squash original #5 and #6 patches together.
> > * Fix according comments.
> >
> > v5:
> > * Remove patch on MediaId.
> > * Squash two PL180 patches together.
> >
> > v4:
> > * Fix PL180 hang in some cases. Since the proper variable length
> > isn't set for CMD6 & ACMD51.
> >
> > v3:
> > * Fix PL180 hang because of CMD6 & ACMD51 not supported.
> >
> > v2:
> > * Fix print error with missing parameter.
> > * Change CMD51 to ACMD51.
> > * Add the protection after CMD55 for SD. If there's no
> > response of CMD55, skip to send ACMD51.
> >
> > v1:
> > * Wait OCR busy bit free according to eMMC spec.
> > * Define ECSD structure.
> > * Add interface to set IO bus width and speed.
> > * Support to access multiple blocks.
> >
> > Haojian Zhuang (4):
> > MmcDxe: add interface in mmc host protocol
> > MmcDxe: set iospeed and bus width in SD stack
> > PL180: update for indentifying SD
> > MmcDxe: expand to support multiple blocks
> >
> > ArmPlatformPkg/Drivers/PL180MciDxe/PL180Mci.c | 29 ++-
> > EmbeddedPkg/Include/Protocol/MmcHost.h | 35 ++-
> > EmbeddedPkg/Universal/MmcDxe/Mmc.h | 25 ++
> > EmbeddedPkg/Universal/MmcDxe/MmcBlockIo.c | 176 +++++++++-----
> > EmbeddedPkg/Universal/MmcDxe/MmcIdentification.c | 291
++++++++++++++++++++++-
> > 5 files changed, 486 insertions(+), 70 deletions(-)
> >
> > --
> > 2.7.4
> >
prev parent reply other threads:[~2016-11-24 18:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-23 13:36 [PATCH v8 0/4] enhance MMC Haojian Zhuang
2016-11-23 13:36 ` [PATCH v8 1/4] MmcDxe: add interface in mmc host protocol Haojian Zhuang
2016-11-23 13:36 ` [PATCH v8 2/4] MmcDxe: set iospeed and bus width in SD stack Haojian Zhuang
2016-11-23 13:36 ` [PATCH v8 3/4] PL180: update for indentifying SD Haojian Zhuang
2016-11-23 13:36 ` [PATCH v8 4/4] MmcDxe: expand to support multiple blocks Haojian Zhuang
2016-11-24 16:31 ` [PATCH v8 0/4] enhance MMC Ard Biesheuvel
2016-11-24 18:47 ` Ryan Harkin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAD0U-hLv__arJfa8HEtk8dPj4di7ky1z4nAu4Zbbch3o4yDw8A@mail.gmail.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox