From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf0-x22c.google.com (mail-lf0-x22c.google.com [IPv6:2a00:1450:4010:c07::22c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 9729881EF2 for ; Thu, 24 Nov 2016 10:47:47 -0800 (PST) Received: by mail-lf0-x22c.google.com with SMTP id c13so34683738lfg.0 for ; Thu, 24 Nov 2016 10:47:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=4hPf6V6wVBTf7LBnjTjTx/JjVCWwJ5wTrKjA7bk75MY=; b=L2VxxP68i+/psxI+n5Q7OgPGyiyNNTwbylxxCt+5+FO/mbop382JYhET/rGmSVzGoH tI0tjvwrn/aOvW/hOLgOl6kERf1by/DUPjM1opB59FWJzjXN7uYkiIzBaTtBcxoxCDLB jEkLApk8vvkUn8j1nadflUqzPRIdAuxfh203A= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=4hPf6V6wVBTf7LBnjTjTx/JjVCWwJ5wTrKjA7bk75MY=; b=ibYBcMPRRFTRRGNUPUy2jyDYqO8aBDCJ+sAirQVCZ7mZPe44lb3MQAkU7G4b4SYwMQ S94kqzaoeYzIpAGKmDTX8XFB/iBGPWUtcazskOgRMEx5TOQR72EHsB7BFpgF/nzaGLch ew3MaitoVSWsQbYJp0mpFS4czugZ+Q9eOkbjKwzvXn/5YFI6D3AvfNUqahawYg+VXayl EU2OmYkdej8tPsCdXPcgFZLK0MJD2KBCF3oHewImtkYWFADp2+yIHn7k/Js1V8GayNuO XBzVCNZA7F+8NdQDAnDxs4nEAtmt6BgJ5QIYdhOIizKJLuNOGofJbDHOBsCIJgLmglbq XfbQ== X-Gm-Message-State: AKaTC01gFMLTRG0uViaBLODcolnAaLww8lzvx3UvfDTDwQVLRdItRhhfFie0AY8rWnkDomMgfFjAMzrOo22IsRUQ X-Received: by 10.46.9.73 with SMTP id 70mr2144069ljj.2.1480013265281; Thu, 24 Nov 2016 10:47:45 -0800 (PST) MIME-Version: 1.0 Received: by 10.25.27.68 with HTTP; Thu, 24 Nov 2016 10:47:44 -0800 (PST) Received: by 10.25.27.68 with HTTP; Thu, 24 Nov 2016 10:47:44 -0800 (PST) In-Reply-To: References: <1479908184-9406-1-git-send-email-haojian.zhuang@linaro.org> From: Ryan Harkin Date: Thu, 24 Nov 2016 18:47:44 +0000 Message-ID: To: Ard Biesheuvel Cc: Leif Lindholm , edk2-devel-01 , Haojian Zhuang X-Content-Filtered-By: Mailman/MimeDel 2.1.21 Subject: Re: [PATCH v8 0/4] enhance MMC X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Nov 2016 18:47:48 -0000 Content-Type: text/plain; charset=UTF-8 On 24 Nov 2016 16:31, "Ard Biesheuvel" wrote: > > On 23 November 2016 at 13:36, Haojian Zhuang wrote: > > v8: > > * Avoid to update revision number twice. > > * Move IsMultiBlock() interface from patch #4 to #1. > > * Replace 24MHz with 26MHz since 26MHz is specified by spec. > > > > Hi all, > > I have pushed this series as follows: > > a28b9aef6769 EmbeddedPkg/Protocol/MmcHost: add new methods for I/O > width and multiblock > 1df2fe1433b2 ArmPlatformPkg/PL180MciDxe: update for identifying SD > 752ae80514cc EmbeddedPkg/MmcDxe: invoke SetIos() protocol method to > set speed and width > e06253ba80d9 EmbeddedPkg/MmcDxe: set I/O speed and bus width in SD stack > 339c6e905a15 EmbeddedPkg/MmcDxe: expand to support multiple blocks > > where the first patch contains all changes to the protocol > definitions, and the second patch was pulled forward to maintain > bisectability. > > Thanks a lot to Haojian for the hard work! > I just wanted to say "YAY"! :-) > Regards, > Ard. > > > > v7: > > * Add revision checking. > > > > v6: > > * Reformat the last 5 patches after 4 MMC patches of this series merged. > > * Squash original #5 and #6 patches together. > > * Fix according comments. > > > > v5: > > * Remove patch on MediaId. > > * Squash two PL180 patches together. > > > > v4: > > * Fix PL180 hang in some cases. Since the proper variable length > > isn't set for CMD6 & ACMD51. > > > > v3: > > * Fix PL180 hang because of CMD6 & ACMD51 not supported. > > > > v2: > > * Fix print error with missing parameter. > > * Change CMD51 to ACMD51. > > * Add the protection after CMD55 for SD. If there's no > > response of CMD55, skip to send ACMD51. > > > > v1: > > * Wait OCR busy bit free according to eMMC spec. > > * Define ECSD structure. > > * Add interface to set IO bus width and speed. > > * Support to access multiple blocks. > > > > Haojian Zhuang (4): > > MmcDxe: add interface in mmc host protocol > > MmcDxe: set iospeed and bus width in SD stack > > PL180: update for indentifying SD > > MmcDxe: expand to support multiple blocks > > > > ArmPlatformPkg/Drivers/PL180MciDxe/PL180Mci.c | 29 ++- > > EmbeddedPkg/Include/Protocol/MmcHost.h | 35 ++- > > EmbeddedPkg/Universal/MmcDxe/Mmc.h | 25 ++ > > EmbeddedPkg/Universal/MmcDxe/MmcBlockIo.c | 176 +++++++++----- > > EmbeddedPkg/Universal/MmcDxe/MmcIdentification.c | 291 ++++++++++++++++++++++- > > 5 files changed, 486 insertions(+), 70 deletions(-) > > > > -- > > 2.7.4 > >