Re: [PATCH] PL180: set variable length for CMD6 and ACMD51

[Haojian Zhuang <haojian.zhuang@linaro.org>]

On 8 November 2016 at 22:58, Leif Lindholm <leif.lindholm@linaro.org> wrote:
> On Tue, Nov 08, 2016 at 12:37:12PM +0000, Ryan Harkin wrote:
>> Hi Haojian,
>>
>> On 7 November 2016 at 15:49, Haojian Zhuang <haojian.zhuang@linaro.org> wrote:
>> > Since CMD6 & ACMD51 needs to read data size less than 512, proper
>> > variable length should be set.
>> >
>>
>> Yay!  Thanks for working out what the problem was with TC2.  I've
>> tested this patch on top of your v3 series of your MMC patches and
>> everything seems to be working now.
>
> Sweet!
> Seconded!
>
> Great work, Haojian.
>
>> I tested in release and debug builds too.
>>
>>
>> > Signed-off-by: Haojian Zhuang <haojian.zhuang@linaro.org>
>>
>> Tested-by: Ryan Harkin <ryan.harkin@linaro.org>
>>
>> However, I have a minor comment about this patch below...
>>
>> I would like to see a series pushed that includes this patch in the
>> correct place so that TC2 does not break at all during the series.  At
>> the moment, TC2 will not be bisect-able if this patch is pushed after
>> the series.
>
> Agreed.
>
>
> Anyway - Haojian, since neither MMC_CMD6 or MMC_ACMD51 are supported
> by the upstream driver, could you fold these changes, including Ryan's
> comments on:
> - #if 1
> - Outdated comment
>
> Into your original set, where these commands were added?
> And then resend your series?
>
> Regards,
>
> Leif
>

No problem. I'll format them and resend them right now.

Best Regards
Haojian