From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk0-x22e.google.com (mail-qk0-x22e.google.com [IPv6:2607:f8b0:400d:c09::22e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 312C681D69 for ; Tue, 8 Nov 2016 07:08:39 -0800 (PST) Received: by mail-qk0-x22e.google.com with SMTP id n21so109011058qka.3 for ; Tue, 08 Nov 2016 07:08:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=UsyCKWAeV+NoqmQINM9ia7I5GjvENZJ/Fn0I0l9ZzvQ=; b=k1suGfXZshwk0WhnA+R/CIcRsEJjwJJ30f5Z25zJbJqLizlqtmqLoAtc7appE84PP7 h165bQiZWqt6/14JRO6iWvA03lpDF14xgyVIC5Yvfh3eKSf4A9n8wbmm60o2//9mEOI5 EyhOaKtCeDPE3oFe+ty3F/GWn0rMMR6CIDNA0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=UsyCKWAeV+NoqmQINM9ia7I5GjvENZJ/Fn0I0l9ZzvQ=; b=Mn+UxqW6hiX/YPBeOyGKcjIKOYEINX+SmpnjtNdKA9Ils8Rd2eiCr45J2Ib04M58cR lJ3SGKl0F8swQvF7O4OzvPdbCAPyFGSOYZewz5bG8s0zTIK5m3cahKE1VJczf8jwArQ2 g++wHAhEBYy4PNbwwlTHWrO3kz2ZDiswGX8UYo93uPk04hRHdZxSqfMm4A79TeW/Y5wU tqW6tiY/gzi1kdCnK4wFbfgk1RmnoBMcP52uwS/7Uosg8CIzsieztAY+dyMMpV1icp/y Fp8QHg3YMMt8f5H4/2lA1bS7dkCwcVBp6qnDVWvXf2WVke2c0Crq7b1/G9gERzYApbyD zcUA== X-Gm-Message-State: ABUngvcuf/OVDG6Bu5EF6f79Y0alL1yHvH+x9ahXNp3x1vCLsq6/ARJWioWBnJmsxF2mfSUFXF7qvXzu7G7xLu8A X-Received: by 10.55.24.7 with SMTP id j7mr13020745qkh.206.1478617721378; Tue, 08 Nov 2016 07:08:41 -0800 (PST) MIME-Version: 1.0 Received: by 10.140.85.165 with HTTP; Tue, 8 Nov 2016 07:08:40 -0800 (PST) In-Reply-To: <20161108145800.GH27644@bivouac.eciton.net> References: <1478533749-17387-1-git-send-email-haojian.zhuang@linaro.org> <20161108145800.GH27644@bivouac.eciton.net> From: Haojian Zhuang Date: Tue, 8 Nov 2016 23:08:40 +0800 Message-ID: To: Leif Lindholm Cc: Ryan Harkin , edk2-devel-01 , Ard Biesheuvel Subject: Re: [PATCH] PL180: set variable length for CMD6 and ACMD51 X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Nov 2016 15:08:39 -0000 Content-Type: text/plain; charset=UTF-8 On 8 November 2016 at 22:58, Leif Lindholm wrote: > On Tue, Nov 08, 2016 at 12:37:12PM +0000, Ryan Harkin wrote: >> Hi Haojian, >> >> On 7 November 2016 at 15:49, Haojian Zhuang wrote: >> > Since CMD6 & ACMD51 needs to read data size less than 512, proper >> > variable length should be set. >> > >> >> Yay! Thanks for working out what the problem was with TC2. I've >> tested this patch on top of your v3 series of your MMC patches and >> everything seems to be working now. > > Sweet! > Seconded! > > Great work, Haojian. > >> I tested in release and debug builds too. >> >> >> > Signed-off-by: Haojian Zhuang >> >> Tested-by: Ryan Harkin >> >> However, I have a minor comment about this patch below... >> >> I would like to see a series pushed that includes this patch in the >> correct place so that TC2 does not break at all during the series. At >> the moment, TC2 will not be bisect-able if this patch is pushed after >> the series. > > Agreed. > > > Anyway - Haojian, since neither MMC_CMD6 or MMC_ACMD51 are supported > by the upstream driver, could you fold these changes, including Ryan's > comments on: > - #if 1 > - Outdated comment > > Into your original set, where these commands were added? > And then resend your series? > > Regards, > > Leif > No problem. I'll format them and resend them right now. Best Regards Haojian