Re: [PATCH 2/2] ArmPlatformPkg/PL061Gpio: fix the offset value in Get function

[Haojian Zhuang <haojian.zhuang@linaro.org>]

On 13 February 2017 at 15:53, Haojian Zhuang <haojian.zhuang@linaro.org> wrote:
> When call PL061GetPins() or PL061SetPins(), should use GPIO_PIN_MASK(offset)
> as parameter, not offset.
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Haojian Zhuang <haojian.zhuang@linaro.org>
> ---
>  ArmPlatformPkg/Drivers/PL061GpioDxe/PL061Gpio.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/ArmPlatformPkg/Drivers/PL061GpioDxe/PL061Gpio.c b/ArmPlatformPkg/Drivers/PL061GpioDxe/PL061Gpio.c
> index ff8bb3b..81b9f6d 100644
> --- a/ArmPlatformPkg/Drivers/PL061GpioDxe/PL061Gpio.c
> +++ b/ArmPlatformPkg/Drivers/PL061GpioDxe/PL061Gpio.c
> @@ -186,7 +186,7 @@ Get (
>      return EFI_INVALID_PARAMETER;
>    }
>
> -  if (PL061GetPins (RegisterBase, Offset)) {
> +  if (PL061GetPins (RegisterBase, GPIO_PIN_MASK(Offset))) {
>      *Value = 1;
>    } else {
>      *Value = 0;
> --
> 2.7.4
>

Correct Ard's email address.

Regards
Haojian